[{"id":19134,"web_url":"https://patchwork.libcamera.org/comment/19134/","msgid":"<YSjEy8jT/9pi2R65@pendragon.ideasonboard.com>","date":"2021-08-27T10:56:11","subject":"Re: [libcamera-devel] [PATCH 1/2] Documentation: Remove obsoleted\n\tconfig","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Fri, Aug 27, 2021 at 11:33:33AM +0100, Kieran Bingham wrote:\n> The CLASS_DIAGRAMS option has become obsolete, and we already define the\n> default value.\n> \n> Remove it.\n> \n> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> ---\n>  Documentation/Doxyfile.in | 9 ---------\n>  1 file changed, 9 deletions(-)\n> \n> diff --git a/Documentation/Doxyfile.in b/Documentation/Doxyfile.in\n> index dc03cbea4b02..49355bf6a9ff 100644\n> --- a/Documentation/Doxyfile.in\n> +++ b/Documentation/Doxyfile.in\n> @@ -2110,15 +2110,6 @@ EXTERNAL_PAGES         = YES\n>  # Configuration options related to the dot tool\n>  #---------------------------------------------------------------------------\n>  \n> -# If the CLASS_DIAGRAMS tag is set to YES, doxygen will generate a class diagram\n> -# (in HTML and LaTeX) for classes with base or super classes. Setting the tag to\n> -# NO turns the diagrams off. Note that this option also works with HAVE_DOT\n> -# disabled, but it is recommended to install and use dot, since it yields more\n> -# powerful graphs.\n> -# The default value is: YES.\n> -\n> -CLASS_DIAGRAMS         = YES\n> -\n>  # You can include diagrams made with dia in doxygen documentation. Doxygen will\n>  # then run dia to produce the diagram and insert it in the documentation. The\n>  # DIA_PATH tag allows you to specify the directory where the dia binary resides.","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 172ACBD87C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 27 Aug 2021 10:56:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 541516891F;\n\tFri, 27 Aug 2021 12:56:26 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C922860256\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 27 Aug 2021 12:56:24 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4D2C95A1;\n\tFri, 27 Aug 2021 12:56:24 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Fe065gfS\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1630061784;\n\tbh=HhxF5EMTBF+vUO6x3MKi6lm329IbDCOEVYRX/Ih13Eo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Fe065gfSqxGJsDu2mMVVZB7xSeyXXWxst3wQL6S6DkhSIvmFjh2TPKYX9OHi/6IFY\n\tLWhaSL7fWpVfofI2I6iyNo5fGQUcfs9TWmksHW2z5mcn8Yru558721cR/e1yiTm0Ay\n\tDUU/gRHBIzEb2xBcgcXEMEMFEJlSLdUcDHxPpnsM=","Date":"Fri, 27 Aug 2021 13:56:11 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Message-ID":"<YSjEy8jT/9pi2R65@pendragon.ideasonboard.com>","References":"<20210827103334.350416-1-kieran.bingham@ideasonboard.com>\n\t<20210827103334.350416-2-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210827103334.350416-2-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 1/2] Documentation: Remove obsoleted\n\tconfig","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera devel <libcamera-devel@lists.libcamera.org>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]