[{"id":19126,"web_url":"https://patchwork.libcamera.org/comment/19126/","msgid":"<7965ff4e-cc7c-a06f-467f-0f6cc605a953@ideasonboard.com>","date":"2021-08-27T08:46:51","subject":"Re: [libcamera-devel] [PATCH 2/2] test: v4l2_compat_test: Fix\n\tv4l2-compliance version parsing","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Paul,\n\nOn 27/08/2021 07:25, Paul Elder wrote:\n> v4l2-compliance changed their version string:\n> \n> v4l2-compliance 1.21.0-4618\n> v4l2-compliance SHA: cc211b76476aca2c072ffa83a9b003957d5f3909, 64 bits, 64-bit time_t\n> \n> v4l2-compliance 1.21.0-4838, 64 bits, 64-bit time_t\n> \n> The current parsing takes the last result of split, which works for the\n> former, but not the latter. Take the second result of split instead, and\n> strip away any commas.\n> \n> Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>\n> \n> ---\n> Kieran, can you please check if this works?\n\n\nGreat, this patch works and does what it needs.\n\nBut now I have a failing test :-(\n\nTesting /dev/video2 with vimc driver... failed\n\nFormat ioctls (Input 0):\n                fail:\n../../../utils/v4l2-compliance/v4l2-test-formats.cpp(263):\nfmtdesc.description mismatch: was 'Video Format Description', expected\n'24-bit RGB 8-8-8'\n        test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: FAIL\n        test VIDIOC_G/S_PARM: OK (Not Supported)\n        test VIDIOC_G_FBUF: OK (Not Supported)\n                fail:\n../../../utils/v4l2-compliance/v4l2-test-formats.cpp(460): pixelformat\n33424752 (RGB3) for buftype 1 not reported by ENUM_FMT\n        test VIDIOC_G_FMT: FAIL\n                fail:\n../../../utils/v4l2-compliance/v4l2-test-formats.cpp(460): pixelformat\n33424752 (RGB3) for buftype 1 not reported by ENUM_FMT\n        test VIDIOC_TRY_FMT: FAIL\n                fail:\n../../../utils/v4l2-compliance/v4l2-test-formats.cpp(460): pixelformat\n33424752 (RGB3) for buftype 1 not reported by ENUM_FMT\n        test VIDIOC_S_FMT: FAIL\n        test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported)\n        test Cropping: OK (Not Supported)\n        test Composing: OK (Not Supported)\n        test Scaling: OK\n\nTotal for libcamera device /dev/video2: 54, Succeeded: 50, Failed: 4,\nWarnings: 1\n\nFailed 1 tests:\n- /dev/video2\n\n\nI wonder if that's a kernel bug more than a bug from us though ?\n\n\n\n> ---\n>  test/v4l2_compat/v4l2_compat_test.py | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/test/v4l2_compat/v4l2_compat_test.py b/test/v4l2_compat/v4l2_compat_test.py\n> index 51bfa952..ae892ced 100755\n> --- a/test/v4l2_compat/v4l2_compat_test.py\n> +++ b/test/v4l2_compat/v4l2_compat_test.py\n> @@ -94,7 +94,7 @@ def main(argv):\n>          return TestSkip\n>  \n>      ret, out = run_with_stdout(v4l2_compliance, '--version')\n> -    if ret != 0 or version.parse(out[0].split()[-1]) < MIN_V4L_UTILS_VERSION:\n> +    if ret != 0 or version.parse(out[0].split()[1].replace(',', '')) < MIN_V4L_UTILS_VERSION:\n>          print('v4l2-compliance version >= 1.21.0 required')\n>          return TestSkip\n>  \n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6962BBD87C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 27 Aug 2021 08:46:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BCC9968932;\n\tFri, 27 Aug 2021 10:46:56 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0185268891\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 27 Aug 2021 10:46:54 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7263F5A1;\n\tFri, 27 Aug 2021 10:46:54 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Sh1NdRvv\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1630054014;\n\tbh=Q+dBKXBJZr08gZMSpPAfftpi1gh2TYH8gycorb+juNI=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=Sh1NdRvvXGiYz6QfcbnRVJ10imWVM1dC7gc1ilRpAgpWKKNJTHpX6bWTkqAZ9kL5U\n\tdZ+/5J9jbJUC3nqVTXoyUCgS0x9kRHbpM6M5xp3nQXY7WtzQE+zDgF8n3nvCxooV05\n\tXXxL4GvtZJhhy6cB3s2DMCJiKSn/IReHYccirmVE=","To":"Paul Elder <paul.elder@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210827062521.2541170-1-paul.elder@ideasonboard.com>\n\t<20210827062521.2541170-2-paul.elder@ideasonboard.com>","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Message-ID":"<7965ff4e-cc7c-a06f-467f-0f6cc605a953@ideasonboard.com>","Date":"Fri, 27 Aug 2021 09:46:51 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.11.0","MIME-Version":"1.0","In-Reply-To":"<20210827062521.2541170-2-paul.elder@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 2/2] test: v4l2_compat_test: Fix\n\tv4l2-compliance version parsing","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":19127,"web_url":"https://patchwork.libcamera.org/comment/19127/","msgid":"<b5475f3b-486a-e096-73b0-7f90acb9b336@ideasonboard.com>","date":"2021-08-27T08:47:53","subject":"Re: [libcamera-devel] [PATCH 2/2] test: v4l2_compat_test: Fix\n\tv4l2-compliance version parsing","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 27/08/2021 07:25, Paul Elder wrote:\n> v4l2-compliance changed their version string:\n> \n> v4l2-compliance 1.21.0-4618\n> v4l2-compliance SHA: cc211b76476aca2c072ffa83a9b003957d5f3909, 64 bits, 64-bit time_t\n> \n> v4l2-compliance 1.21.0-4838, 64 bits, 64-bit time_t\n> \n> The current parsing takes the last result of split, which works for the\n> former, but not the latter. Take the second result of split instead, and\n> strip away any commas.\n> \n> Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>\n> \n> ---\n> Kieran, can you please check if this works?\n> ---\n>  test/v4l2_compat/v4l2_compat_test.py | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/test/v4l2_compat/v4l2_compat_test.py b/test/v4l2_compat/v4l2_compat_test.py\n> index 51bfa952..ae892ced 100755\n> --- a/test/v4l2_compat/v4l2_compat_test.py\n> +++ b/test/v4l2_compat/v4l2_compat_test.py\n> @@ -94,7 +94,7 @@ def main(argv):\n>          return TestSkip\n>  \n>      ret, out = run_with_stdout(v4l2_compliance, '--version')\n> -    if ret != 0 or version.parse(out[0].split()[-1]) < MIN_V4L_UTILS_VERSION:\n> +    if ret != 0 or version.parse(out[0].split()[1].replace(',', '')) < MIN_V4L_UTILS_VERSION:\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n\n>          print('v4l2-compliance version >= 1.21.0 required')\n>          return TestSkip\n>  \n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D8B6EBD87C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 27 Aug 2021 08:47:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 948D068939;\n\tFri, 27 Aug 2021 10:47:57 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 193DE68891\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 27 Aug 2021 10:47:56 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C9A3D5A1;\n\tFri, 27 Aug 2021 10:47:55 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"otLCPZzu\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1630054075;\n\tbh=WRTwxi05HfHsmpm2VPUK2ShxSHZon7cAt6Nco9QzRDU=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=otLCPZzuAkcoryrhgAV+UfpkVp7VY0sln/41IMPKg+3NvhPpfmJaFfVxLdOaJtqR8\n\t/89qeh9PoGDtzHJV3v2ddnEk4iPbQqhrRNl8Igxm6Gh+wB4Xo1K4qApZyJUilYk1BT\n\tpkkC+c/cyYRi8s1OJyT1wZReL+5rA9jZ0O2Bp618=","To":"Paul Elder <paul.elder@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210827062521.2541170-1-paul.elder@ideasonboard.com>\n\t<20210827062521.2541170-2-paul.elder@ideasonboard.com>","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Message-ID":"<b5475f3b-486a-e096-73b0-7f90acb9b336@ideasonboard.com>","Date":"Fri, 27 Aug 2021 09:47:53 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.11.0","MIME-Version":"1.0","In-Reply-To":"<20210827062521.2541170-2-paul.elder@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 2/2] test: v4l2_compat_test: Fix\n\tv4l2-compliance version parsing","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":19139,"web_url":"https://patchwork.libcamera.org/comment/19139/","msgid":"<YSjTVjxcenYl7Gbz@pendragon.ideasonboard.com>","date":"2021-08-27T11:58:14","subject":"Re: [libcamera-devel] [PATCH 2/2] test: v4l2_compat_test: Fix\n\tv4l2-compliance version parsing","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Fri, Aug 27, 2021 at 03:25:21PM +0900, Paul Elder wrote:\n> v4l2-compliance changed their version string:\n> \n> v4l2-compliance 1.21.0-4618\n> v4l2-compliance SHA: cc211b76476aca2c072ffa83a9b003957d5f3909, 64 bits, 64-bit time_t\n> \n> v4l2-compliance 1.21.0-4838, 64 bits, 64-bit time_t\n> \n> The current parsing takes the last result of split, which works for the\n> former, but not the latter. Take the second result of split instead, and\n> strip away any commas.\n> \n> Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nTested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nHowever, the unit test now fails for me:\n\nstderr:\nTraceback (most recent call last):\n  File \"/home/laurent/src/iob/oss/libcamera/libcamera/test/v4l2_compat/v4l2_compat_test.py\", line 159, in <module>\n    sys.exit(main(sys.argv))\n  File \"/home/laurent/src/iob/oss/libcamera/libcamera/test/v4l2_compat/v4l2_compat_test.py\", line 124, in main\n    driver = grep('Driver name', out)[0].split(':')[-1].strip()\nIndexError: list index out of range\n\nThis should be fixed before merging this patch. I'll have a quick look.\n\n> ---\n> Kieran, can you please check if this works?\n> ---\n>  test/v4l2_compat/v4l2_compat_test.py | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/test/v4l2_compat/v4l2_compat_test.py b/test/v4l2_compat/v4l2_compat_test.py\n> index 51bfa952..ae892ced 100755\n> --- a/test/v4l2_compat/v4l2_compat_test.py\n> +++ b/test/v4l2_compat/v4l2_compat_test.py\n> @@ -94,7 +94,7 @@ def main(argv):\n>          return TestSkip\n>  \n>      ret, out = run_with_stdout(v4l2_compliance, '--version')\n> -    if ret != 0 or version.parse(out[0].split()[-1]) < MIN_V4L_UTILS_VERSION:\n> +    if ret != 0 or version.parse(out[0].split()[1].replace(',', '')) < MIN_V4L_UTILS_VERSION:\n>          print('v4l2-compliance version >= 1.21.0 required')\n>          return TestSkip\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9351ABD87D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 27 Aug 2021 11:58:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D0F6D6891F;\n\tFri, 27 Aug 2021 13:58:28 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CB61360256\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 27 Aug 2021 13:58:27 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 469B05A1;\n\tFri, 27 Aug 2021 13:58:27 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rje4BN2b\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1630065507;\n\tbh=5dqibW44/OWBpEncX5wcRj0njN2fjvjK0G7ENVoJ0uA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=rje4BN2bmOicW7qVmkZ2ln4u2qPIaP/u1MkREJfujb03EB3osMXJUS/0qWpEEW6KC\n\t6/YBwGfaSo9AVE7lwM2p1C8ZJa5cgxA5qkCGkmJI9Y/sqGKguZRzpWeqU3Cq3054px\n\tlJEO0KlZ+zXxOJs7Bw6F3tkikSfNJJuHlaZO/mfw=","Date":"Fri, 27 Aug 2021 14:58:14 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Paul Elder <paul.elder@ideasonboard.com>","Message-ID":"<YSjTVjxcenYl7Gbz@pendragon.ideasonboard.com>","References":"<20210827062521.2541170-1-paul.elder@ideasonboard.com>\n\t<20210827062521.2541170-2-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210827062521.2541170-2-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 2/2] test: v4l2_compat_test: Fix\n\tv4l2-compliance version parsing","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":19155,"web_url":"https://patchwork.libcamera.org/comment/19155/","msgid":"<YSlSCRvW5oR/2+v9@pendragon.ideasonboard.com>","date":"2021-08-27T20:58:49","subject":"Re: [libcamera-devel] [PATCH 2/2] test: v4l2_compat_test: Fix\n\tv4l2-compliance version parsing","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Fri, Aug 27, 2021 at 02:58:15PM +0300, Laurent Pinchart wrote:\n> On Fri, Aug 27, 2021 at 03:25:21PM +0900, Paul Elder wrote:\n> > v4l2-compliance changed their version string:\n> > \n> > v4l2-compliance 1.21.0-4618\n> > v4l2-compliance SHA: cc211b76476aca2c072ffa83a9b003957d5f3909, 64 bits, 64-bit time_t\n> > \n> > v4l2-compliance 1.21.0-4838, 64 bits, 64-bit time_t\n> > \n> > The current parsing takes the last result of split, which works for the\n> > former, but not the latter. Take the second result of split instead, and\n> > strip away any commas.\n> > \n> > Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>\n> \n> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> Tested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> \n> However, the unit test now fails for me:\n> \n> stderr:\n> Traceback (most recent call last):\n>   File \"/home/laurent/src/iob/oss/libcamera/libcamera/test/v4l2_compat/v4l2_compat_test.py\", line 159, in <module>\n>     sys.exit(main(sys.argv))\n>   File \"/home/laurent/src/iob/oss/libcamera/libcamera/test/v4l2_compat/v4l2_compat_test.py\", line 124, in main\n>     driver = grep('Driver name', out)[0].split(':')[-1].strip()\n> IndexError: list index out of range\n> \n> This should be fixed before merging this patch. I'll have a quick look.\n\nThis was caused by ASan. \"[PATCH] test: v4l2_compat: Disable test when\nASan is enabled\" works around it. If anyone can find a way to LD_PRELOAD\nlibasan instead, that would be nice.\n\nNow I can reproduce the v4l2-compliance failure itself :-) Here are the\nfailures for my UVC camera:\n\nFormat ioctls (Input 0):\n                fail: v4l2-test-formats.cpp(263): fmtdesc.description mismatch: was 'Video Format Description', expected 'Motion-JPEG'\n        test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: FAIL\n        test VIDIOC_G/S_PARM: OK (Not Supported)\n        test VIDIOC_G_FBUF: OK (Not Supported)\n                fail: v4l2-test-formats.cpp(460): pixelformat 47504a4d (MJPG) for buftype 1 not reported by ENUM_FMT\n        test VIDIOC_G_FMT: FAIL\n                fail: v4l2-test-formats.cpp(460): pixelformat 47504a4d (MJPG) for buftype 1 not reported by ENUM_FMT\n        test VIDIOC_TRY_FMT: FAIL\n                fail: v4l2-test-formats.cpp(460): pixelformat 47504a4d (MJPG) for buftype 1 not reported by ENUM_FMT\n        test VIDIOC_S_FMT: FAIL\n\nAnd for vimc:\n\nFormat ioctls (Input 0):\n                fail: v4l2-test-formats.cpp(263): fmtdesc.description mismatch: was 'Video Format Description', expected '24-bit RGB 8-8-8'\n        test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: FAIL\n        test VIDIOC_G/S_PARM: OK (Not Supported)\n        test VIDIOC_G_FBUF: OK (Not Supported)\n                fail: v4l2-test-formats.cpp(460): pixelformat 33424752 (RGB3) for buftype 1 not reported by ENUM_FMT\n        test VIDIOC_G_FMT: FAIL\n                fail: v4l2-test-formats.cpp(460): pixelformat 33424752 (RGB3) for buftype 1 not reported by ENUM_FMT\n        test VIDIOC_TRY_FMT: FAIL\n                fail: v4l2-test-formats.cpp(460): pixelformat 33424752 (RGB3) for buftype 1 not reported by ENUM_FMT\n        test VIDIOC_S_FMT: FAIL\n\n> > ---\n> > Kieran, can you please check if this works?\n> > ---\n> >  test/v4l2_compat/v4l2_compat_test.py | 2 +-\n> >  1 file changed, 1 insertion(+), 1 deletion(-)\n> > \n> > diff --git a/test/v4l2_compat/v4l2_compat_test.py b/test/v4l2_compat/v4l2_compat_test.py\n> > index 51bfa952..ae892ced 100755\n> > --- a/test/v4l2_compat/v4l2_compat_test.py\n> > +++ b/test/v4l2_compat/v4l2_compat_test.py\n> > @@ -94,7 +94,7 @@ def main(argv):\n> >          return TestSkip\n> >  \n> >      ret, out = run_with_stdout(v4l2_compliance, '--version')\n> > -    if ret != 0 or version.parse(out[0].split()[-1]) < MIN_V4L_UTILS_VERSION:\n> > +    if ret != 0 or version.parse(out[0].split()[1].replace(',', '')) < MIN_V4L_UTILS_VERSION:\n> >          print('v4l2-compliance version >= 1.21.0 required')\n> >          return TestSkip\n> >","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 24471BD87D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 27 Aug 2021 20:59:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 754E66891F;\n\tFri, 27 Aug 2021 22:59:04 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 51F5D60256\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 27 Aug 2021 22:59:03 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C129B52F;\n\tFri, 27 Aug 2021 22:59:02 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"dLEdfQLe\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1630097943;\n\tbh=FS13O8rnbsKHYv8oYeHpLguco06l1DVsKmFQYADWPgE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=dLEdfQLebtisBLOC7mW8xVjE0x5uLdgd279rE3FML5hgUhxTYMtx9nuCFru49MpEB\n\tZ7CCA9fFVq/1lBFTPQKuj1KFxgwkSWDfJLSvuOTg0cVMOvtI2ZOFmXplY8YWa+cac4\n\t5nve7Nlz2jeJcv+c/RduUnj54/magDqcQBEGvFQE=","Date":"Fri, 27 Aug 2021 23:58:49 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Paul Elder <paul.elder@ideasonboard.com>","Message-ID":"<YSlSCRvW5oR/2+v9@pendragon.ideasonboard.com>","References":"<20210827062521.2541170-1-paul.elder@ideasonboard.com>\n\t<20210827062521.2541170-2-paul.elder@ideasonboard.com>\n\t<YSjTVjxcenYl7Gbz@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<YSjTVjxcenYl7Gbz@pendragon.ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 2/2] test: v4l2_compat_test: Fix\n\tv4l2-compliance version parsing","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]