[{"id":19125,"web_url":"https://patchwork.libcamera.org/comment/19125/","msgid":"<3412a654-f875-2113-1b78-7b7fdcbd19f7@ideasonboard.com>","date":"2021-08-27T07:52:43","subject":"Re: [libcamera-devel] [PATCH 1/2] v4l2: v4l2_compat_manager: Don't\n\tprint \"camera not found\" on openat()","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 27/08/2021 07:25, Paul Elder wrote:\n> Some applications (like Firefox) run open() many times on video device\n> nodes. This may lead to user confusion when they see \"INFO V4L2Compat\n> v4l2_compat_manager.cpp:146 No camera found for /dev/videoX\" over and\n> over again.\n> \n> Lower the log level to debug so that we can still get this information\n> on debug, and so users won't see it all the time.\n\nAha, I have the same change in my local tree! :-)\n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Paul Elder \n> ---\n> src/v4l2/v4l2_compat_manager.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/v4l2/v4l2_compat_manager.cpp b/src/v4l2/v4l2_compat_manager.cpp\n> index e566125a..690a191f 100644\n> --- a/src/v4l2/v4l2_compat_manager.cpp\n> +++ b/src/v4l2/v4l2_compat_manager.cpp\n> @@ -143,7 +143,7 @@ int V4L2CompatManager::openat(int dirfd, const char *path, int oflag, mode_t mod\n> \n> \tret = getCameraIndex(fd);\n> \tif (ret < 0) {\n> -\t\tLOG(V4L2Compat, Info) << \"No camera found for \" << path;\n> +\t\tLOG(V4L2Compat, Debug) << \"No camera found for \" << path;\n> \t\treturn fd;\n> \t}\n> \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 767F6BD87D\n\tfor ;\n\tFri, 27 Aug 2021 07:52:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D845F68939;\n\tFri, 27 Aug 2021 09:52:47 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3B96968891\n\tfor ;\n\tFri, 27 Aug 2021 09:52:46 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id ACED85A1;\n\tFri, 27 Aug 2021 09:52:45 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"FVDP/iPD\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1630050765;\n\tbh=HR4ayxHNAu7Qw3sz3m1ghv6kiWR8aAChEWJwS9JBur0=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=FVDP/iPDnwnivBsSYMmKuwWxfdHJTuPSv/gu8w9CQoN1naknPhPc1ZyAqlxjxjrQj\n\tmsI0LpxaEum3HdDmuVh68VYGalXc8WEjyQCJ9v5nfLNbjAfgkpz3pWa0lfW4/1C2pn\n\tuN4CiwBOH18NcC4Kgx8V9GPCHtoHLz8EmKkZrOkg=","To":"Paul Elder ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210827062521.2541170-1-paul.elder@ideasonboard.com>","From":"Kieran Bingham ","Message-ID":"<3412a654-f875-2113-1b78-7b7fdcbd19f7@ideasonboard.com>","Date":"Fri, 27 Aug 2021 08:52:43 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.11.0","MIME-Version":"1.0","In-Reply-To":"<20210827062521.2541170-1-paul.elder@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 1/2] v4l2: v4l2_compat_manager: Don't\n\tprint \"camera not found\" on openat()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":19154,"web_url":"https://patchwork.libcamera.org/comment/19154/","msgid":"","date":"2021-08-27T19:42:23","subject":"Re: [libcamera-devel] [PATCH 1/2] v4l2: v4l2_compat_manager: Don't\n\tprint \"camera not found\" on openat()","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Fri, Aug 27, 2021 at 03:25:20PM +0900, Paul Elder wrote:\n> Some applications (like Firefox) run open() many times on video device\n> nodes. This may lead to user confusion when they see \"INFO V4L2Compat\n> v4l2_compat_manager.cpp:146 No camera found for /dev/videoX\" over and\n> over again.\n> \n> Lower the log level to debug so that we can still get this information\n> on debug, and so users won't see it all the time.\n> \n> Signed-off-by: Paul Elder \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/v4l2/v4l2_compat_manager.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/v4l2/v4l2_compat_manager.cpp b/src/v4l2/v4l2_compat_manager.cpp\n> index e566125a..690a191f 100644\n> --- a/src/v4l2/v4l2_compat_manager.cpp\n> +++ b/src/v4l2/v4l2_compat_manager.cpp\n> @@ -143,7 +143,7 @@ int V4L2CompatManager::openat(int dirfd, const char *path, int oflag, mode_t mod\n> \n> \tret = getCameraIndex(fd);\n> \tif (ret < 0) {\n> -\t\tLOG(V4L2Compat, Info) << \"No camera found for \" << path;\n> +\t\tLOG(V4L2Compat, Debug) << \"No camera found for \" << path;\n> \t\treturn fd;\n> \t}\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 468D3BD87C\n\tfor ;\n\tFri, 27 Aug 2021 19:42:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 88BE46891F;\n\tFri, 27 Aug 2021 21:42:39 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 99EA460256\n\tfor ;\n\tFri, 27 Aug 2021 21:42:37 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 148C452F;\n\tFri, 27 Aug 2021 21:42:37 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"P/eKH3S8\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1630093357;\n\tbh=uPZhxzL47gLftB89lq5pgKWkXQ2/w0SiEU2WnqbQdzQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=P/eKH3S8NY65DNQxngIESpbnBYo1Y/jVoYMEsv0Me4a7Ad6MtpZUb4kPKcIRfokYs\n\tVGug46Z6SpeVIOq90cEYD5t9JSxGnYRmfJfBTWDAxgHJHpTQB8u0PF4VRGl7GthB4H\n\tNLbaxI8V8iVVmyM3Cbif4o4Zp2lYWALXkvY1/iFg=","Date":"Fri, 27 Aug 2021 22:42:23 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Message-ID":"","References":"<20210827062521.2541170-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210827062521.2541170-1-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 1/2] v4l2: v4l2_compat_manager: Don't\n\tprint \"camera not found\" on openat()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]