[{"id":19170,"web_url":"https://patchwork.libcamera.org/comment/19170/","msgid":"","date":"2021-08-30T11:30:23","subject":"Re: [libcamera-devel] [PATCH v1 1/6] libcamera: Use simpler\n\tSignal::disconnect() function","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 8/27/21 8:08 AM, Laurent Pinchart wrote:\n> When disconnecting a signal from a receiver, it is usually not necessary\n> to specify the receiver's slot function explicitly, as the signal is\n> often connected to a single slot for a given receiver. We can thus use a\n> simpler version of Signal::disconnect() that takes a pointer to the\n> receiver object only. This reduces code size, as the disconnect()\n> function is a template function.\n\n\nAh, interesting, I was ignorant about this particular existence of \ndisconnect()\n\n>\n> Signed-off-by: Laurent Pinchart \n\n\nReviewed-by: Umang Jain \n\n> ---\n> src/lc-compliance/simple_capture.cpp | 2 +-\n> src/libcamera/camera_manager.cpp | 2 +-\n> src/qcam/main_window.cpp | 4 ++--\n> test/camera/camera_reconfigure.cpp | 2 +-\n> 4 files changed, 5 insertions(+), 5 deletions(-)\n>\n> diff --git a/src/lc-compliance/simple_capture.cpp b/src/lc-compliance/simple_capture.cpp\n> index 25097f28a603..ab5cb35c11f2 100644\n> --- a/src/lc-compliance/simple_capture.cpp\n> +++ b/src/lc-compliance/simple_capture.cpp\n> @@ -62,7 +62,7 @@ void SimpleCapture::stop()\n> \n> \tcamera_->stop();\n> \n> -\tcamera_->requestCompleted.disconnect(this, &SimpleCapture::requestComplete);\n> +\tcamera_->requestCompleted.disconnect(this);\n> \n> \tStream *stream = config_->at(0).stream();\n> \tallocator_->free(stream);\n> diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\n> index fe80a46f5d20..08457030b6f7 100644\n> --- a/src/libcamera/camera_manager.cpp\n> +++ b/src/libcamera/camera_manager.cpp\n> @@ -170,7 +170,7 @@ void CameraManager::Private::createPipelineHandlers()\n> \n> void CameraManager::Private::cleanup()\n> {\n> -\tenumerator_->devicesAdded.disconnect(this, &Private::createPipelineHandlers);\n> +\tenumerator_->devicesAdded.disconnect(this);\n> \n> \t/*\n> \t * Release all references to cameras to ensure they all get destroyed\n> diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\n> index 1adaae60d83b..dea81bb43774 100644\n> --- a/src/qcam/main_window.cpp\n> +++ b/src/qcam/main_window.cpp\n> @@ -531,7 +531,7 @@ int MainWindow::startCapture()\n> \treturn 0;\n> \n> error_disconnect:\n> -\tcamera_->requestCompleted.disconnect(this, &MainWindow::requestComplete);\n> +\tcamera_->requestCompleted.disconnect(this);\n> \tcamera_->stop();\n> \n> error:\n> @@ -571,7 +571,7 @@ void MainWindow::stopCapture()\n> \tif (ret)\n> \t\tqInfo() << \"Failed to stop capture\";\n> \n> -\tcamera_->requestCompleted.disconnect(this, &MainWindow::requestComplete);\n> +\tcamera_->requestCompleted.disconnect(this);\n> \n> \tfor (auto &iter : mappedBuffers_) {\n> \t\tconst Span &buffer = iter.second;\n> diff --git a/test/camera/camera_reconfigure.cpp b/test/camera/camera_reconfigure.cpp\n> index 5adef16e1c9e..48d61c00709c 100644\n> --- a/test/camera/camera_reconfigure.cpp\n> +++ b/test/camera/camera_reconfigure.cpp\n> @@ -130,7 +130,7 @@ private:\n> \t\t\treturn TestFail;\n> \t\t}\n> \n> -\t\tcamera_->requestCompleted.disconnect(this, &CameraReconfigure::requestComplete);\n> +\t\tcamera_->requestCompleted.disconnect(this);\n> \n> \t\trequests_.clear();\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B303DBD87D\n\tfor ;\n\tMon, 30 Aug 2021 11:30:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 240BF6916A;\n\tMon, 30 Aug 2021 13:30:30 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7704D60258\n\tfor ;\n\tMon, 30 Aug 2021 13:30:29 +0200 (CEST)","from [192.168.1.104] (unknown [103.251.226.0])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9AACE5A7;\n\tMon, 30 Aug 2021 13:30:28 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"VTAMqJS3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1630323029;\n\tbh=F/LZEsn9JqWpOF1Yw2WrHGZgac6Lu6KbhU/jtvW0R3Y=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=VTAMqJS33mEZ7Cf742oIcK5AuRimA6s1zRDNj2caL3XAVL9Tr7K6ispm1r5xMMTN4\n\tuk8jFb6tnfa1sY8/4TUw+rZHjNmGWISVY2AZj0kEJfkXAOwJUgYLBjhIrL/6bGXDMa\n\tUjbitIQneQrfaVrPQlxb3qVb0B6iVcpWCQYEfyBU=","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210827023829.5871-1-laurent.pinchart@ideasonboard.com>\n\t<20210827023829.5871-2-laurent.pinchart@ideasonboard.com>","From":"Umang Jain ","Message-ID":"","Date":"Mon, 30 Aug 2021 17:00:23 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.10.2","MIME-Version":"1.0","In-Reply-To":"<20210827023829.5871-2-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH v1 1/6] libcamera: Use simpler\n\tSignal::disconnect() function","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]