[{"id":191,"web_url":"https://patchwork.libcamera.org/comment/191/","msgid":"<20190103211655.GC22790@bigcity.dyn.berto.se>","date":"2019-01-03T21:16:55","subject":"Re: [libcamera-devel] [PATCH 1/9] libcamera: camera_manager: Remove\n\tput() method","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2019-01-03 03:31:02 +0200, Laurent Pinchart wrote:\n> The method is declared but not implemented. Remove it.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> include/libcamera/camera_manager.h | 1 -\n> 1 file changed, 1 deletion(-)\n> \n> diff --git a/include/libcamera/camera_manager.h b/include/libcamera/camera_manager.h\n> index 9d032d71c4c0..43a7811b3ea2 100644\n> --- a/include/libcamera/camera_manager.h\n> +++ b/include/libcamera/camera_manager.h\n> @@ -26,7 +26,6 @@ public:\n> \n> \tstd::vector list() const;\n> \tCamera *get(const std::string &name);\n> -\tvoid put(Camera *camera);\n> \n> private:\n> \tDeviceEnumerator *enumerator_;\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x141.google.com (mail-lf1-x141.google.com\n\t[IPv6:2a00:1450:4864:20::141])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D1E3B60B21\n\tfor ;\n\tThu, 3 Jan 2019 22:16:57 +0100 (CET)","by mail-lf1-x141.google.com with SMTP id p6so24176453lfc.1\n\tfor ;\n\tThu, 03 Jan 2019 13:16:57 -0800 (PST)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\tb128sm10943104lfe.91.2019.01.03.13.16.56\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 03 Jan 2019 13:16:56 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=4MpDo9YqeuiXcxobdjru4R0tm2UNVC4A43VSNkOoefs=;\n\tb=nev1ELFs6idiepBpKig4yTLJGF35rn97EguArRx/X8yvspXwN0nupsBzRnn/XGYzFq\n\tE/3fZdTxlWKoE/fiF4pGGP7J8QM8uLO31rJV8VhBAeHM8mlkeb8RUVKWi1C0Bh2T3JaH\n\tQAAazYF5vgyGrOmyRquaWuTrEsOoOcWcbb0Rfan24feDHe+W2cQckWS10mJfbPYRxiyL\n\tgOwBhURhAOGnFOydUQ+EBKFK+KBJVgdhQLGJvxUcimWu3XiPt40AKG04LkN3NF1VYHV+\n\tUccjAyFyGw+Mx5v5SoWVsO6YtnBXXcFNGmLBvFbhZOjiC6gOEhYNstzQ35zhWMHVrVj6\n\tuW7w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=4MpDo9YqeuiXcxobdjru4R0tm2UNVC4A43VSNkOoefs=;\n\tb=OWpxXZN7dLJYgOaI6HjgsGPQt8imhz0HedY5fkIyGhYzNDaLVMkTrFi8eayxmkpxNH\n\t/7UkMKeTu2XhqiSCFFWqAtprGT9ziE+8bUcJYA7uM4Q3d3M8JkJvm/wRkCa0BkAOcyP7\n\tcLZNy11a4HO4RpZN+a3wai+0p+bhEMujHDk8vg5Pex++gk51sepf7mFtojGc39B2yOKN\n\tI/HbQM14mGLpPFNvcHu+iUFNYiO9DCaguhTAxoscsd9a0W3A1JPZPrIVA58YIv1jYkMo\n\tZXC9oCcGozoVw94SzcBqfgdpPNl9nzOQNLR9KPQbe5rXSsOznb1q3tPh1/p00HsclJD2\n\td41g==","X-Gm-Message-State":"AJcUukdjRU7Z7wGxsptIGhUxn4I52eB3DxLZI9lw4asDkpTI9gqKZKxD\n\txVFBSdf7XopglInIHHf2HjyTwA==","X-Google-Smtp-Source":"ALg8bN4DK5/mxfN+L7lnag4ZtO5SS1GQqGbsylw/jqPPeOvkZ04chyMxFTE/QwC1DMDbUNvpmiTsiQ==","X-Received":"by 2002:a19:a104:: with SMTP id k4mr16298709lfe.36.1546550216795;\n\tThu, 03 Jan 2019 13:16:56 -0800 (PST)","Date":"Thu, 3 Jan 2019 22:16:55 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190103211655.GC22790@bigcity.dyn.berto.se>","References":"<20190103013110.6849-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190103013110.6849-1-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 1/9] libcamera: camera_manager: Remove\n\tput() method","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 03 Jan 2019 21:16:58 -0000"}}]