[{"id":19071,"web_url":"https://patchwork.libcamera.org/comment/19071/","msgid":"<YSah6TixdDpuAt+3@pendragon.ideasonboard.com>","date":"2021-08-25T20:02:49","subject":"Re: [libcamera-devel] [PATCH v2] README.rst: Update gstreamer\n\telement guidance","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Wed, Aug 25, 2021 at 08:53:38PM +0100, Kieran Bingham wrote:\n> The Gstreamer gstlibcamerasrc element operates better with the\n> glimagesink, as it can perform direct renders or hardware accellerated\n> image format conversion.\n> \n> Further extend the sample commands to demonstrate how to specify a fixed\n> width and height parameter to the pipeline.\n> \n> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> \n> ---\n>  README.rst | 21 ++++++++++++++++++---\n>  1 file changed, 18 insertions(+), 3 deletions(-)\n> \n> diff --git a/README.rst b/README.rst\n> index fcf0f47f14c5..d5b36e21dec6 100644\n> --- a/README.rst\n> +++ b/README.rst\n> @@ -94,17 +94,32 @@ Using GStreamer plugin\n>  ~~~~~~~~~~~~~~~~~~~~~~\n>  \n>  To use GStreamer plugin from source tree, set the following environment so that\n> -GStreamer can find it.\n> +GStreamer can find it. This isn't necessary when libcamera is installed.\n>  \n>    export GST_PLUGIN_PATH=$(pwd)/build/src/gstreamer\n>  \n>  The debugging tool ``gst-launch-1.0`` can be used to construct a pipeline and\n>  test it. The following pipeline will stream from the camera named \"Camera 1\"\n> -onto the default video display element on your system.\n> +onto the OpenGL accelerated display element on your system.\n>  \n>  .. code::\n>  \n> -  gst-launch-1.0 libcamerasrc camera-name=\"Camera 1\" ! videoconvert ! autovideosink\n> +  gst-launch-1.0 libcamerasrc camera-name=\"Camera 1\" ! glimagesink\n> +\n> +To show the first camera found you can omit the camera-name property, or you\n> +can identify the camera and capabilities using:\n\nMaybe \"can list the cameras and their capabilities using:\" ?\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> +\n> +.. code::\n> +\n> +  gst-device-monitor-1.0 Video\n> +\n> +This will also show the supported stream sizes which can be manually selected\n> +if desired with a pipeline such as:\n> +\n> +.. code::\n> +\n> +  gst-launch-1.0 libcamerasrc ! 'video/x-raw,width=1280,height=720' ! \\\n> +        glimagesink\n>  \n>  .. section-end-getting-started\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 908F2BD87D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 25 Aug 2021 20:03:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4B6B168893;\n\tWed, 25 Aug 2021 22:03:03 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1446960288\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 25 Aug 2021 22:03:02 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A151124F;\n\tWed, 25 Aug 2021 22:03:01 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"gG/hOnDj\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1629921781;\n\tbh=MtMZhlB7g9/WR2piYLUe+ZNl/2oJTbXITcoTZ5tyKqg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=gG/hOnDjNp6AlPbEMOA5K7zwLj9Zklf8gmL+Ib6MCyVs3HDdWKAQ8r0nEKQ+62ILh\n\tDSRrOeh9UcPXmxTPcc06GjT0Q3bZhEroaDl9iSKx9rD8hPhMQhAaHEJ23MSk6LAB4I\n\tOb2aR2nigK+RxQ6a8khYJ0vPfwEu5QEUftDzcBOY=","Date":"Wed, 25 Aug 2021 23:02:49 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Message-ID":"<YSah6TixdDpuAt+3@pendragon.ideasonboard.com>","References":"<20210825195338.185663-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210825195338.185663-1-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2] README.rst: Update gstreamer\n\telement guidance","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera devel <libcamera-devel@lists.libcamera.org>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":19084,"web_url":"https://patchwork.libcamera.org/comment/19084/","msgid":"<20210826035108.GH968527@pyrite.rasen.tech>","date":"2021-08-26T03:51:08","subject":"Re: [libcamera-devel] [PATCH v2] README.rst: Update gstreamer\n\telement guidance","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Wed, Aug 25, 2021 at 08:53:38PM +0100, Kieran Bingham wrote:\n> The Gstreamer gstlibcamerasrc element operates better with the\n> glimagesink, as it can perform direct renders or hardware accellerated\n> image format conversion.\n> \n> Further extend the sample commands to demonstrate how to specify a fixed\n> width and height parameter to the pipeline.\n> \n> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\nReviewed-by: Paul Elder <paul.elder@ideasonboard.com>\n\n> \n> ---\n>  README.rst | 21 ++++++++++++++++++---\n>  1 file changed, 18 insertions(+), 3 deletions(-)\n> \n> diff --git a/README.rst b/README.rst\n> index fcf0f47f14c5..d5b36e21dec6 100644\n> --- a/README.rst\n> +++ b/README.rst\n> @@ -94,17 +94,32 @@ Using GStreamer plugin\n>  ~~~~~~~~~~~~~~~~~~~~~~\n>  \n>  To use GStreamer plugin from source tree, set the following environment so that\n> -GStreamer can find it.\n> +GStreamer can find it. This isn't necessary when libcamera is installed.\n>  \n>    export GST_PLUGIN_PATH=$(pwd)/build/src/gstreamer\n>  \n>  The debugging tool ``gst-launch-1.0`` can be used to construct a pipeline and\n>  test it. The following pipeline will stream from the camera named \"Camera 1\"\n> -onto the default video display element on your system.\n> +onto the OpenGL accelerated display element on your system.\n>  \n>  .. code::\n>  \n> -  gst-launch-1.0 libcamerasrc camera-name=\"Camera 1\" ! videoconvert ! autovideosink\n> +  gst-launch-1.0 libcamerasrc camera-name=\"Camera 1\" ! glimagesink\n> +\n> +To show the first camera found you can omit the camera-name property, or you\n> +can identify the camera and capabilities using:\n> +\n> +.. code::\n> +\n> +  gst-device-monitor-1.0 Video\n> +\n> +This will also show the supported stream sizes which can be manually selected\n> +if desired with a pipeline such as:\n> +\n> +.. code::\n> +\n> +  gst-launch-1.0 libcamerasrc ! 'video/x-raw,width=1280,height=720' ! \\\n> +        glimagesink\n>  \n>  .. section-end-getting-started\n>  \n> -- \n> 2.30.2\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C8112BD87D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 26 Aug 2021 03:51:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 240A660256;\n\tThu, 26 Aug 2021 05:51:18 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9CF4D60256\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 26 Aug 2021 05:51:16 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E07A96F2;\n\tThu, 26 Aug 2021 05:51:14 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Dyw30hUL\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1629949876;\n\tbh=Xl4Z4rrWiEY6/9YiI4ikgPhrW337qJPO8Z0R7xMxB2U=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Dyw30hULBpbJ2OdPgbTxHfIh8k9+UL2OeNFXau4qBhVnbX0Bn8V1YZhSG5Y3hjCMC\n\tCrBh36lbtQT4wqq7XlSHK0amB/9hJKY9CycpdGQFo3oBu+751GTDHogM/zCIVj9zSm\n\t6phvESrRrlXtFdJkJjGWU9USq4xkCqs2S390PF0Q=","Date":"Thu, 26 Aug 2021 12:51:08 +0900","From":"paul.elder@ideasonboard.com","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Message-ID":"<20210826035108.GH968527@pyrite.rasen.tech>","References":"<20210825195338.185663-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20210825195338.185663-1-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2] README.rst: Update gstreamer\n\telement guidance","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera devel <libcamera-devel@lists.libcamera.org>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]