[{"id":19063,"web_url":"https://patchwork.libcamera.org/comment/19063/","msgid":"","date":"2021-08-25T19:28:14","subject":"Re: [libcamera-devel] [PATCH 4/5] Documentation:\n\tapplication-developer: Fix reference to cam BufferWriter","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Wed, Aug 25, 2021 at 11:29:36AM +0100, Kieran Bingham wrote:\n> The BufferWriter class has been replaced by the FileSink.\n> \n> Adapt the reference, to match the source code.\n> \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> Documentation/guides/application-developer.rst | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/Documentation/guides/application-developer.rst b/Documentation/guides/application-developer.rst\n> index e2ed79d5173e..5f43af9e5a7a 100644\n> --- a/Documentation/guides/application-developer.rst\n> +++ b/Documentation/guides/application-developer.rst\n> @@ -466,10 +466,10 @@ and the bytes used by planes.\n> A completed buffer contains of course image data which can be accessed through\n> the per-plane dma-buf file descriptor transported by the ``FrameBuffer``\n> instance. An example of how to write image data to disk is available in the\n> -`BufferWriter class`_ which is a part of the ``cam`` utility application in the\n> +`FileSink class`_ which is a part of the ``cam`` utility application in the\n> libcamera repository.\n> \n> -.. _BufferWriter class: https://git.linuxtv.org/libcamera.git/tree/src/cam/buffer_writer.cpp\n> +.. _FileSink class: https://git.linuxtv.org/libcamera.git/tree/src/cam/file_sink.cpp\n> \n> With the handling of this request completed, it is possible to re-use the\n> buffers by adding them to a new ``Request`` instance with their matching","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A9C6CBD87C\n\tfor ;\n\tWed, 25 Aug 2021 19:28:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 75DFB68893;\n\tWed, 25 Aug 2021 21:28:27 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B8EE760288\n\tfor ;\n\tWed, 25 Aug 2021 21:28:26 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 591E424F;\n\tWed, 25 Aug 2021 21:28:26 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"N+D14X/s\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1629919706;\n\tbh=WHAjHmmb4ctCefsP1FBt8mW+xzZRPvTFoWOjmNsEAvg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=N+D14X/sO3ULLIwMY6Spf4TN3O8iBs9cGIl6OWqXYX9idoHzBrLYO3ok4s8XqZcwc\n\twkXnf4D2kQ+1nEWfEFm5zywnRu6EvDvK+6pco0NQtPDyAhsfdtrM+YXwKSc5WwhIWN\n\tTYkT9Z9qwZISUSQi4eV3ovg2Cn7Z36DnVh+YjD1Q=","Date":"Wed, 25 Aug 2021 22:28:14 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20210825102937.3740405-1-kieran.bingham@ideasonboard.com>\n\t<20210825102937.3740405-5-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210825102937.3740405-5-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 4/5] Documentation:\n\tapplication-developer: Fix reference to cam BufferWriter","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]