[{"id":19061,"web_url":"https://patchwork.libcamera.org/comment/19061/","msgid":"","date":"2021-08-25T19:27:29","subject":"Re: [libcamera-devel] [PATCH 2/5] Documentation:\n\tapplication-developer: Clean up build instructions","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Wed, Aug 25, 2021 at 11:29:34AM +0100, Kieran Bingham wrote:\n> The build and run instructions read as if meson is the only way to\n> compile the application. Although this is recommended, it is not\n> required - adapt the language to fit better.\n> \n> While here, fix the naming of the simple_cam meson object to match\n> the other usages of 'simple-cam'.\n> \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> Documentation/guides/application-developer.rst | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/Documentation/guides/application-developer.rst b/Documentation/guides/application-developer.rst\n> index b79241bd9317..442d8e6a512e 100644\n> --- a/Documentation/guides/application-developer.rst\n> +++ b/Documentation/guides/application-developer.rst\n> @@ -563,8 +563,8 @@ uses, so needs to do the following:\n> Build and run instructions\n> --------------------------\n> \n> -To build the application, use the `Meson build system`_ which is also the\n> -official build system of the libcamera library.\n> +To build the application, we recommend that you use the `Meson build system`_\n> +which is also the official build system of the libcamera library.\n> \n> Make sure both ``meson`` and ``libcamera`` are installed in your system. Please\n> refer to your distribution documentation to install meson and install the most\n> @@ -617,7 +617,7 @@ accordingly. In this example, the application file has been named\n> \n> project('simple-cam', 'cpp')\n> \n> - simpler_cam = executable('simple-cam',\n> + simple_cam = executable('simple-cam',\n> 'simple-cam.cpp',\n> dependencies: dependency('libcamera', required : true))\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DC796BD87C\n\tfor ;\n\tWed, 25 Aug 2021 19:27:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 91B0268893;\n\tWed, 25 Aug 2021 21:27:43 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AAD4C60288\n\tfor ;\n\tWed, 25 Aug 2021 21:27:41 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 428E224F;\n\tWed, 25 Aug 2021 21:27:41 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"XYTdzSQP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1629919661;\n\tbh=R0If8OlmGExgaJ3GErvgtmsD1Fa7ZK38DAwc9COdS8s=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=XYTdzSQPrVuzr0yoBZSzQGYNV+gib1IMhghjk9BxEj3boLAG54YIUbZRUvLdjvYtr\n\tvCzK6bbIrEUA/b9Si/ilOxThYgtehhswBuqC/uZV8hdzJQtCaQjfjd6ooYySIjwSXp\n\tGUZyYyGUDfc0PEhCqVfqF+t9xpwOPPk+4vPkIFGU=","Date":"Wed, 25 Aug 2021 22:27:29 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20210825102937.3740405-1-kieran.bingham@ideasonboard.com>\n\t<20210825102937.3740405-3-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210825102937.3740405-3-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 2/5] Documentation:\n\tapplication-developer: Clean up build instructions","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]