[{"id":19059,"web_url":"https://patchwork.libcamera.org/comment/19059/","msgid":"","date":"2021-08-25T14:29:32","subject":"Re: [libcamera-devel] [PATCH] README.rst: Update gstreamer element\n\tguidance","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Wed, Aug 25, 2021 at 11:27:48AM +0100, Kieran Bingham wrote:\n> The Gstreamer gstlibcamerasrc element operates better with the\n> glimagesink, as it can perform direct renders or hardware accellerated\n> image format conversion.\n> \n> Further extend the sample commands to demonstrate how to specify a fixed\n> width and height parameter to the pipeline.\n> \n> Signed-off-by: Kieran Bingham \n> ---\n> README.rst | 19 +++++++++++++++++--\n> 1 file changed, 17 insertions(+), 2 deletions(-)\n> \n> diff --git a/README.rst b/README.rst\n> index fcf0f47f14c5..61ba8418a62a 100644\n> --- a/README.rst\n> +++ b/README.rst\n> @@ -94,7 +94,7 @@ Using GStreamer plugin\n> ~~~~~~~~~~~~~~~~~~~~~~\n> \n> To use GStreamer plugin from source tree, set the following environment so that\n> -GStreamer can find it.\n> +GStreamer can find it, (This can be skipped when libcamera is installed)\n\nThis looks weird. Did you maybe mean\n\nGStreamer can find it (this can be skipped when libcamera is installed).\n\nor\n\nGStreamer can find it (this can be skipped when libcamera is installed):\n\n? You could also write\n\nGStreamer can find it. This isn't necessary when libcamera is installed.\n\n> \n> export GST_PLUGIN_PATH=$(pwd)/build/src/gstreamer\n> \n> @@ -104,7 +104,22 @@ onto the default video display element on your system.\n\nThe above comment isn't accurate anymore.\n\n> \n> .. code::\n> \n> - gst-launch-1.0 libcamerasrc camera-name=\"Camera 1\" ! videoconvert ! autovideosink\n> + gst-launch-1.0 libcamerasrc camera-name=\"Camera 1\" ! glimagesink\n> +\n> +To show the first camera found you can omit the camera-name property, or you\n> +can identify the camera and capabilities using:\n> +\n> +.. code::\n> +\n> + gst-device-monitor-1.0 Video\n> +\n> +This will show the supported stream sizes which can be manually selected if\n\ns/will/will also/\n\n> +desired with a pipeline such as:\n> +\n> +.. code::\n> +\n> + gst-launch-1.0 libcamerasrc ! 'video/x-raw,width=1280,height=720' ! \\\n> + glimagesink\n> \n> .. section-end-getting-started\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6CD5CBD87C\n\tfor ;\n\tWed, 25 Aug 2021 14:29:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B67A268893;\n\tWed, 25 Aug 2021 16:29:45 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CDE6760259\n\tfor ;\n\tWed, 25 Aug 2021 16:29:44 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 603B224F;\n\tWed, 25 Aug 2021 16:29:44 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"NkXPfGyC\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1629901784;\n\tbh=LvYvSl02QxkLQaYd7JQFjf1UUzZ9asEjneMOOWEfQBQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=NkXPfGyCsh9FeRgCtM6FiAGAYxrCV5b5sX0pT2uy2IQ/Od57WkbFcQ73IK1bbPgDY\n\tzmZqRTxqgcBia/LrP2gtDATKwn4aQcJsfU5eNzrnCCyaF3Jt/rnMSRC8kv6PMkB8jG\n\tXn458ElVD9wjVWlI8AdWxxDQZki4m88meW2W/ZhU=","Date":"Wed, 25 Aug 2021 17:29:32 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20210825102748.3738346-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210825102748.3738346-1-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] README.rst: Update gstreamer element\n\tguidance","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":19065,"web_url":"https://patchwork.libcamera.org/comment/19065/","msgid":"<25670749-5435-f720-e157-c139ed07c980@ideasonboard.com>","date":"2021-08-25T19:46:48","subject":"Re: [libcamera-devel] [PATCH] README.rst: Update gstreamer element\n\tguidance","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 25/08/2021 15:29, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> Thank you for the patch.\n> \n> On Wed, Aug 25, 2021 at 11:27:48AM +0100, Kieran Bingham wrote:\n>> The Gstreamer gstlibcamerasrc element operates better with the\n>> glimagesink, as it can perform direct renders or hardware accellerated\n>> image format conversion.\n>>\n>> Further extend the sample commands to demonstrate how to specify a fixed\n>> width and height parameter to the pipeline.\n>>\n>> Signed-off-by: Kieran Bingham \n>> ---\n>> README.rst | 19 +++++++++++++++++--\n>> 1 file changed, 17 insertions(+), 2 deletions(-)\n>>\n>> diff --git a/README.rst b/README.rst\n>> index fcf0f47f14c5..61ba8418a62a 100644\n>> --- a/README.rst\n>> +++ b/README.rst\n>> @@ -94,7 +94,7 @@ Using GStreamer plugin\n>> ~~~~~~~~~~~~~~~~~~~~~~\n>> \n>> To use GStreamer plugin from source tree, set the following environment so that\n>> -GStreamer can find it.\n>> +GStreamer can find it, (This can be skipped when libcamera is installed)\n> \n> This looks weird. Did you maybe mean\n> \n> GStreamer can find it (this can be skipped when libcamera is installed).\n> \n> or\n> \n> GStreamer can find it (this can be skipped when libcamera is installed):\n> \n> ? You could also write\n> \n> GStreamer can find it. This isn't necessary when libcamera is installed.\n\nI'll take that one.\n\n>> \n>> export GST_PLUGIN_PATH=$(pwd)/build/src/gstreamer\n>> \n>> @@ -104,7 +104,22 @@ onto the default video display element on your system.\n> \n> The above comment isn't accurate anymore.\n\nWill this fix it enough for you ?\n\n\"\"\"\nThe following pipeline will stream from the camera named \"Camera 1\"\nonto the OpenGL accelerated display element on your system.\n\"\"\"\n\n>> .. code::\n>> \n>> - gst-launch-1.0 libcamerasrc camera-name=\"Camera 1\" ! videoconvert ! autovideosink\n>> + gst-launch-1.0 libcamerasrc camera-name=\"Camera 1\" ! glimagesink\n>> +\n>> +To show the first camera found you can omit the camera-name property, or you\n>> +can identify the camera and capabilities using:\n>> +\n>> +.. code::\n>> +\n>> + gst-device-monitor-1.0 Video\n>> +\n>> +This will show the supported stream sizes which can be manually selected if\n> \n> s/will/will also/\n\n\n>> +desired with a pipeline such as:\n>> +\n>> +.. code::\n>> +\n>> + gst-launch-1.0 libcamerasrc ! 'video/x-raw,width=1280,height=720' ! \\\n>> + glimagesink\n>> \n>> .. section-end-getting-started\n>> \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EA8B0BD87C\n\tfor ;\n\tWed, 25 Aug 2021 19:46:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 47CA268893;\n\tWed, 25 Aug 2021 21:46:54 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 471CC60288\n\tfor ;\n\tWed, 25 Aug 2021 21:46:52 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C055F24F;\n\tWed, 25 Aug 2021 21:46:51 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"eOSNfBFP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1629920811;\n\tbh=PEpfnl8IYYrKMXwj1Eg5aKaX8OOYfjleDYHSEwSgSCg=;\n\th=From:To:Cc:References:Subject:Date:In-Reply-To:From;\n\tb=eOSNfBFP8qfH8RPcvMXLAHqFSAs/pAojqClbhYIoE8vpuWxk5p/9nPe7wVUtuGKqs\n\t5aLZcZ64K8VW4YrR03CRlbdIV8nTl4zR8mGVpREMVIZneDuCmmqN9wshwiZusZ8NWt\n\tCzXrY53IWt9UDW6I2PSuTwOCFiwx6q7xOOOBQZT0=","From":"Kieran Bingham ","To":"Laurent Pinchart ","References":"<20210825102748.3738346-1-kieran.bingham@ideasonboard.com>\n\t","Message-ID":"<25670749-5435-f720-e157-c139ed07c980@ideasonboard.com>","Date":"Wed, 25 Aug 2021 20:46:48 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.11.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH] README.rst: Update gstreamer element\n\tguidance","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":19066,"web_url":"https://patchwork.libcamera.org/comment/19066/","msgid":"","date":"2021-08-25T19:52:06","subject":"Re: [libcamera-devel] [PATCH] README.rst: Update gstreamer element\n\tguidance","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Wed, Aug 25, 2021 at 08:46:48PM +0100, Kieran Bingham wrote:\n> On 25/08/2021 15:29, Laurent Pinchart wrote:\n> > On Wed, Aug 25, 2021 at 11:27:48AM +0100, Kieran Bingham wrote:\n> >> The Gstreamer gstlibcamerasrc element operates better with the\n> >> glimagesink, as it can perform direct renders or hardware accellerated\n> >> image format conversion.\n> >>\n> >> Further extend the sample commands to demonstrate how to specify a fixed\n> >> width and height parameter to the pipeline.\n> >>\n> >> Signed-off-by: Kieran Bingham \n> >> ---\n> >> README.rst | 19 +++++++++++++++++--\n> >> 1 file changed, 17 insertions(+), 2 deletions(-)\n> >>\n> >> diff --git a/README.rst b/README.rst\n> >> index fcf0f47f14c5..61ba8418a62a 100644\n> >> --- a/README.rst\n> >> +++ b/README.rst\n> >> @@ -94,7 +94,7 @@ Using GStreamer plugin\n> >> ~~~~~~~~~~~~~~~~~~~~~~\n> >> \n> >> To use GStreamer plugin from source tree, set the following environment so that\n> >> -GStreamer can find it.\n> >> +GStreamer can find it, (This can be skipped when libcamera is installed)\n> > \n> > This looks weird. Did you maybe mean\n> > \n> > GStreamer can find it (this can be skipped when libcamera is installed).\n> > \n> > or\n> > \n> > GStreamer can find it (this can be skipped when libcamera is installed):\n> > \n> > ? You could also write\n> > \n> > GStreamer can find it. This isn't necessary when libcamera is installed.\n> \n> I'll take that one.\n> \n> >> \n> >> export GST_PLUGIN_PATH=$(pwd)/build/src/gstreamer\n> >> \n> >> @@ -104,7 +104,22 @@ onto the default video display element on your system.\n> > \n> > The above comment isn't accurate anymore.\n> \n> Will this fix it enough for you ?\n> \n> \"\"\"\n> The following pipeline will stream from the camera named \"Camera 1\"\n> onto the OpenGL accelerated display element on your system.\n> \"\"\"\n\nWorks for me.\n\n> >> .. code::\n> >> \n> >> - gst-launch-1.0 libcamerasrc camera-name=\"Camera 1\" ! videoconvert ! autovideosink\n> >> + gst-launch-1.0 libcamerasrc camera-name=\"Camera 1\" ! glimagesink\n> >> +\n> >> +To show the first camera found you can omit the camera-name property, or you\n> >> +can identify the camera and capabilities using:\n> >> +\n> >> +.. code::\n> >> +\n> >> + gst-device-monitor-1.0 Video\n> >> +\n> >> +This will show the supported stream sizes which can be manually selected if\n> > \n> > s/will/will also/\n> > \n> >> +desired with a pipeline such as:\n> >> +\n> >> +.. code::\n> >> +\n> >> + gst-launch-1.0 libcamerasrc ! 'video/x-raw,width=1280,height=720' ! \\\n> >> + glimagesink\n> >> \n> >> .. section-end-getting-started\n> >>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 21FF6BD87D\n\tfor ;\n\tWed, 25 Aug 2021 19:52:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 78C0468893;\n\tWed, 25 Aug 2021 21:52:20 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DF82A60288\n\tfor ;\n\tWed, 25 Aug 2021 21:52:18 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4E06124F;\n\tWed, 25 Aug 2021 21:52:18 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Kp84Y02M\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1629921138;\n\tbh=5qEc9Jixq1Uu2P6lYHLOzXmrUl9a41Q+llIpUIHd9QM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Kp84Y02M0qlojaLyIaEDUu+GkwjS9g9RdWG7tkJvpfHv5fIUBfw4+6FIM5rtus3j9\n\tC0bctel/xm3jMsy1sq+4BVg1sXIrVdwFWoC33a56Ws83YLhyGfydQEZ4EAbq4o+Zzt\n\tyz/39vX98UaOjqyaXoBPAbs/wODK5CzFRS1jCW8c=","Date":"Wed, 25 Aug 2021 22:52:06 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20210825102748.3738346-1-kieran.bingham@ideasonboard.com>\n\t\n\t<25670749-5435-f720-e157-c139ed07c980@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<25670749-5435-f720-e157-c139ed07c980@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] README.rst: Update gstreamer element\n\tguidance","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]