[{"id":25957,"web_url":"https://patchwork.libcamera.org/comment/25957/","msgid":"","date":"2022-12-01T11:31:37","subject":"Re: [libcamera-devel] [PATCH v8 16/17] lc-compliance: Check that\n\trequests complete successfully","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Tue, Aug 24, 2021 at 04:56:35PM -0300, Nícolas F. R. A. Prado wrote:\n> When a request fails to queue it is completed but with its status set to\n> RequestCancelled. Add a check in the requestComplete callback to make\n> sure that the request was completed successfully.\n> \n> For the SimpleCaptureUnbalanced test we need to do this check only if\n> the capture isn't over yet, otherwise the few extra requests that get\n> cancelled at the end, which is the normal behavior, will make the test\n> fail.\n> \n> Signed-off-by: Nícolas F. R. A. Prado \n\nReviewed-by: Paul Elder \n\n> \n> ---\n> \n> Changes in v8:\n> - Fixed issue in UnbalancedStop test where requests cancelled due to stop() call\n> were failing the test\n> - Fixed formatting\n> \n> Changes in v5:\n> - New\n> \n> src/lc-compliance/simple_capture.cpp | 9 +++++++++\n> 1 file changed, 9 insertions(+)\n> \n> diff --git a/src/lc-compliance/simple_capture.cpp b/src/lc-compliance/simple_capture.cpp\n> index d4805ff3403c..701d0feb70d1 100644\n> --- a/src/lc-compliance/simple_capture.cpp\n> +++ b/src/lc-compliance/simple_capture.cpp\n> @@ -165,6 +165,9 @@ int SimpleCaptureBalanced::queueRequest(Request *request)\n> \n> void SimpleCaptureBalanced::requestComplete(Request *request)\n> {\n> +\tEXPECT_EQ(request->status(), Request::Status::RequestComplete)\n> +\t\t<< \"Request didn't complete successfully\";\n> +\n> \tif (captureCompleted())\n> \t\treturn;\n> \n> @@ -202,6 +205,9 @@ void SimpleCaptureUnbalanced::requestComplete(Request *request)\n> \tif (captureCompleted())\n> \t\treturn;\n> \n> +\tEXPECT_EQ(request->status(), Request::Status::RequestComplete)\n> +\t\t<< \"Request didn't complete successfully\";\n> +\n> \trequest->reuse(Request::ReuseBuffers);\n> \tif (camera_->queueRequest(request))\n> \t\tloop_->exit(-EINVAL);\n> @@ -233,5 +239,8 @@ void SimpleCaptureOverflow::capture()\n> \n> void SimpleCaptureOverflow::requestComplete([[maybe_unused]] Request *request)\n> {\n> +\tEXPECT_EQ(request->status(), Request::Status::RequestComplete)\n> +\t\t<< \"Request didn't complete successfully\";\n> +\n> \tcaptureCompleted();\n> }\n> -- \n> 2.33.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 85A6FBE08B\n\tfor ;\n\tThu, 1 Dec 2022 11:31:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4004D63336;\n\tThu, 1 Dec 2022 12:31:45 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0282B63335\n\tfor ;\n\tThu, 1 Dec 2022 12:31:44 +0100 (CET)","from pyrite.rasen.tech (h175-177-042-159.catv02.itscom.jp\n\t[175.177.42.159])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3CF5033F;\n\tThu, 1 Dec 2022 12:31:41 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1669894305;\n\tbh=8TkFKxupMddslRd1lcW36R7f7c2QPQhc7FEy4LeBU6U=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=BiyEtMYkrSYO8SsQCzVYjtyGGS8IHI1vWLfXmTo14hKsAH2vgF725+8le0MjEpuhA\n\tTxRIZZ9KtiNHljCOO51G2nn7+LW9230ZZywVg+4yM09B8gaHbXxQ4yYqjkX70v1X4Q\n\tXTUNAy8N55I5kDUUQSGM2bo4awjHyizN3Pi7mQpOP+ku4+0Wof9ed02vk9h9wwSZAT\n\tuywUStLi5GthzD98lEDHswI8klV3NtrPDyTkq806Q/i3uQ8lRcsQBVhAxslq5u9Coc\n\tY6mc+a95FKIMXboKjI5rZRpjXbnhrqWHFZp+imtpHqFYnU22qxRMm8O4b/raw1dTr7\n\texGwSip2mBttQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1669894303;\n\tbh=8TkFKxupMddslRd1lcW36R7f7c2QPQhc7FEy4LeBU6U=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=EqSBo6mhva48vi/F8Htv8yxdytZrD1IDuKIfaNkxuOApV2NOwbmhCPsdUkYrwN3qi\n\tiV0EPzHgyTbF+DQpsJed0+CyEDXtFwFEpenSd0wkqvnbaKufHwXk3EglKxzFfmOCID\n\t+b7eC46fsici7MlylhZPY+T9k6ZyXIy9bxUEy47Q="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"EqSBo6mh\"; dkim-atps=neutral","Date":"Thu, 1 Dec 2022 20:31:37 +0900","To":"=?iso-8859-1?q?N=EDcolas_F=2E_R=2E_A=2E?= Prado ","Message-ID":"","References":"<20210824195636.1110845-1-nfraprado@collabora.com>\n\t<20210824195636.1110845-17-nfraprado@collabora.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20210824195636.1110845-17-nfraprado@collabora.com>","Subject":"Re: [libcamera-devel] [PATCH v8 16/17] lc-compliance: Check that\n\trequests complete successfully","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Paul Elder via libcamera-devel ","Reply-To":"Paul Elder ","Cc":"libcamera-devel@lists.libcamera.org, kernel@collabora.com,\n\t=?iso-8859-1?q?Andr=E9?= Almeida ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]