[{"id":19044,"web_url":"https://patchwork.libcamera.org/comment/19044/","msgid":"<20210825092525.mg4quq7exgqwagfe@uno.localdomain>","date":"2021-08-25T09:25:25","subject":"Re: [libcamera-devel] [SimpleCam PATCH 4/4] simple-cam: Correct the\n\tcapitalisation of 'libcamera'","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"On Tue, Aug 24, 2021 at 03:24:50PM +0100, Kieran Bingham wrote:\n> Even when used at the beginning of a sentence, the 'libcamera' name\n> always starts with a lower case 'l'. Fix the incorrect usages of the\n> name.\n>\n> Signed-off-by: Kieran Bingham \n> ---\n> simple-cam.cpp | 7 ++++---\n> 1 file changed, 4 insertions(+), 3 deletions(-)\n>\n> diff --git a/simple-cam.cpp b/simple-cam.cpp\n> index 47c5dc9987bc..7ba423df9089 100644\n> --- a/simple-cam.cpp\n> +++ b/simple-cam.cpp\n> @@ -301,7 +301,7 @@ int main()\n> \t * --------------------------------------------------------------------\n> \t * Frame Capture\n> \t *\n> -\t * Libcamera frames capture model is based on the 'Request' concept.\n> +\t * libcamera frames capture model is based on the 'Request' concept.\n> \t * For each frame a Request has to be queued to the Camera.\n> \t *\n> \t * A Request refers to (at least one) Stream for which a Buffer that\n> @@ -348,7 +348,7 @@ int main()\n> \t * --------------------------------------------------------------------\n> \t * Signal&Slots\n> \t *\n> -\t * Libcamera uses a Signal&Slot based system to connect events to\n> +\t * libcamera uses a Signal&Slot based system to connect events to\n> \t * callback operations meant to handle them, inspired by the QT graphic\n> \t * toolkit.\n> \t *\n> @@ -398,12 +398,13 @@ int main()\n> \tint ret = loop.exec();\n> \tstd::cout << \"Capture ran for \" << TIMEOUT_SEC << \" seconds and \"\n> \t\t << \"stopped with exit status: \" << ret << std::endl;\n> +\n\nUnrelated but ok\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n> \t/*\n> \t * --------------------------------------------------------------------\n> \t * Clean Up\n> \t *\n> \t * Stop the Camera, release resources and stop the CameraManager.\n> -\t * Libcamera has now released all resources it owned.\n> +\t * libcamera has now released all resources it owned.\n> \t */\n> \tcamera->stop();\n> \tallocator->free(stream);\n> --\n> 2.30.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 88D88BD87D\n\tfor ;\n\tWed, 25 Aug 2021 09:24:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4FDF4688A3;\n\tWed, 25 Aug 2021 11:24:38 +0200 (CEST)","from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 59B4560259\n\tfor ;\n\tWed, 25 Aug 2021 11:24:37 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 9FA901C0003;\n\tWed, 25 Aug 2021 09:24:36 +0000 (UTC)"],"Date":"Wed, 25 Aug 2021 11:25:25 +0200","From":"Jacopo Mondi ","To":"Kieran Bingham ","Message-ID":"<20210825092525.mg4quq7exgqwagfe@uno.localdomain>","References":"<20210824142450.3157833-1-kieran.bingham@ideasonboard.com>\n\t<20210824142450.3157833-5-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210824142450.3157833-5-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [SimpleCam PATCH 4/4] simple-cam: Correct the\n\tcapitalisation of 'libcamera'","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":19047,"web_url":"https://patchwork.libcamera.org/comment/19047/","msgid":"","date":"2021-08-25T09:50:10","subject":"Re: [libcamera-devel] [SimpleCam PATCH 4/4] simple-cam: Correct the\n\tcapitalisation of 'libcamera'","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 25/08/2021 10:25, Jacopo Mondi wrote:\n> On Tue, Aug 24, 2021 at 03:24:50PM +0100, Kieran Bingham wrote:\n>> Even when used at the beginning of a sentence, the 'libcamera' name\n>> always starts with a lower case 'l'. Fix the incorrect usages of the\n>> name.\n>>\n>> Signed-off-by: Kieran Bingham \n>> ---\n>> simple-cam.cpp | 7 ++++---\n>> 1 file changed, 4 insertions(+), 3 deletions(-)\n>>\n>> diff --git a/simple-cam.cpp b/simple-cam.cpp\n>> index 47c5dc9987bc..7ba423df9089 100644\n>> --- a/simple-cam.cpp\n>> +++ b/simple-cam.cpp\n>> @@ -301,7 +301,7 @@ int main()\n>> \t * --------------------------------------------------------------------\n>> \t * Frame Capture\n>> \t *\n>> -\t * Libcamera frames capture model is based on the 'Request' concept.\n>> +\t * libcamera frames capture model is based on the 'Request' concept.\n>> \t * For each frame a Request has to be queued to the Camera.\n>> \t *\n>> \t * A Request refers to (at least one) Stream for which a Buffer that\n>> @@ -348,7 +348,7 @@ int main()\n>> \t * --------------------------------------------------------------------\n>> \t * Signal&Slots\n>> \t *\n>> -\t * Libcamera uses a Signal&Slot based system to connect events to\n>> +\t * libcamera uses a Signal&Slot based system to connect events to\n>> \t * callback operations meant to handle them, inspired by the QT graphic\n>> \t * toolkit.\n>> \t *\n>> @@ -398,12 +398,13 @@ int main()\n>> \tint ret = loop.exec();\n>> \tstd::cout << \"Capture ran for \" << TIMEOUT_SEC << \" seconds and \"\n>> \t\t << \"stopped with exit status: \" << ret << std::endl;\n>> +\n> \n> Unrelated but ok\n\nIndeed, that slipped in ;-)\n\nBut I'll keep it - and add, \"While here, fix the spacing between code\nblocks.\"\n\n> Reviewed-by: Jacopo Mondi \n> \n> Thanks\n> j\n>> \t/*\n>> \t * --------------------------------------------------------------------\n>> \t * Clean Up\n>> \t *\n>> \t * Stop the Camera, release resources and stop the CameraManager.\n>> -\t * Libcamera has now released all resources it owned.\n>> +\t * libcamera has now released all resources it owned.\n>> \t */\n>> \tcamera->stop();\n>> \tallocator->free(stream);\n>> --\n>> 2.30.2\n>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4E93DBD87C\n\tfor ;\n\tWed, 25 Aug 2021 09:50:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 757FD688A3;\n\tWed, 25 Aug 2021 11:50:15 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E256860259\n\tfor ;\n\tWed, 25 Aug 2021 11:50:13 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6794624F;\n\tWed, 25 Aug 2021 11:50:13 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"KxV4ITY/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1629885013;\n\tbh=9Bj+Nzq07GjHuhfeE4STsFSq1y4vkWg/AV50yxu/cw0=;\n\th=From:Subject:To:Cc:References:Date:In-Reply-To:From;\n\tb=KxV4ITY/3gp4EVRTSpjKdlYrHM+YumyCJh5nQlgYCj6SB4p3z+lSjXIOrulXEqFSB\n\tqNYCMP+kbVWmY9ggnFjdVXzFv3JnYAJPwwhTDu3mL6ZkXmUXTyFHRmKvUnrcZ1YYQm\n\twwSY0QQstoaE+ZZc2YPWEYzm2yNVefJoYtpYK8lw=","From":"Kieran Bingham ","To":"Jacopo Mondi ","References":"<20210824142450.3157833-1-kieran.bingham@ideasonboard.com>\n\t<20210824142450.3157833-5-kieran.bingham@ideasonboard.com>\n\t<20210825092525.mg4quq7exgqwagfe@uno.localdomain>","Message-ID":"","Date":"Wed, 25 Aug 2021 10:50:10 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.11.0","MIME-Version":"1.0","In-Reply-To":"<20210825092525.mg4quq7exgqwagfe@uno.localdomain>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [SimpleCam PATCH 4/4] simple-cam: Correct the\n\tcapitalisation of 'libcamera'","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":19070,"web_url":"https://patchwork.libcamera.org/comment/19070/","msgid":"","date":"2021-08-25T20:01:19","subject":"Re: [libcamera-devel] [SimpleCam PATCH 4/4] simple-cam: Correct the\n\tcapitalisation of 'libcamera'","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Tue, Aug 24, 2021 at 03:24:50PM +0100, Kieran Bingham wrote:\n> Even when used at the beginning of a sentence, the 'libcamera' name\n> always starts with a lower case 'l'. Fix the incorrect usages of the\n> name.\n> \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> simple-cam.cpp | 7 ++++---\n> 1 file changed, 4 insertions(+), 3 deletions(-)\n> \n> diff --git a/simple-cam.cpp b/simple-cam.cpp\n> index 47c5dc9987bc..7ba423df9089 100644\n> --- a/simple-cam.cpp\n> +++ b/simple-cam.cpp\n> @@ -301,7 +301,7 @@ int main()\n> \t * --------------------------------------------------------------------\n> \t * Frame Capture\n> \t *\n> -\t * Libcamera frames capture model is based on the 'Request' concept.\n> +\t * libcamera frames capture model is based on the 'Request' concept.\n> \t * For each frame a Request has to be queued to the Camera.\n> \t *\n> \t * A Request refers to (at least one) Stream for which a Buffer that\n> @@ -348,7 +348,7 @@ int main()\n> \t * --------------------------------------------------------------------\n> \t * Signal&Slots\n> \t *\n> -\t * Libcamera uses a Signal&Slot based system to connect events to\n> +\t * libcamera uses a Signal&Slot based system to connect events to\n> \t * callback operations meant to handle them, inspired by the QT graphic\n> \t * toolkit.\n> \t *\n> @@ -398,12 +398,13 @@ int main()\n> \tint ret = loop.exec();\n> \tstd::cout << \"Capture ran for \" << TIMEOUT_SEC << \" seconds and \"\n> \t\t << \"stopped with exit status: \" << ret << std::endl;\n> +\n> \t/*\n> \t * --------------------------------------------------------------------\n> \t * Clean Up\n> \t *\n> \t * Stop the Camera, release resources and stop the CameraManager.\n> -\t * Libcamera has now released all resources it owned.\n> +\t * libcamera has now released all resources it owned.\n> \t */\n> \tcamera->stop();\n> \tallocator->free(stream);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 34319BD87D\n\tfor ;\n\tWed, 25 Aug 2021 20:01:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A962C68891;\n\tWed, 25 Aug 2021 22:01:33 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B6ED360288\n\tfor ;\n\tWed, 25 Aug 2021 22:01:31 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3F6D324F;\n\tWed, 25 Aug 2021 22:01:31 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hu2zl0Nj\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1629921691;\n\tbh=CqsAsgKve9ofLt01FmYzHG8SbPUZQ0elmxTuEd5EOdw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=hu2zl0NjNprvjnGjZPAsFUExvl9CoCLL385P9D4KSCdoySwk6KW6kKsmErYrEQ345\n\tijSNGrxm7FbuRmyfejaGwdmAEn6HSsuD86HIhPF/XZjrgGAAWb1LxWY4OcgIH+Uya7\n\tuDZ5G2QKqAQtJz8tXSdbBIBWurU0kMmCiKexcTLc=","Date":"Wed, 25 Aug 2021 23:01:19 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20210824142450.3157833-1-kieran.bingham@ideasonboard.com>\n\t<20210824142450.3157833-5-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210824142450.3157833-5-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [SimpleCam PATCH 4/4] simple-cam: Correct the\n\tcapitalisation of 'libcamera'","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]