[{"id":19043,"web_url":"https://patchwork.libcamera.org/comment/19043/","msgid":"<20210825092440.ly4oiehfqkvxhoey@uno.localdomain>","date":"2021-08-25T09:24:40","subject":"Re: [libcamera-devel] [SimpleCam PATCH 2/4] simple-cam: Improve\n\tdocumentation of validate/configure","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"On Tue, Aug 24, 2021 at 03:24:48PM +0100, Kieran Bingham wrote:\n> The validation and configure phase has a couple of grammatical errors.\n> Fix them and reflow the text accordingly.\n>\n> Signed-off-by: Kieran Bingham \n> ---\n> simple-cam.cpp | 9 +++++----\n> 1 file changed, 5 insertions(+), 4 deletions(-)\n>\n> diff --git a/simple-cam.cpp b/simple-cam.cpp\n> index 5c16db67700c..2e646a5485c9 100644\n> --- a/simple-cam.cpp\n> +++ b/simple-cam.cpp\n> @@ -255,16 +255,17 @@ int main()\n> #endif\n>\n> \t/*\n> -\t * Validating a CameraConfiguration -before- applying it adjust it\n> -\t * to a valid configuration as closest as possible to the requested one.\n> +\t * Validating a CameraConfiguration -before- applying it will adjust it\n> +\t * to a valid configuration which is as close as possible to the one\n> +\t * requested.\n\nI feel a bit silly for arguing about English language with you but\nin my mind this sounds better as \"to the requested one\" ?\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n\n> \t */\n> \tconfig->validate();\n> \tstd::cout << \"Validated viewfinder configuration is: \"\n> \t\t << streamConfig.toString() << std::endl;\n>\n> \t/*\n> -\t * Once we have a validate configuration, we can apply it\n> -\t * to the Camera.\n> +\t * Once we have a validated configuration, we can apply it to the\n> +\t * Camera.\n> \t */\n> \tcamera->configure(config.get());\n>\n> --\n> 2.30.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A4541BD87D\n\tfor ;\n\tWed, 25 Aug 2021 09:23:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1FE7D688A3;\n\tWed, 25 Aug 2021 11:23:54 +0200 (CEST)","from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D239060259\n\tfor ;\n\tWed, 25 Aug 2021 11:23:52 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 19DEDC0012;\n\tWed, 25 Aug 2021 09:23:51 +0000 (UTC)"],"Date":"Wed, 25 Aug 2021 11:24:40 +0200","From":"Jacopo Mondi ","To":"Kieran Bingham ","Message-ID":"<20210825092440.ly4oiehfqkvxhoey@uno.localdomain>","References":"<20210824142450.3157833-1-kieran.bingham@ideasonboard.com>\n\t<20210824142450.3157833-3-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210824142450.3157833-3-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [SimpleCam PATCH 2/4] simple-cam: Improve\n\tdocumentation of validate/configure","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":19069,"web_url":"https://patchwork.libcamera.org/comment/19069/","msgid":"","date":"2021-08-25T19:59:35","subject":"Re: [libcamera-devel] [SimpleCam PATCH 2/4] simple-cam: Improve\n\tdocumentation of validate/configure","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Tue, Aug 24, 2021 at 03:24:48PM +0100, Kieran Bingham wrote:\n> The validation and configure phase has a couple of grammatical errors.\n> Fix them and reflow the text accordingly.\n> \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> simple-cam.cpp | 9 +++++----\n> 1 file changed, 5 insertions(+), 4 deletions(-)\n> \n> diff --git a/simple-cam.cpp b/simple-cam.cpp\n> index 5c16db67700c..2e646a5485c9 100644\n> --- a/simple-cam.cpp\n> +++ b/simple-cam.cpp\n> @@ -255,16 +255,17 @@ int main()\n> #endif\n> \n> \t/*\n> -\t * Validating a CameraConfiguration -before- applying it adjust it\n> -\t * to a valid configuration as closest as possible to the requested one.\n> +\t * Validating a CameraConfiguration -before- applying it will adjust it\n> +\t * to a valid configuration which is as close as possible to the one\n> +\t * requested.\n> \t */\n> \tconfig->validate();\n> \tstd::cout << \"Validated viewfinder configuration is: \"\n> \t\t << streamConfig.toString() << std::endl;\n> \n> \t/*\n> -\t * Once we have a validate configuration, we can apply it\n> -\t * to the Camera.\n> +\t * Once we have a validated configuration, we can apply it to the\n> +\t * Camera.\n> \t */\n> \tcamera->configure(config.get());\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 667A7BD87C\n\tfor ;\n\tWed, 25 Aug 2021 19:59:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2331E68893;\n\tWed, 25 Aug 2021 21:59:49 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 868D960288\n\tfor ;\n\tWed, 25 Aug 2021 21:59:47 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1FD9E24F;\n\tWed, 25 Aug 2021 21:59:47 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"TID5UT6I\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1629921587;\n\tbh=FbgLSsM8Fhh7ds1STW6aAij/1PZx2NOPeB8PcbIkty8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=TID5UT6I6wsPagsuQDfaPUPxpkBzbXAmrSvo/wCgCxn73oPKQdlQFhCsk55yoL5J4\n\tEjE2ZBRfpQD2x0TUnhsCZxjFNWZdnEsYAgkaV1RM4WqqbJ/XtIFQnr/Yyp1OXl5+GO\n\tX/7k6PUKp2LZsri4CdIt1K2JP35BYsjAFrzoz8LM=","Date":"Wed, 25 Aug 2021 22:59:35 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20210824142450.3157833-1-kieran.bingham@ideasonboard.com>\n\t<20210824142450.3157833-3-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210824142450.3157833-3-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [SimpleCam PATCH 2/4] simple-cam: Improve\n\tdocumentation of validate/configure","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":19079,"web_url":"https://patchwork.libcamera.org/comment/19079/","msgid":"<58162e0e-4dd3-d94b-a807-f4f78a693efb@ideasonboard.com>","date":"2021-08-25T21:07:39","subject":"Re: [libcamera-devel] [SimpleCam PATCH 2/4] simple-cam: Improve\n\tdocumentation of validate/configure","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 25/08/2021 10:24, Jacopo Mondi wrote:\n> On Tue, Aug 24, 2021 at 03:24:48PM +0100, Kieran Bingham wrote:\n>> The validation and configure phase has a couple of grammatical errors.\n>> Fix them and reflow the text accordingly.\n>>\n>> Signed-off-by: Kieran Bingham \n>> ---\n>> simple-cam.cpp | 9 +++++----\n>> 1 file changed, 5 insertions(+), 4 deletions(-)\n>>\n>> diff --git a/simple-cam.cpp b/simple-cam.cpp\n>> index 5c16db67700c..2e646a5485c9 100644\n>> --- a/simple-cam.cpp\n>> +++ b/simple-cam.cpp\n>> @@ -255,16 +255,17 @@ int main()\n>> #endif\n>>\n>> \t/*\n>> -\t * Validating a CameraConfiguration -before- applying it adjust it\n>> -\t * to a valid configuration as closest as possible to the requested one.\n>> +\t * Validating a CameraConfiguration -before- applying it will adjust it\n>> +\t * to a valid configuration which is as close as possible to the one\n>> +\t * requested.\n> \n> I feel a bit silly for arguing about English language with you but\n> in my mind this sounds better as \"to the requested one\" ?\n\nNot knowing the names of the grammar rules involved here, I don't know\n/why/ I believe my version is correct, but I do ;-)\n\nMy single \"right/wrong\" signal in my head tells me my version is right.\n\nI've asked Keri if she knows the rules to describe the word ordering\nhere. She's better at languages than me ;-)\n\n\nOk, so we came up with the fact that it's related to being a\npronoun/verb combination (or is it an adverb?), and really it's a\nshortened sentence. The full sentence would have been expected to be:\n\n\"\"\"\nto a valid configuration which is as close as possible to the one (that\nhas been) requested.\n\"\"\"\n\nWhich is why it can't be:\n\"\"\"\nto a valid configuration which is as close as possible to the requested\none (..that has been...).\n\"\"\"\n\n\n> Reviewed-by: Jacopo Mondi \n\nThanks, collected and merged this series.\n\n> \n> Thanks\n> j\n> \n> \n>> \t */\n>> \tconfig->validate();\n>> \tstd::cout << \"Validated viewfinder configuration is: \"\n>> \t\t << streamConfig.toString() << std::endl;\n>>\n>> \t/*\n>> -\t * Once we have a validate configuration, we can apply it\n>> -\t * to the Camera.\n>> +\t * Once we have a validated configuration, we can apply it to the\n>> +\t * Camera.\n>> \t */\n>> \tcamera->configure(config.get());\n>>\n>> --\n>> 2.30.2\n>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 676F4BD87C\n\tfor ;\n\tWed, 25 Aug 2021 21:07:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DC08F68893;\n\tWed, 25 Aug 2021 23:07:44 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 093BE60288\n\tfor ;\n\tWed, 25 Aug 2021 23:07:43 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7D3AE24F;\n\tWed, 25 Aug 2021 23:07:42 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"cmVoKl56\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1629925662;\n\tbh=M3LNO+CWVcGSCYg9gGpFr0FNQcY2VOL2nIlmG3LDDmc=;\n\th=From:To:Cc:References:Subject:Date:In-Reply-To:From;\n\tb=cmVoKl560Cfo67LAm4iiYbwytPfSRHQRfM2D611Py/nI96G8Y/9CzTXRTDdirO7Yk\n\tu/TSfisRvVctD4KyPLUxpK26uZI12cubnYNnpxtXX0VHbOxq/rzUJZOs2v8tfB5xLL\n\tuuH8pidR0QGHo0uvNUv7HTEPSD6dHRDd4eCKk3ko=","From":"Kieran Bingham ","To":"Jacopo Mondi ","References":"<20210824142450.3157833-1-kieran.bingham@ideasonboard.com>\n\t<20210824142450.3157833-3-kieran.bingham@ideasonboard.com>\n\t<20210825092440.ly4oiehfqkvxhoey@uno.localdomain>","Message-ID":"<58162e0e-4dd3-d94b-a807-f4f78a693efb@ideasonboard.com>","Date":"Wed, 25 Aug 2021 22:07:39 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.11.0","MIME-Version":"1.0","In-Reply-To":"<20210825092440.ly4oiehfqkvxhoey@uno.localdomain>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [SimpleCam PATCH 2/4] simple-cam: Improve\n\tdocumentation of validate/configure","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]