{"id":1346,"url":"https://patchwork.libcamera.org/api/patches/1346/?format=json","web_url":"https://patchwork.libcamera.org/patch/1346/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190603231637.28554-10-paul.elder@ideasonboard.com>","date":"2019-06-03T23:16:36","name":"[libcamera-devel,v2,09/10] libcamera: pipeline: store IPA in pipeline data","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"f31ae224842119f5db1a97386e6f2ee94202e862","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/1346/mbox/","series":[{"id":335,"url":"https://patchwork.libcamera.org/api/series/335/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=335","date":"2019-06-03T23:16:27","name":"Add IPAManager and IPAInterface","version":2,"mbox":"https://patchwork.libcamera.org/series/335/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/1346/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/1346/checks/","tags":{},"headers":{"Return-Path":"<paul.elder@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 76409618FB\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue,  4 Jun 2019 01:16:53 +0200 (CEST)","from localhost.localdomain (unknown [96.44.9.117])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D0034587;\n\tTue,  4 Jun 2019 01:16:52 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1559603813;\n\tbh=uwq8QHYM17uy7O0OTiCqblzmomjoyJW7xhYEZ5F3ezs=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=QD4DDAzAS/4C5EPGKp1W6YJeEbxdY/1AVNgdKpv/2oei5ZQmH800c3WJCaGz4+BTb\n\t6p99nX2dKG+y+nUQWUM+fY6CCzrNxagZD3igh0lsrGHLvLrYD+zVnGRrhKQ5XSbsM8\n\tCGJsWDSE40AQUb6Of1GTWpdYmQWj54UQHzxzwnik=","From":"Paul Elder <paul.elder@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Date":"Mon,  3 Jun 2019 19:16:36 -0400","Message-Id":"<20190603231637.28554-10-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20190603231637.28554-1-paul.elder@ideasonboard.com>","References":"<20190603231637.28554-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 09/10] libcamera: pipeline: store IPA\n\tin pipeline data","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Mon, 03 Jun 2019 23:16:53 -0000"},"content":"After the pipeline handler acquires an IPA, it should save it for future\nuse. Store it in the pipeline data.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n---\nNew patch\n\n src/libcamera/include/pipeline_handler.h | 3 +++\n src/libcamera/pipeline_handler.cpp       | 8 ++++++++\n 2 files changed, 11 insertions(+)","diff":"diff --git a/src/libcamera/include/pipeline_handler.h b/src/libcamera/include/pipeline_handler.h\nindex 67971b3..a2d9624 100644\n--- a/src/libcamera/include/pipeline_handler.h\n+++ b/src/libcamera/include/pipeline_handler.h\n@@ -14,6 +14,7 @@\n #include <string>\n #include <vector>\n \n+#include <libcamera/ipa_interface.h>\n #include <libcamera/stream.h>\n \n namespace libcamera {\n@@ -93,6 +94,8 @@ protected:\n \tconst char *name_;\n \tuint32_t version_;\n \n+\tstd::unique_ptr<IPAInterface> ipa_;\n+\n private:\n \tvoid mediaDeviceDisconnected(MediaDevice *media);\n \tvirtual void disconnect();\ndiff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\nindex b18f14d..d6e68b0 100644\n--- a/src/libcamera/pipeline_handler.cpp\n+++ b/src/libcamera/pipeline_handler.cpp\n@@ -530,6 +530,14 @@ CameraData *PipelineHandler::cameraData(const Camera *camera)\n  * \\brief Pipeline handler version\n  */\n \n+/**\n+ * \\var PipelineHandler::ipa_\n+ * \\brief The IPA that the pipeline handler will use\n+ *\n+ * The pipeline handler can acquire an IPA from the IPAManager. Once it is\n+ * acquired, it will be stored here.\n+ */\n+\n /**\n  * \\class PipelineHandlerFactory\n  * \\brief Registration of PipelineHandler classes and creation of instances\n","prefixes":["libcamera-devel","v2","09/10"]}