[{"id":1758,"web_url":"https://patchwork.libcamera.org/comment/1758/","msgid":"<20190604115947.GL4771@pendragon.ideasonboard.com>","date":"2019-06-04T11:59:47","subject":"Re: [libcamera-devel] [PATCH v2 08/10] libcamera: test: remove test\n\tIPA and use dummy IPA instead","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Mon, Jun 03, 2019 at 07:16:35PM -0400, Paul Elder wrote:\n> Use the dummy IPA for testing/sample IPA instead of the earlier test\n> IPA. Remove the test IPA, and update tests and meson accordingly.\n> \n> Signed-off-by: Paul Elder \n> Reviewed-by: Laurent Pinchart \n> ---\n> Changes in v2:\n> - use macros for defining the fields in the expected IPA module info\n> \n> test/ipa/ipa_test.cpp | 8 ++++----\n> test/ipa/meson.build | 10 ----------\n> test/libtest/test.cpp | 2 +-\n> 3 files changed, 5 insertions(+), 15 deletions(-)\n> \n> diff --git a/test/ipa/ipa_test.cpp b/test/ipa/ipa_test.cpp\n> index d7b18c7..f401e29 100644\n> --- a/test/ipa/ipa_test.cpp\n> +++ b/test/ipa/ipa_test.cpp\n> @@ -59,12 +59,12 @@ protected:\n> \n> \t\tconst struct IPAModuleInfo testInfo = {\n> \t\t\tIPA_MODULE_API_VERSION,\n> -\t\t\tPIPELINE_VERSION(0, 9001),\n> -\t\t\t\"bleep\",\n> -\t\t\t\"It's over nine thousand!\",\n> +\t\t\tPIPELINE_VERSION(0, 1),\n> +\t\t\t\"PipelineHandlerVimc\",\n> +\t\t\t\"Dummy IPA for Vimc\",\n> \t\t};\n> \n> -\t\tcount += runTest(\"test/ipa/ipa-dummy-cpp.so\", testInfo);\n> +\t\tcount += runTest(\"src/ipa/ipa_dummy.so\", testInfo);\n> \n> \t\tif (count < 0)\n> \t\t\treturn TestFail;\n> diff --git a/test/ipa/meson.build b/test/ipa/meson.build\n> index 08ee95c..bca39fa 100644\n> --- a/test/ipa/meson.build\n> +++ b/test/ipa/meson.build\n> @@ -1,13 +1,3 @@\n> -ipa_modules_sources = [\n> - ['ipa-dummy-cpp', 'shared_test.cpp'],\n\nYou should also remove shared_test.cpp.\n\n> -]\n> -\n> -foreach m : ipa_modules_sources\n> - shared_library(m, name_prefix : '',\n> - dependencies : libcamera_dep,\n> - include_directories : test_includes_public)\n> -endforeach\n> -\n> ipa_test = [\n> ['ipa_test', 'ipa_test.cpp'],\n> ]\n> diff --git a/test/libtest/test.cpp b/test/libtest/test.cpp\n> index 451c111..a0c5102 100644\n> --- a/test/libtest/test.cpp\n> +++ b/test/libtest/test.cpp\n> @@ -21,7 +21,7 @@ int Test::execute()\n> {\n> \tint ret;\n> \n> -\tret = setenv(\"IPA_MODULE_PATH\", \"test/ipa\", 1);\n> +\tret = setenv(\"IPA_MODULE_PATH\", \"src/ipa\", 1);\n> \tif (ret)\n> \t\treturn errno;\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1E60F630DF\n\tfor ;\n\tTue, 4 Jun 2019 14:00:01 +0200 (CEST)","from pendragon.ideasonboard.com (unknown\n\t[IPv6:2a02:2788:668:163:5bb7:9f6c:564c:d55e])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9F5332D2;\n\tTue, 4 Jun 2019 14:00:00 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1559649600;\n\tbh=zcF5uO6+44hSQr2qivteA9qu1foLlCdzDsXJG1GiX2U=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=vGpC0YA9EDv7pEb1Ap1k1t+mqtC2JrqDM8vdnTPIUDh6PEiPTGgtMKBi6KbK3tMwU\n\tyZcHugpJdgh1J3rNkDMVRt40bBrWUAvciN582+/dsgPpPAUEvX6X//g12aH/he4p+a\n\t79RkWS2SkdMq4Z0YYqEom8o+biMP09O9LFM8ZjHY=","Date":"Tue, 4 Jun 2019 14:59:47 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190604115947.GL4771@pendragon.ideasonboard.com>","References":"<20190603231637.28554-1-paul.elder@ideasonboard.com>\n\t<20190603231637.28554-9-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190603231637.28554-9-paul.elder@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v2 08/10] libcamera: test: remove test\n\tIPA and use dummy IPA instead","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 04 Jun 2019 12:00:01 -0000"}}]