{"id":13445,"url":"https://patchwork.libcamera.org/api/patches/13445/?format=json","web_url":"https://patchwork.libcamera.org/patch/13445/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210823131221.1034059-3-hiroh@chromium.org>","date":"2021-08-23T13:12:13","name":"[libcamera-devel,RFC,v2,02/10] libcamera: ipa_data_serializer: Modify (de)serialization for offset","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"43a49f74b4c743cd3d5707b155d6855ee2a20417","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/?format=json","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/13445/mbox/","series":[{"id":2386,"url":"https://patchwork.libcamera.org/api/series/2386/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2386","date":"2021-08-23T13:12:11","name":"Add offset to FrameBuffer::Plane","version":2,"mbox":"https://patchwork.libcamera.org/series/2386/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/13445/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/13445/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BB9A1BD87C\n\tfor ;\n\tMon, 23 Aug 2021 13:12:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 79D10688E5;\n\tMon, 23 Aug 2021 15:12:39 +0200 (CEST)","from mail-pg1-x52f.google.com (mail-pg1-x52f.google.com\n\t[IPv6:2607:f8b0:4864:20::52f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 38C3268892\n\tfor ;\n\tMon, 23 Aug 2021 15:12:37 +0200 (CEST)","by mail-pg1-x52f.google.com with SMTP id e7so16617252pgk.2\n\tfor ;\n\tMon, 23 Aug 2021 06:12:37 -0700 (PDT)","from hiroh2.tok.corp.google.com\n\t([2401:fa00:8f:203:184e:5d20:8fcb:dfcd])\n\tby smtp.gmail.com with ESMTPSA id\n\tj4sm18596891pgi.6.2021.08.23.06.12.33\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 23 Aug 2021 06:12:35 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"RASyjUv1\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=dA3NswfHOdIMk4OjM0SyDPL0RUS/V4KcyBeK+nmoKVg=;\n\tb=RASyjUv1jP3B3By56raG7xNoz7ieeMvSfA/PctIqaaI93BMfBqmi0s6Xp/s2nVdtmI\n\t65xcf1V9P5bONudQY0NnPGdG2Dc/fmNYdBeoqo5++YtyA+0SLkF7ldlQ9m8gjL8vNZYf\n\tTUOjvtWLtLNV8+Bty+dJlsM09NSkOYUtLILeE=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=dA3NswfHOdIMk4OjM0SyDPL0RUS/V4KcyBeK+nmoKVg=;\n\tb=hkj2Yjx/52rgDXMHZPq1ecEsbGLvp+63cNU4c0PQsUYPJkBoP9PysnbesehH38HoMD\n\t0UBCNEpOIFdmZD5YaiCvk7kaBofM8KA5/BlkTa5ZJGm7eRWzk3C6ydpaqC+hs61fO9W/\n\tZkpj+EEnGspOXejRQa+IF3wXv8T6HDPwYcC6D9AFB6/Y4YrEGj3EbG7TLeOCqmLqTSFH\n\tdA5gTrLpBpnke9vFGtiVZjMJuPwv8lcBkGVuhYsxuDi6BWwkhX4TqTlLuTZV85u2PWVo\n\tCxFydcDAomv0NLMV2cU4YIEhEcdw2BMml3Ws745ZobmINmMtp+ZLO1P1E6VlcAqI9iJL\n\tyKgg==","X-Gm-Message-State":"AOAM531jYBotx3UH9giqx9zCBy4CuPoSTeJX07jE3716rGX1ByXZz2qy\n\tIWxNVT6GRpY9iwCO+0kI1afYAG4agT/s5w==","X-Google-Smtp-Source":"ABdhPJx6DVyRE2wSoZxr5tyIs9/nC2E4Dj1U7o1d3K3efLxmXTgyWTtcTDq/xQrrJPwbzkrVziDECw==","X-Received":"by 2002:a62:1b92:0:b0:3eb:3f92:724 with SMTP id\n\tb140-20020a621b92000000b003eb3f920724mr2026550pfb.3.1629724355547; \n\tMon, 23 Aug 2021 06:12:35 -0700 (PDT)","From":"Hirokazu Honda ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 23 Aug 2021 22:12:13 +0900","Message-Id":"<20210823131221.1034059-3-hiroh@chromium.org>","X-Mailer":"git-send-email 2.33.0.rc2.250.ged5fa647cd-goog","In-Reply-To":"<20210823131221.1034059-1-hiroh@chromium.org>","References":"<20210823131221.1034059-1-hiroh@chromium.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [RFC PATCH v2 02/10] libcamera:\n\tipa_data_serializer: Modify (de)serialization for offset","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The offset variable is added to FrameBuffer::Plane. This modifies\nthe serialization and deserialization code for the offset variable.\n\nSigned-off-by: Hirokazu Honda \n---\n src/libcamera/ipa_data_serializer.cpp | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/ipa_data_serializer.cpp b/src/libcamera/ipa_data_serializer.cpp\nindex 5b183c70..8d1ae4d2 100644\n--- a/src/libcamera/ipa_data_serializer.cpp\n+++ b/src/libcamera/ipa_data_serializer.cpp\n@@ -569,6 +569,7 @@ FileDescriptor IPADataSerializer::deserialize(const std::vector<\n * FrameBuffer::Plane is serialized as:\n *\n * 4 byte - FileDescriptor\n+ * 4 bytes - uint32_t Offset\n * 4 bytes - uint32_t Length\n */\n template<>\n@@ -586,6 +587,7 @@ IPADataSerializer::serialize(const FrameBuffer::Plane &data,\n \tdataVec.insert(dataVec.end(), fdBuf.begin(), fdBuf.end());\n \tfdsVec.insert(fdsVec.end(), fdFds.begin(), fdFds.end());\n \n+\tappendPOD(dataVec, data.offset);\n \tappendPOD(dataVec, data.length);\n \n \treturn { dataVec, fdsVec };\n@@ -603,7 +605,8 @@ IPADataSerializer::deserialize(std::vector::const_i\n \n \tret.fd = IPADataSerializer::deserialize(dataBegin, dataBegin + 4,\n \t\t\t\t\t\t\t\tfdsBegin, fdsBegin + 1);\n-\tret.length = readPOD(dataBegin, 4, dataEnd);\n+\tret.offset = readPOD(dataBegin, 1, dataEnd);\n+\tret.length = readPOD(dataBegin, 5, dataEnd);\n \n \treturn ret;\n }\n","prefixes":["libcamera-devel","RFC","v2","02/10"]}