{"id":13438,"url":"https://patchwork.libcamera.org/api/patches/13438/?format=json","web_url":"https://patchwork.libcamera.org/patch/13438/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210823124937.253539-4-jeanmichel.hautbois@ideasonboard.com>","date":"2021-08-23T12:49:33","name":"[libcamera-devel,v1,3/7] ipa: ipu3: awb: Correct the gain multipliers","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"91a567653f479a783ea50a4358dab20023649508","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/13438/mbox/","series":[{"id":2385,"url":"https://patchwork.libcamera.org/api/series/2385/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2385","date":"2021-08-23T12:49:30","name":"IPU3: AWB and AGC improvements","version":1,"mbox":"https://patchwork.libcamera.org/series/2385/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/13438/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/13438/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D204EC3241\n\tfor ;\n\tMon, 23 Aug 2021 12:49:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B06FF688E5;\n\tMon, 23 Aug 2021 14:49:45 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4003E688A5\n\tfor ;\n\tMon, 23 Aug 2021 14:49:43 +0200 (CEST)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:b920:776:a08c:1d1f])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E76032A5;\n\tMon, 23 Aug 2021 14:49:42 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"JiTSZXiO\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1629722983;\n\tbh=gqjBD44EQGMxs4ueVeR9c84sLsZma5VM+oPubRRlHq4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=JiTSZXiOSAiPBAYez+or4yntsdx0NYvnHQSgKJwb9NmjBVCEAXFr4337Nw/j3vu3o\n\tA3CbRURLSdHNmC4e87TD735ADviE9p6b9J/fcxCi9beI81QIq4LNUR1MA1W0gxeM4S\n\tvs81dUqZ8wchN1pJWuwjSFYUs4rKgiBq/PsNj8iM=","From":"Jean-Michel Hautbois ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 23 Aug 2021 14:49:33 +0200","Message-Id":"<20210823124937.253539-4-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.30.2","In-Reply-To":"<20210823124937.253539-1-jeanmichel.hautbois@ideasonboard.com>","References":"<20210823124937.253539-1-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v1 3/7] ipa: ipu3: awb: Correct the gain\n\tmultipliers","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The gains have a precision u3.13, range [0, 8) which means that a gain\nmultiplier value of 1.0 is represented as a multiplication by 8192 in\nthe ImgU. Correct the gains as this was misunderstood in the first\nplace.\n\nSigned-off-by: Jean-Michel Hautbois \n---\n src/ipa/ipu3/algorithms/awb.cpp | 11 +++++------\n 1 file changed, 5 insertions(+), 6 deletions(-)","diff":"diff --git a/src/ipa/ipu3/algorithms/awb.cpp b/src/ipa/ipu3/algorithms/awb.cpp\nindex 9497a21b..60a5fc52 100644\n--- a/src/ipa/ipu3/algorithms/awb.cpp\n+++ b/src/ipa/ipu3/algorithms/awb.cpp\n@@ -329,13 +329,12 @@ void Awb::prepare(IPAContext &context, ipu3_uapi_params *params)\n \t\t\t\t\t\t\t* params->acc_param.bnr.opt_center.y_reset;\n \t/*\n \t * Green gains should not be touched and considered 1.\n-\t * Default is 16, so do not change it at all.\n-\t * 4096 is the value for a gain of 1.0\n+\t * 8192 is the multiplier for a gain of 1.0\n \t */\n-\tparams->acc_param.bnr.wb_gains.gr = 16 * context.frameContext.awb.gains.green;\n-\tparams->acc_param.bnr.wb_gains.r = 4096 * context.frameContext.awb.gains.red;\n-\tparams->acc_param.bnr.wb_gains.b = 4096 * context.frameContext.awb.gains.blue;\n-\tparams->acc_param.bnr.wb_gains.gb = 16 * context.frameContext.awb.gains.green;\n+\tparams->acc_param.bnr.wb_gains.gr = 8192 * context.frameContext.awb.gains.green;\n+\tparams->acc_param.bnr.wb_gains.r = 8192 * context.frameContext.awb.gains.red;\n+\tparams->acc_param.bnr.wb_gains.b = 8192 * context.frameContext.awb.gains.blue;\n+\tparams->acc_param.bnr.wb_gains.gb = 8192 * context.frameContext.awb.gains.green;\n \n \tLOG(IPU3Awb, Debug) << \"Color temperature estimated: \" << asyncResults_.temperatureK;\n \n","prefixes":["libcamera-devel","v1","3/7"]}