{"id":13430,"url":"https://patchwork.libcamera.org/api/patches/13430/?format=json","web_url":"https://patchwork.libcamera.org/patch/13430/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210823103258.1583287-1-paul.elder@ideasonboard.com>","date":"2021-08-23T10:32:58","name":"[libcamera-devel] android: Check exposure time range for manual sensor capability","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":false,"hash":"8e494c3d33820ad20b70e63952dc9aba43ef0d5e","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":{"id":17,"url":"https://patchwork.libcamera.org/api/users/17/?format=json","username":"epaul","first_name":"Paul","last_name":"Elder","email":"paul.elder@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/13430/mbox/","series":[{"id":2383,"url":"https://patchwork.libcamera.org/api/series/2383/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2383","date":"2021-08-23T10:32:58","name":"[libcamera-devel] android: Check exposure time range for manual sensor capability","version":1,"mbox":"https://patchwork.libcamera.org/series/2383/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/13430/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/13430/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2AAE8BD87D\n\tfor ;\n\tMon, 23 Aug 2021 10:33:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 94BF26025B;\n\tMon, 23 Aug 2021 12:33:12 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 545546025B\n\tfor ;\n\tMon, 23 Aug 2021 12:33:11 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E81922A5;\n\tMon, 23 Aug 2021 12:33:09 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"acwRLOUk\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1629714791;\n\tbh=pR+kH8zGSuwHZr3+ytOomLdV/zzpCbPJ5gjc+94BHss=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=acwRLOUkU7FtMgetc+wiRgR3QlilHnAIFx4yf6fxtdLhlBt4D7zEIznRTR7B3xRfB\n\tWwd17EAbi6nryFmM5JlJZPaXpaB0Aokl7U9fHF9COaVbppAMzQWMRoP4PstMDOZtkJ\n\tuZgRKUZWL8Knm9N5VzBVDbAwY9kJ+oHbQkbZIsx8=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 23 Aug 2021 19:32:58 +0900","Message-Id":"<20210823103258.1583287-1-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] android: Check exposure time range for\n\tmanual sensor capability","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"In the manual sensor capability validator, add a check for the exposure\ntime range.\n\nSigned-off-by: Paul Elder \n---\n src/android/camera_capabilities.cpp | 22 ++++++++++++++++++++++\n 1 file changed, 22 insertions(+)","diff":"diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\nindex bd661675..5b560b4f 100644\n--- a/src/android/camera_capabilities.cpp\n+++ b/src/android/camera_capabilities.cpp\n@@ -217,6 +217,8 @@ std::vector setMetadata(CameraMetadata *metadata, uint32_t tag,\n \n bool CameraCapabilities::validateManualSensorCapability()\n {\n+\tcamera_metadata_ro_entry_t entry;\n+\n \tconst char *noMode = \"Manual sensor capability unavailable: \";\n \n \tif (!staticMetadata_->entryContains(ANDROID_CONTROL_AE_AVAILABLE_MODES,\n@@ -231,6 +233,26 @@ bool CameraCapabilities::validateManualSensorCapability()\n \t\treturn false;\n \t}\n \n+\tif (!staticMetadata_->hasEntry(ANDROID_SENSOR_INFO_EXPOSURE_TIME_RANGE)) {\n+\t\tLOG(HAL, Info) << noMode << \"missing exposure time range\";\n+\t\treturn false;\n+\t}\n+\n+\tstaticMetadata_->getEntry(ANDROID_SENSOR_INFO_EXPOSURE_TIME_RANGE, &entry);\n+\tif (100000 < entry.data.i32[0]) {\n+\t\tLOG(HAL, Info)\n+\t\t\t<< noMode\n+\t\t\t<< \"exposure time range minimum must be no larger than 100us\";\n+\t\treturn false;\n+\t}\n+\n+\tif (entry.data.i32[1] < 100000000) {\n+\t\tLOG(HAL, Info)\n+\t\t\t<< noMode\n+\t\t\t<< \"exposure time range maximum must be no smaller than 100ms\";\n+\t\treturn false;\n+\t}\n+\n \t/*\n \t * \\todo Return true here after we satisfy all the requirements:\n \t * https://developer.android.com/reference/android/hardware/camera2/CameraMetadata#REQUEST_AVAILABLE_CAPABILITIES_MANUAL_SENSOR\n","prefixes":["libcamera-devel"]}