{"id":13410,"url":"https://patchwork.libcamera.org/api/patches/13410/?format=json","web_url":"https://patchwork.libcamera.org/patch/13410/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210820065316.44343-3-jeanmichel.hautbois@ideasonboard.com>","date":"2021-08-20T06:53:09","name":"[libcamera-devel,v5,2/9] ipa: ipu3: Introduce a Context structure","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"493ac4fd675f70f295da89b4f48dd03febf06dc2","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/13410/mbox/","series":[{"id":2374,"url":"https://patchwork.libcamera.org/api/series/2374/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2374","date":"2021-08-20T06:53:07","name":"IPU3: Introduce modularity for algorithms","version":5,"mbox":"https://patchwork.libcamera.org/series/2374/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/13410/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/13410/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0F2EBC3241\n\tfor ;\n\tFri, 20 Aug 2021 06:53:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 85E4C688AC;\n\tFri, 20 Aug 2021 08:53:24 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6334668892\n\tfor ;\n\tFri, 20 Aug 2021 08:53:21 +0200 (CEST)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:e43b:edb2:932:6b0a])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 07431150A;\n\tFri, 20 Aug 2021 08:53:21 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"olji0kwz\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1629442401;\n\tbh=1LNpQqPrCfIRYk2uPdSvjPph7LnQvqQ2BwsO6OeT/L4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=olji0kwzVg3yG6wdvA+Gk9MaYiJeBn5vflrzeuiucTZZVHixGvEEwgiNXb7u4CjcB\n\taH91c/P8aCr3tQqF0iMO05r6eyPXeletvPkkbH/KB+gR6RGgfsZ8VTSuGXHxcjsOQr\n\tsnp4CkSVxyf7TdsUzinvGdB4KXR+/BVEYzh9z1Eo=","From":"Jean-Michel Hautbois ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 20 Aug 2021 08:53:09 +0200","Message-Id":"<20210820065316.44343-3-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.30.2","In-Reply-To":"<20210820065316.44343-1-jeanmichel.hautbois@ideasonboard.com>","References":"<20210820065316.44343-1-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v5 2/9] ipa: ipu3: Introduce a Context\n\tstructure","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"An increasing amount of data and information needs to be shared between\nthe components that build up to implement image processing algorithms.\n\nCreate a context structure which will allow us to work towards calling\nalgorithms in a modular way, and sharing information between the modules.\n\nThe IPA context is a global context set at configure time\n(IPASessionConfiguration) and a per-frame context (IPAFrameContext) used\nwhile streaming.\n\nSigned-off-by: Kieran Bingham \nSigned-off-by: Jean-Michel Hautbois \nReviewed-by: Kieran Bingham \nReviewed-by: Laurent Pinchart \n---\n src/ipa/ipu3/ipa_context.h | 32 ++++++++++++++++++++++++++\n src/ipa/ipu3/ipu3.cpp | 46 ++++++++++++++++++++++++++++++++++++++\n 2 files changed, 78 insertions(+)\n create mode 100644 src/ipa/ipu3/ipa_context.h","diff":"diff --git a/src/ipa/ipu3/ipa_context.h b/src/ipa/ipu3/ipa_context.h\nnew file mode 100644\nindex 00000000..2706d3ca\n--- /dev/null\n+++ b/src/ipa/ipu3/ipa_context.h\n@@ -0,0 +1,32 @@\n+/* SPDX-License-Identifier: LGPL-2.1-or-later */\n+/*\n+ * Copyright (C) 2021, Google Inc.\n+ *\n+ * ipu3_ipa_context.h - IPU3 IPA Context\n+ *\n+ */\n+#ifndef __LIBCAMERA_IPU3_IPA_CONTEXT_H__\n+#define __LIBCAMERA_IPU3_IPA_CONTEXT_H__\n+\n+#include \n+\n+namespace libcamera {\n+\n+namespace ipa::ipu3 {\n+\n+struct IPASessionConfiguration {\n+};\n+\n+struct IPAFrameContext {\n+};\n+\n+struct IPAContext {\n+\tIPASessionConfiguration configuration;\n+\tIPAFrameContext frameContext;\n+};\n+\n+} /* namespace ipa::ipu3 */\n+\n+} /* namespace libcamera*/\n+\n+#endif /* __LIBCAMERA_IPU3_IPA_CONTEXT_H__ */\ndiff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex c34fa460..d9be37e9 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -33,6 +33,52 @@\n #include \"ipu3_awb.h\"\n #include \"libipa/camera_sensor_helper.h\"\n \n+/**\n+ * \\file ipa_context.h\n+ * \\brief Context and state information shared between the algorithms\n+ */\n+\n+/**\n+ * \\struct IPASessionConfiguration\n+ * \\brief Session configuration for the IPA module\n+ *\n+ * The session configuration contains all IPA configuration parameters that\n+ * remain constant during the capture session, from IPA module start to stop.\n+ * It is typically set during the configure() operation of the IPA module, but\n+ * may also be updated in the start() operation.\n+ */\n+\n+/**\n+ * \\struct IPAFrameContext\n+ * \\brief Per-frame context for algorithms\n+ *\n+ * The frame context stores data specific to a single frame processed by the\n+ * IPA. Each frame processed by the IPA has a context associated with it,\n+ * accessible through the IPAContext structure.\n+ *\n+ * \\todo Detail how to access contexts for a particular frame\n+ *\n+ * Each of the fields in the frame context belongs to either a specific\n+ * algorithm, or to the top-level IPA module. A field may be read by any\n+ * algorithm, but should only be written by its owner.\n+ */\n+\n+/**\n+ * \\struct IPAContext\n+ * \\brief Global IPA context data shared between all algorithms\n+ *\n+ * \\var IPAContext::configuration\n+ * \\brief The IPA session configuration, immutable during the session\n+ *\n+ * \\var IPAContext::frameContext\n+ * \\brief The frame context for the frame being processed\n+ *\n+ * \\todo While the frame context is supposed to be per-frame, this\n+ * single frame context stores data related to both the current frame\n+ * and the previous frames, with fields being updated as the algorithms\n+ * are run. This needs to be turned into real per-frame data storage.\n+ */\n+\n static constexpr uint32_t kMaxCellWidthPerSet = 160;\n static constexpr uint32_t kMaxCellHeightPerSet = 56;\n \n","prefixes":["libcamera-devel","v5","2/9"]}