{"id":13354,"url":"https://patchwork.libcamera.org/api/patches/13354/?format=json","web_url":"https://patchwork.libcamera.org/patch/13354/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210814050912.15113-2-umang.jain@ideasonboard.com>","date":"2021-08-14T05:09:09","name":"[libcamera-devel,v3,1/4] ipa: vimc: Add configure() function","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"28a6c6010987688e3a3e87e6fe70bf0697a0c7f8","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/?format=json","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"delegate":{"id":12,"url":"https://patchwork.libcamera.org/api/users/12/?format=json","username":"uajain","first_name":"Umang","last_name":"Jain","email":"umang.jain@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/13354/mbox/","series":[{"id":2358,"url":"https://patchwork.libcamera.org/api/series/2358/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2358","date":"2021-08-14T05:09:08","name":"Pass buffers to VIMC IPA","version":3,"mbox":"https://patchwork.libcamera.org/series/2358/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/13354/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/13354/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CA764BD87D\n\tfor ;\n\tSat, 14 Aug 2021 05:09:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9336368893;\n\tSat, 14 Aug 2021 07:09:27 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7E1CF6888E\n\tfor ;\n\tSat, 14 Aug 2021 07:09:26 +0200 (CEST)","from perceval.ideasonboard.com (unknown [103.251.226.70])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 134913E5;\n\tSat, 14 Aug 2021 07:09:24 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"j1rS+w5I\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1628917766;\n\tbh=JoNcnvdwVEiSedGCHNAd+WzYB/IjOD32QFkFP+zwSbk=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=j1rS+w5ILIokWYwow9VpItPZ5/BAekXaC+ATa19IC7Lvd+y4KCJ/CmxnjQ7eCWx2h\n\t8ax7pZQOJ0FOPXJiKk8JHvcIKqSwa80atkjnDY44QwhXi+fGf1+InAoHw4F9ofpQNH\n\tTJ9pa8NYPg2l14+Yd42xW+oPPyPBOV+GylHCG/a0=","From":"Umang Jain ","To":"libcamera-devel@lists.libcamera.org","Date":"Sat, 14 Aug 2021 10:39:09 +0530","Message-Id":"<20210814050912.15113-2-umang.jain@ideasonboard.com>","X-Mailer":"git-send-email 2.31.1","In-Reply-To":"<20210814050912.15113-1-umang.jain@ideasonboard.com>","References":"<20210814050912.15113-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 1/4] ipa: vimc: Add configure() function","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Laurent Pinchart \n\nAs part of an effort to make the vimc IPA usable for testing, extend it\nwith a configure function. The configuration is currently ignored by the\nIPA.\n\nSigned-off-by: Laurent Pinchart \nReviewed-by: Paul Elder \nReviewed-by: Umang Jain \nSigned-off-by: Umang Jain \n---\n include/libcamera/ipa/vimc.mojom | 5 +++++\n src/ipa/vimc/vimc.cpp | 13 +++++++++++++\n src/libcamera/pipeline/vimc/vimc.cpp | 16 ++++++++++++++++\n 3 files changed, 34 insertions(+)","diff":"diff --git a/include/libcamera/ipa/vimc.mojom b/include/libcamera/ipa/vimc.mojom\nindex 86bc318a..ee66353d 100644\n--- a/include/libcamera/ipa/vimc.mojom\n+++ b/include/libcamera/ipa/vimc.mojom\n@@ -19,6 +19,11 @@ enum IPAOperationCode {\n \n interface IPAVimcInterface {\n \tinit(libcamera.IPASettings settings) => (int32 ret);\n+\n+\tconfigure(libcamera.IPACameraSensorInfo sensorInfo,\n+\t\t map streamConfig,\n+\t\t map entityControls) => (int32 ret);\n+\n \tstart() => (int32 ret);\n \tstop();\n };\ndiff --git a/src/ipa/vimc/vimc.cpp b/src/ipa/vimc/vimc.cpp\nindex 0c0ee006..fb134084 100644\n--- a/src/ipa/vimc/vimc.cpp\n+++ b/src/ipa/vimc/vimc.cpp\n@@ -34,6 +34,10 @@ public:\n \tint start() override;\n \tvoid stop() override;\n \n+\tint configure(const IPACameraSensorInfo &sensorInfo,\n+\t\t const std::map &streamConfig,\n+\t\t const std::map &entityControls) override;\n+\n private:\n \tvoid initTrace();\n \tvoid trace(enum ipa::vimc::IPAOperationCode operation);\n@@ -86,6 +90,15 @@ void IPAVimc::stop()\n \tLOG(IPAVimc, Debug) << \"stop vimc IPA!\";\n }\n \n+int IPAVimc::configure([[maybe_unused]] const IPACameraSensorInfo &sensorInfo,\n+\t\t\t[[maybe_unused]] const std::map &streamConfig,\n+\t\t\t[[maybe_unused]] const std::map &entityControls)\n+{\n+\tLOG(IPAVimc, Debug) << \"configure()\";\n+\n+\treturn 0;\n+}\n+\n void IPAVimc::initTrace()\n {\n \tstruct stat fifoStat;\ndiff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp\nindex d4b041d3..4c92729d 100644\n--- a/src/libcamera/pipeline/vimc/vimc.cpp\n+++ b/src/libcamera/pipeline/vimc/vimc.cpp\n@@ -295,6 +295,22 @@ int PipelineHandlerVimc::configure(Camera *camera, CameraConfiguration *config)\n \n \tcfg.setStream(&data->stream_);\n \n+\tif (data->ipa_) {\n+\t\t/* Inform IPA of stream configuration and sensor controls. */\n+\t\tstd::map streamConfig;\n+\t\tstreamConfig.emplace(std::piecewise_construct,\n+\t\t\t\t std::forward_as_tuple(0),\n+\t\t\t\t std::forward_as_tuple(cfg.pixelFormat, cfg.size));\n+\n+\t\tstd::map entityControls;\n+\t\tentityControls.emplace(0, data->sensor_->controls());\n+\n+\t\tIPACameraSensorInfo sensorInfo;\n+\t\tdata->sensor_->sensorInfo(&sensorInfo);\n+\n+\t\tdata->ipa_->configure(sensorInfo, streamConfig, entityControls);\n+\t}\n+\n \treturn 0;\n }\n \n","prefixes":["libcamera-devel","v3","1/4"]}