[{"id":18759,"web_url":"https://patchwork.libcamera.org/comment/18759/","msgid":"<62e116da-59e9-1256-3a8d-b7c3eca9f607@ideasonboard.com>","date":"2021-08-13T09:54:01","subject":"Re: [libcamera-devel] [PATCH v2 07/10] ipa: ipu3: convert AGC to\n\tthe new algorithm interface","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 12/08/2021 17:52, Jean-Michel Hautbois wrote:\n\nPerhaps a little extra brief to summarise beyond the title?\n\n\"\"\"\nIn preparation for using the AGC through the new algorithm interfaces,\nconvert the existing code to use the new function types.\n\"\"\"\n\nBut I wonder if this would get squashed into the next patch.\n\nIf not, (and it might be good to keep it separated, as I can see the\nchanges to the functions required), then\n\nReviewed-by: Kieran Bingham \n\n\n> Signed-off-by: Jean-Michel Hautbois \n> ---\n> src/ipa/ipu3/ipu3.cpp | 2 +-\n> src/ipa/ipu3/ipu3_agc.cpp | 8 +++++---\n> src/ipa/ipu3/ipu3_agc.h | 2 +-\n> 3 files changed, 7 insertions(+), 5 deletions(-)\n> \n> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> index dba5554d..2a8225a0 100644\n> --- a/src/ipa/ipu3/ipu3.cpp\n> +++ b/src/ipa/ipu3/ipu3.cpp\n> @@ -232,7 +232,7 @@ int IPAIPU3::configure(const IPAConfigInfo &configInfo)\n> \tawbAlgo_ = std::make_unique();\n> \n> \tagcAlgo_ = std::make_unique();\n> -\tagcAlgo_->initialise(context_.configuration.grid.bdsGrid, sensorInfo_);\n> +\tagcAlgo_->configure(context_, configInfo);\n> \n> \treturn 0;\n> }\n> diff --git a/src/ipa/ipu3/ipu3_agc.cpp b/src/ipa/ipu3/ipu3_agc.cpp\n> index c6782ff4..0cc35b9f 100644\n> --- a/src/ipa/ipu3/ipu3_agc.cpp\n> +++ b/src/ipa/ipu3/ipu3_agc.cpp\n> @@ -59,12 +59,14 @@ IPU3Agc::IPU3Agc()\n> {\n> }\n> \n> -void IPU3Agc::initialise(struct ipu3_uapi_grid_config &bdsGrid, const IPACameraSensorInfo &sensorInfo)\n> +int IPU3Agc::configure(IPAContext &context, const IPAConfigInfo &configInfo)\n> {\n> -\taeGrid_ = bdsGrid;\n> +\taeGrid_ = context.configuration.grid.bdsGrid;\n> \n> -\tlineDuration_ = sensorInfo.lineLength * 1.0s / sensorInfo.pixelRate;\n> +\tlineDuration_ = configInfo.sensorInfo.lineLength * 1.0s / configInfo.sensorInfo.pixelRate;\n> \tmaxExposureTime_ = kMaxExposure * lineDuration_;\n> +\n> +\treturn 0;\n> }\n> \n> void IPU3Agc::processBrightness(const ipu3_uapi_stats_3a *stats)\n> diff --git a/src/ipa/ipu3/ipu3_agc.h b/src/ipa/ipu3/ipu3_agc.h\n> index 8b32e52f..e096648b 100644\n> --- a/src/ipa/ipu3/ipu3_agc.h\n> +++ b/src/ipa/ipu3/ipu3_agc.h\n> @@ -29,7 +29,7 @@ public:\n> \tIPU3Agc();\n> \t~IPU3Agc() = default;\n> \n> -\tvoid initialise(struct ipu3_uapi_grid_config &bdsGrid, const IPACameraSensorInfo &sensorInfo);\n> +\tint configure(IPAContext &context, const IPAConfigInfo &configInfo) override;\n> \tvoid process(IPAContext &context, const ipu3_uapi_stats_3a *stats) override;\n> \tbool converged() { return converged_; }\n> \tbool updateControls() { return updateControls_; }\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9864FC3240\n\tfor ;\n\tFri, 13 Aug 2021 09:54:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4F6C86888E;\n\tFri, 13 Aug 2021 11:54:06 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9586560263\n\tfor ;\n\tFri, 13 Aug 2021 11:54:05 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 154F9EE;\n\tFri, 13 Aug 2021 11:54:05 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"cOdkT+FQ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1628848445;\n\tbh=XwAgUoDHO74HZZjHU8344tWZZ130kEuJPCasstDxe5Q=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=cOdkT+FQ51VcX4Pzycqm5wO8W3iV39p5jwyk4Qb1j5l0++/+RIQbLGiA8Khisjk9x\n\ttO+S5I/mDkmbVFC7Mxi4WJh3kDFpRbvawVcdgkfyXVacmAu21rcKkV8y/ZM6g7PsZq\n\t63yLpjBZGcG+7EHvpuWWAnaMT8d6RLadnlmQ3kts=","To":"Jean-Michel Hautbois ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210812165243.276977-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20210812165243.276977-8-jeanmichel.hautbois@ideasonboard.com>","From":"Kieran Bingham ","Message-ID":"<62e116da-59e9-1256-3a8d-b7c3eca9f607@ideasonboard.com>","Date":"Fri, 13 Aug 2021 10:54:01 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.11.0","MIME-Version":"1.0","In-Reply-To":"<20210812165243.276977-8-jeanmichel.hautbois@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v2 07/10] ipa: ipu3: convert AGC to\n\tthe new algorithm interface","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]