[{"id":18812,"web_url":"https://patchwork.libcamera.org/comment/18812/","msgid":"","date":"2021-08-16T00:22:57","subject":"Re: [libcamera-devel] [PATCH v2 02/10] ipa: ipu3: Introduce a\n\tContext structure","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jean-Michel,\n\nThank you for the patch.\n\nOn Thu, Aug 12, 2021 at 06:52:35PM +0200, Jean-Michel Hautbois wrote:\n> An increasing amount of data and information needs to be shared between\n> the components that build up to implement image processing algorithms.\n> \n> Create a context structure which will allow us to work towards calling\n> algorithms in a modular way, and sharing information between the modules.\n> \n> The IPA context is a global context set at configure time (IPAConfiguration)\n> and a per-frame context (IPAFrameContext) used while streaming.\n> \n> Signed-off-by: Kieran Bingham \n> Signed-off-by: Jean-Michel Hautbois \n> ---\n> src/ipa/ipu3/ipa_context.h | 40 ++++++++++++++++++++++++++++++++++++++\n> 1 file changed, 40 insertions(+)\n> create mode 100644 src/ipa/ipu3/ipa_context.h\n> \n> diff --git a/src/ipa/ipu3/ipa_context.h b/src/ipa/ipu3/ipa_context.h\n> new file mode 100644\n> index 00000000..0a197a41\n> --- /dev/null\n> +++ b/src/ipa/ipu3/ipa_context.h\n> @@ -0,0 +1,40 @@\n> +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n> +/*\n> + * Copyright (C) 2021, Google Inc.\n> + *\n> + * ipu3_ipa_context.h - IPU3 IPA Context\n> + *\n> + * Context information shared between the algorithms\n\nThis line belongs to the definition of the structure below.\n\n> + */\n> +#ifndef __LIBCAMERA_IPU3_IPA_CONTEXT_H__\n> +#define __LIBCAMERA_IPU3_IPA_CONTEXT_H__\n> +\n> +#include \n> +\n> +namespace libcamera {\n> +\n> +namespace ipa::ipu3 {\n> +\n> +/* Fixed configuration of the IPA */\n\nCould you format documentation using Doxygen ?\n\nThe documentation needs to be expanded, along with the documentation of\nthe Algorithm functions, to explain how the pieces fit together.\n\n> +struct IPAConfiguration {\n> +};\n> +\n> +/*\n> + * Context of a frame for each algorithms\n> + * This may be stored in a way that is associated with a given request\n> + * lifetime, though for now a single instance is used.\n> + */\n> +struct IPAFrameContext {\n> +};\n> +\n> +/* Global context of the IPA */\n> +struct IPAContext {\n> +\tIPAConfiguration configuration;\n> +\tIPAFrameContext frameContext;\n> +};\n> +\n> +} /* namespace ipa::ipu3 */\n> +\n> +} /* namespace libcamera*/\n> +\n> +#endif /* __LIBCAMERA_IPU3_IPA_CONTEXT_H__ */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8D290BD87D\n\tfor ;\n\tMon, 16 Aug 2021 00:23:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4839068890;\n\tMon, 16 Aug 2021 02:23:04 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3F7D260261\n\tfor ;\n\tMon, 16 Aug 2021 02:23:03 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D5D5A3E5;\n\tMon, 16 Aug 2021 02:23:02 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pKOpnMeL\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1629073383;\n\tbh=5J1lGf5BPLZUATtu291HfnvKZ5y0n8Z2OGTm/BPSm6A=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=pKOpnMeLSZsu+yTQa8DKM4LVATvgTaJNOagMjwGA4vMSw8KvYPm0DjnHOWmjwJAN3\n\tTETlhC4qUVxKLYS2uRvVihQ/5qbPSaZpvcXzUZ5YXw7HR6WIVUmyfT/Kgnwr8SXbzS\n\tAGQAm+3p4gMJySLuP5oEEShl8w/G2mfBgb02XPrI=","Date":"Mon, 16 Aug 2021 03:22:57 +0300","From":"Laurent Pinchart ","To":"Jean-Michel Hautbois ","Message-ID":"","References":"<20210812165243.276977-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20210812165243.276977-3-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210812165243.276977-3-jeanmichel.hautbois@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 02/10] ipa: ipu3: Introduce a\n\tContext structure","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]