[{"id":18722,"web_url":"https://patchwork.libcamera.org/comment/18722/","msgid":"<20210812073857.n63hkq2d76wftfhk@uno.localdomain>","date":"2021-08-12T07:38:57","subject":"Re: [libcamera-devel] [PATCH v2] ipa: raspberrypi: Use boolean\n\tconstructor for AeEnable ControlInfo","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Paul,\n\nOn Thu, Aug 12, 2021 at 01:22:49PM +0900, Paul Elder wrote:\n> The min-max constructor is not the proper constructor for boolean\n> ControlInfos. Use the proper boolean constructor.\n>\n> Signed-off-by: Paul Elder \n>\n> ---\n> Changes in v2:\n> - whoops, sorry v1 was based on Jacopo's \"libcamera: Initialize controls\n> in the IPA\"\n\nAs I'm about to merge that series, the first version you sent might\napply better :)\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> include/libcamera/ipa/raspberrypi.h | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/include/libcamera/ipa/raspberrypi.h b/include/libcamera/ipa/raspberrypi.h\n> index a8790000..7ef14e57 100644\n> --- a/include/libcamera/ipa/raspberrypi.h\n> +++ b/include/libcamera/ipa/raspberrypi.h\n> @@ -28,7 +28,7 @@ namespace RPi {\n> * unsupported control is encountered.\n> */\n> static const ControlInfoMap Controls = {\n> -\t{ &controls::AeEnable, ControlInfo(false, true) },\n> +\t{ &controls::AeEnable, ControlInfo({false, true}, true) },\n> \t{ &controls::ExposureTime, ControlInfo(0, 999999) },\n> \t{ &controls::AnalogueGain, ControlInfo(1.0f, 32.0f) },\n> \t{ &controls::AeMeteringMode, ControlInfo(controls::AeMeteringModeValues) },\n> --\n> 2.27.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 50F93C3240\n\tfor ;\n\tThu, 12 Aug 2021 07:38:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D53CA6884D;\n\tThu, 12 Aug 2021 09:38:11 +0200 (CEST)","from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 482EB60264\n\tfor ;\n\tThu, 12 Aug 2021 09:38:10 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay3-d.mail.gandi.net (Postfix) with ESMTPSA id A14DE60005;\n\tThu, 12 Aug 2021 07:38:09 +0000 (UTC)"],"Date":"Thu, 12 Aug 2021 09:38:57 +0200","From":"Jacopo Mondi ","To":"Paul Elder ","Message-ID":"<20210812073857.n63hkq2d76wftfhk@uno.localdomain>","References":"<20210812042249.1073932-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210812042249.1073932-1-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2] ipa: raspberrypi: Use boolean\n\tconstructor for AeEnable ControlInfo","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]