[{"id":18746,"web_url":"https://patchwork.libcamera.org/comment/18746/","msgid":"","date":"2021-08-12T21:06:30","subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: Use boolean\n\tconstructor for AeEnable ControlInfo","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Thu, Aug 12, 2021 at 12:48:18PM +0900, Paul Elder wrote:\n> The min-max constructor is not the proper constructor for boolean\n> ControlInfos. Use the proper boolean constructor.\n> \n> Signed-off-by: Paul Elder \n\nJust to make sure, have you tested enabling/disabling AE with this patch\napplied ? If so,\n\nReviewed-by: Laurent Pinchart \n\n> ---\n> include/libcamera/ipa/raspberrypi.h | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/include/libcamera/ipa/raspberrypi.h b/include/libcamera/ipa/raspberrypi.h\n> index b82c2cec..6ff9ed7b 100644\n> --- a/include/libcamera/ipa/raspberrypi.h\n> +++ b/include/libcamera/ipa/raspberrypi.h\n> @@ -28,7 +28,7 @@ namespace RPi {\n> * unsupported control is encountered.\n> */\n> static const ControlInfoMap Controls({\n> -\t\t{ &controls::AeEnable, ControlInfo(false, true) },\n> +\t\t{ &controls::AeEnable, ControlInfo({ false, true }, true) },\n> \t\t{ &controls::ExposureTime, ControlInfo(0, 999999) },\n> \t\t{ &controls::AnalogueGain, ControlInfo(1.0f, 32.0f) },\n> \t\t{ &controls::AeMeteringMode, ControlInfo(controls::AeMeteringModeValues) },","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4768DC3240\n\tfor ;\n\tThu, 12 Aug 2021 21:06:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BBD6A6888A;\n\tThu, 12 Aug 2021 23:06:36 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5097768823\n\tfor ;\n\tThu, 12 Aug 2021 23:06:35 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AAC86EE;\n\tThu, 12 Aug 2021 23:06:34 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"JheOpsqu\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1628802394;\n\tbh=kBO4PY+c/i9OmTv/FchmKYTbgbHb7MzqrL4d53qGENA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=JheOpsquLMct9Gfjtk/SOWTniGNgX7QdMvgxrhxmlBkRE/M0/f7lYkc10xrz6h8hr\n\t2uEYu0CIMVyoO70gLVT5wrxXNHmFGwEi/abEX/K/I98h2jUH3L3y48+tjOp9ems5rI\n\tLBcXv7pJ/LEGnvliPULIQexuwNMi37QKbdwy5owo=","Date":"Fri, 13 Aug 2021 00:06:30 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Message-ID":"","References":"<20210812034818.1070867-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210812034818.1070867-1-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: Use boolean\n\tconstructor for AeEnable ControlInfo","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]