[{"id":18724,"web_url":"https://patchwork.libcamera.org/comment/18724/","msgid":"<20210812074907.37f53nu2pyizr7of@uno.localdomain>","date":"2021-08-12T07:49:07","subject":"Re: [libcamera-devel] [PATCH v3 04/14] libcamera: camera: Fix minor\n\tissues in Camera::Private documentation","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Thu, Aug 12, 2021 at 02:26:15AM +0300, Laurent Pinchart wrote:\n> Improve the Camera::Private documentation by fixing minor spelling or\n> style issues.\n>\n> Signed-off-by: Laurent Pinchart \n> ---\n> src/libcamera/camera.cpp | 8 ++++----\n> 1 file changed, 4 insertions(+), 4 deletions(-)\n>\n> diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n> index 4080da151af1..a22cc7b8e49d 100644\n> --- a/src/libcamera/camera.cpp\n> +++ b/src/libcamera/camera.cpp\n> @@ -368,10 +368,10 @@ Camera::Private::~Private()\n>\n> /**\n> * \\var Camera::Private::queuedRequests_\n> - * \\brief The list of queued and not yet completed request\n> + * \\brief The list of queued and not yet completed requests\n> *\n> - * The list of queued request is used to track requests queued in order to\n> - * ensure completion of all requests when the pipeline handler is stopped.\n> + * This list tracks requests queued in order to ensure completion of all\n> + * requests when the pipeline handler is stopped.\n> *\n> * \\sa PipelineHandler::queueRequest(), PipelineHandler::stop(),\n> * PipelineHandler::completeRequest()\n> @@ -400,7 +400,7 @@ Camera::Private::~Private()\n>\n> /**\n> * \\var Camera::Private::requestSequence_\n> - * \\brief The queuing sequence of the request\n> + * \\brief The queuing sequence number of the request\n> *\n> * When requests are queued, they are given a per-camera sequence number to\n> * facilitate debugging of internal request usage.\n\nThanks, I'm sorry this required you additional work, I noticed the\ndocumentation was verbatim copied only after I reviewed it.\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 21894BD87D\n\tfor ;\n\tThu, 12 Aug 2021 07:48:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E73366884F;\n\tThu, 12 Aug 2021 09:48:20 +0200 (CEST)","from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net\n\t[217.70.183.199])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D95A060264\n\tfor ;\n\tThu, 12 Aug 2021 09:48:19 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 5D8B0FF806;\n\tThu, 12 Aug 2021 07:48:19 +0000 (UTC)"],"Date":"Thu, 12 Aug 2021 09:49:07 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Message-ID":"<20210812074907.37f53nu2pyizr7of@uno.localdomain>","References":"<20210811232625.17280-1-laurent.pinchart@ideasonboard.com>\n\t<20210811232625.17280-5-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210811232625.17280-5-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3 04/14] libcamera: camera: Fix minor\n\tissues in Camera::Private documentation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":18827,"web_url":"https://patchwork.libcamera.org/comment/18827/","msgid":"<509867ee-05f1-b1d7-f877-995f65a1c70c@ideasonboard.com>","date":"2021-08-16T10:16:30","subject":"Re: [libcamera-devel] [PATCH v3 04/14] libcamera: camera: Fix minor\n\tissues in Camera::Private documentation","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 12/08/2021 00:26, Laurent Pinchart wrote:\n> Improve the Camera::Private documentation by fixing minor spelling or\n> style issues.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/libcamera/camera.cpp | 8 ++++----\n> 1 file changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n> index 4080da151af1..a22cc7b8e49d 100644\n> --- a/src/libcamera/camera.cpp\n> +++ b/src/libcamera/camera.cpp\n> @@ -368,10 +368,10 @@ Camera::Private::~Private()\n> \n> /**\n> * \\var Camera::Private::queuedRequests_\n> - * \\brief The list of queued and not yet completed request\n> + * \\brief The list of queued and not yet completed requests\n> *\n> - * The list of queued request is used to track requests queued in order to\n> - * ensure completion of all requests when the pipeline handler is stopped.\n> + * This list tracks requests queued in order to ensure completion of all\n> + * requests when the pipeline handler is stopped.\n> *\n> * \\sa PipelineHandler::queueRequest(), PipelineHandler::stop(),\n> * PipelineHandler::completeRequest()\n> @@ -400,7 +400,7 @@ Camera::Private::~Private()\n> \n> /**\n> * \\var Camera::Private::requestSequence_\n> - * \\brief The queuing sequence of the request\n> + * \\brief The queuing sequence number of the request\n> *\n> * When requests are queued, they are given a per-camera sequence number to\n> * facilitate debugging of internal request usage.\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E504ABD87D\n\tfor ;\n\tMon, 16 Aug 2021 10:16:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 44EB26888E;\n\tMon, 16 Aug 2021 12:16:35 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E3F756025D\n\tfor ;\n\tMon, 16 Aug 2021 12:16:33 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7EDC93E5;\n\tMon, 16 Aug 2021 12:16:33 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"l2r3rFvK\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1629108993;\n\tbh=5lc8865zaaA8vCXk21Zth7fNjCZjNj/pY0rrlKyTLww=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=l2r3rFvKLwHvLDVsZllqm0DMLKpxpxH7s5HUPycOKA1dl1Tc12l+NvwQNARthSP69\n\tWtDxdqdQ2z4+b+Mt7v4ayh/kiXPfaIoOMl/0GrALx52C9okn55TCc0EJ0fKXhSHTip\n\tobXj7/9fF57NimNvOOQWxV/CSo9wQ9+Zs5W6Ki+c=","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210811232625.17280-1-laurent.pinchart@ideasonboard.com>\n\t<20210811232625.17280-5-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Message-ID":"<509867ee-05f1-b1d7-f877-995f65a1c70c@ideasonboard.com>","Date":"Mon, 16 Aug 2021 11:16:30 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.11.0","MIME-Version":"1.0","In-Reply-To":"<20210811232625.17280-5-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v3 04/14] libcamera: camera: Fix minor\n\tissues in Camera::Private documentation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]