[{"id":18693,"web_url":"https://patchwork.libcamera.org/comment/18693/","msgid":"","date":"2021-08-11T12:08:45","subject":"Re: [libcamera-devel] [PATCH] base: class: Remove undesired\n\tsemi-colon from LIBCAMERA_O_PTR","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Wed, Aug 11, 2021 at 09:05:46AM +0100, Kieran Bingham wrote:\n> The LIBCAMERA_O_PTR() define adds the ';' at the end of the\n> templated call to _o().\n> \n> While this works for the only current user in camera_manager.cpp, even\n> the statement there adds another semi-colon following it.\n> \n> The addition of the semi-colon in the define unnecessarily prohibits the\n> macro from being used in places other than the end of a statement.\n> \n> Remove it.\n> \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> include/libcamera/base/class.h | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/include/libcamera/base/class.h b/include/libcamera/base/class.h\n> index a5946836d2b9..02bbd91f93f8 100644\n> --- a/include/libcamera/base/class.h\n> +++ b/include/libcamera/base/class.h\n> @@ -50,7 +50,7 @@ public:\t\t\t\t\t\t\t\t\t\\\n> \tusing Public = klass;\n> \n> #define LIBCAMERA_O_PTR()\t\t\t\t\t\t\\\n> -\t_o();\n> +\t_o()\n> \n> #else\n> #define LIBCAMERA_DECLARE_PRIVATE()","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 266EEC3240\n\tfor ;\n\tWed, 11 Aug 2021 12:08:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 90D4B6884F;\n\tWed, 11 Aug 2021 14:08:50 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CCB8568826\n\tfor ;\n\tWed, 11 Aug 2021 14:08:48 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 55AEEEE;\n\tWed, 11 Aug 2021 14:08:48 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"vvidNPtQ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1628683728;\n\tbh=jxCY4NW0uYVNLJjsRViJx6ghD59EksB57Uqt6ys9GAI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=vvidNPtQ0MyXgFPDz5S8PHFMxVvl+tfCapKoWVIy52oGHCtQxzbihhhjZ2ZYXBwj1\n\tV6aPXkNij/G5WUU+SyZKwwHA34E9E/GWMdKh6rnkBmKZuhzrLxJdP5qB0Sw/DE9E8K\n\tq2GXHR3J0QD7d2TNW1jGUCil+Rg7kQ8NvmlAKDmk=","Date":"Wed, 11 Aug 2021 15:08:45 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20210811080546.2266825-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210811080546.2266825-1-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] base: class: Remove undesired\n\tsemi-colon from LIBCAMERA_O_PTR","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]