[{"id":1738,"web_url":"https://patchwork.libcamera.org/comment/1738/","msgid":"<20190603104318.GC4933@pendragon.ideasonboard.com>","date":"2019-06-03T10:43:18","subject":"Re: [libcamera-devel] [PATCH] test: camera: Fix initialisation","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Thu, May 30, 2019 at 02:38:49PM +0100, Kieran Bingham wrote:\n> Three tests {capture,configuration_set,statemachine} override the\n> CameraTest::init() function, and call it as the first action.\n> \n> However they were not checking the return value, and each of the tests\n> will segfault if the VIMC camera is not obtained.\n> \n> Check the return value of the CameraTest base class initialisation and\n> return any errors to the test suite if initialisation fails.\n> \n> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> ---\n>  test/camera/capture.cpp           | 4 +++-\n>  test/camera/configuration_set.cpp | 4 +++-\n>  test/camera/statemachine.cpp      | 4 +++-\n>  3 files changed, 9 insertions(+), 3 deletions(-)\n> \n> diff --git a/test/camera/capture.cpp b/test/camera/capture.cpp\n> index c0835c250c65..98e71905531c 100644\n> --- a/test/camera/capture.cpp\n> +++ b/test/camera/capture.cpp\n> @@ -42,7 +42,9 @@ protected:\n>  \n>  \tint init() override\n>  \t{\n> -\t\tCameraTest::init();\n> +\t\tint ret = CameraTest::init();\n> +\t\tif (ret)\n> +\t\t\treturn ret;\n>  \n>  \t\tconfig_ = camera_->generateConfiguration({ StreamRole::VideoRecording });\n>  \t\tif (!config_ || config_->size() != 1) {\n> diff --git a/test/camera/configuration_set.cpp b/test/camera/configuration_set.cpp\n> index 9f10f795a5d8..f88da96ca2b7 100644\n> --- a/test/camera/configuration_set.cpp\n> +++ b/test/camera/configuration_set.cpp\n> @@ -18,7 +18,9 @@ class ConfigurationSet : public CameraTest\n>  protected:\n>  \tint init() override\n>  \t{\n> -\t\tCameraTest::init();\n> +\t\tint ret = CameraTest::init();\n> +\t\tif (ret)\n> +\t\t\treturn ret;\n>  \n>  \t\tconfig_ = camera_->generateConfiguration({ StreamRole::VideoRecording });\n>  \t\tif (!config_ || config_->size() != 1) {\n> diff --git a/test/camera/statemachine.cpp b/test/camera/statemachine.cpp\n> index d489f197e402..84d2a6fab5f0 100644\n> --- a/test/camera/statemachine.cpp\n> +++ b/test/camera/statemachine.cpp\n> @@ -235,7 +235,9 @@ protected:\n>  \n>  \tint init() override\n>  \t{\n> -\t\tCameraTest::init();\n> +\t\tint ret = CameraTest::init();\n> +\t\tif (ret)\n> +\t\t\treturn ret;\n>  \n>  \t\tdefconf_ = camera_->generateConfiguration({ StreamRole::VideoRecording });\n>  \t\tif (!defconf_) {","headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4DD9860BD7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon,  3 Jun 2019 12:43:31 +0200 (CEST)","from pendragon.ideasonboard.com (unknown\n\t[IPv6:2a02:2788:668:163:5bb7:9f6c:564c:d55e])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C68E5530;\n\tMon,  3 Jun 2019 12:43:30 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1559558610;\n\tbh=34qUQsdL2prjFk6lONVxQ2ge+ViIfcrfmt3ezWUBClg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=lHAGsSlSIxDfa/DZAiCJW4e5DNbo1fTY5DVIJTOvqBVtG6cJ061LL+poGamkeukl5\n\t3mr0Z0wjmMoUHKxqKmrDHSRtpdrdFYIFouM/EbYceJos8VzgT8qcdulhSSunocn+LZ\n\tMoMWqyj2mVbiy3qbKrfwGBHzHx3JFfLonXc7k/eg=","Date":"Mon, 3 Jun 2019 13:43:18 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"LibCamera Devel <libcamera-devel@lists.libcamera.org>","Message-ID":"<20190603104318.GC4933@pendragon.ideasonboard.com>","References":"<20190530133849.17366-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190530133849.17366-1-kieran.bingham@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH] test: camera: Fix initialisation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Mon, 03 Jun 2019 10:43:31 -0000"}},{"id":1825,"web_url":"https://patchwork.libcamera.org/comment/1825/","msgid":"<20190610112632.GA1362@bigcity.dyn.berto.se>","date":"2019-06-10T11:26:32","subject":"Re: [libcamera-devel] [PATCH] test: camera: Fix initialisation","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Kieran,\n\nThanks for your work.\n\nOn 2019-05-30 14:38:49 +0100, Kieran Bingham wrote:\n> Three tests {capture,configuration_set,statemachine} override the\n> CameraTest::init() function, and call it as the first action.\n> \n> However they were not checking the return value, and each of the tests\n> will segfault if the VIMC camera is not obtained.\n> \n> Check the return value of the CameraTest base class initialisation and\n> return any errors to the test suite if initialisation fails.\n> \n> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n\n> ---\n>  test/camera/capture.cpp           | 4 +++-\n>  test/camera/configuration_set.cpp | 4 +++-\n>  test/camera/statemachine.cpp      | 4 +++-\n>  3 files changed, 9 insertions(+), 3 deletions(-)\n> \n> diff --git a/test/camera/capture.cpp b/test/camera/capture.cpp\n> index c0835c250c65..98e71905531c 100644\n> --- a/test/camera/capture.cpp\n> +++ b/test/camera/capture.cpp\n> @@ -42,7 +42,9 @@ protected:\n>  \n>  \tint init() override\n>  \t{\n> -\t\tCameraTest::init();\n> +\t\tint ret = CameraTest::init();\n> +\t\tif (ret)\n> +\t\t\treturn ret;\n>  \n>  \t\tconfig_ = camera_->generateConfiguration({ StreamRole::VideoRecording });\n>  \t\tif (!config_ || config_->size() != 1) {\n> diff --git a/test/camera/configuration_set.cpp b/test/camera/configuration_set.cpp\n> index 9f10f795a5d8..f88da96ca2b7 100644\n> --- a/test/camera/configuration_set.cpp\n> +++ b/test/camera/configuration_set.cpp\n> @@ -18,7 +18,9 @@ class ConfigurationSet : public CameraTest\n>  protected:\n>  \tint init() override\n>  \t{\n> -\t\tCameraTest::init();\n> +\t\tint ret = CameraTest::init();\n> +\t\tif (ret)\n> +\t\t\treturn ret;\n>  \n>  \t\tconfig_ = camera_->generateConfiguration({ StreamRole::VideoRecording });\n>  \t\tif (!config_ || config_->size() != 1) {\n> diff --git a/test/camera/statemachine.cpp b/test/camera/statemachine.cpp\n> index d489f197e402..84d2a6fab5f0 100644\n> --- a/test/camera/statemachine.cpp\n> +++ b/test/camera/statemachine.cpp\n> @@ -235,7 +235,9 @@ protected:\n>  \n>  \tint init() override\n>  \t{\n> -\t\tCameraTest::init();\n> +\t\tint ret = CameraTest::init();\n> +\t\tif (ret)\n> +\t\t\treturn ret;\n>  \n>  \t\tdefconf_ = camera_->generateConfiguration({ StreamRole::VideoRecording });\n>  \t\tif (!defconf_) {\n> -- \n> 2.20.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"<niklas.soderlund@ragnatech.se>","Received":["from mail-lj1-x242.google.com (mail-lj1-x242.google.com\n\t[IPv6:2a00:1450:4864:20::242])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3E855636FF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 10 Jun 2019 13:26:35 +0200 (CEST)","by mail-lj1-x242.google.com with SMTP id k18so7554587ljc.11\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 10 Jun 2019 04:26:35 -0700 (PDT)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\tm4sm1903296ljc.56.2019.06.10.04.26.32\n\t(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);\n\tMon, 10 Jun 2019 04:26:32 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=wsYVeh2mFei4yAWrCOhMuJTCGwDRGPPXa8A5wGf0Urg=;\n\tb=SiGw+pNtrvfouSBQqE+DTTYYq6pG5He8i2Xs3N9xkbDYYgEqP9l/mvzMGFaAX+4fiR\n\tDb836eVTn2KAmmtvAFI1pypwhMtOgGgUdtp5TKDBfucMhZQG6JrVBnVMuH2NGi/wRYth\n\tXu98ODq+I6an+WRz6KwI9lpcxZdfibb7h3zYv8hf/ZrGWJKfbvKeDRKaLSmyrNa+WVtZ\n\tdBeyS0QjyB+SdqW1VnP1Mg2UBq0ZM86X44LF/tSOYGLEBjnuPkTlH7I4fRqEl6Jc1MyQ\n\tvJv4Ropo+u9Dl+JGzGDVhfQiCOgd8zsM/zu83ntGX3JUNsWKdwBlW5swDZyLnwil4UMO\n\tmLtg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=wsYVeh2mFei4yAWrCOhMuJTCGwDRGPPXa8A5wGf0Urg=;\n\tb=V/Xq2QUJ2qrIsj+qPBmowFUFkFSnevsuYvBqqYIatfjHUZU6JIgi2iv68hL9KJTVlZ\n\t9XeN08ygclp7mvtz2vPXtmGTDlX++Uiv7patbuiRHnCZuTWfgppihj8L9AkatiSwYuLF\n\tBFsYJLPXB2O7zOsgt5SJXDbqyDI5ddIVT2ic3yRDhAYQyQK4UzFu/QaqV8c4TZhrj8Dd\n\thqRd/VmcYi04qu9aWxSaKaDQ1v589oC7+56iNl+ml/2Z0e+hlKZDbQ6Fvle6jHYODrNX\n\t7oPKWoN15BkM/7BhbPyfngf+/VGuHIdcXptTqVEkMeKNSSOpaitvJvQ1vCKBVX8p+zpA\n\tk2Sw==","X-Gm-Message-State":"APjAAAXA2YSNDsr+VOPExg+gglzEzoVOa5VBESYKXC3/+nWsRAridGz1\n\tviB4vC7VEIYcDClV3X2VqE7ASSqJEQA=","X-Google-Smtp-Source":"APXvYqzLWp4LjgErFaJNyZcpo6XWjmvvFoE1QvwuL2KFS2SmEY6/UluyDD5jFYsaoXKRNJW8e46BZw==","X-Received":"by 2002:a2e:93c5:: with SMTP id p5mr2262933ljh.79.1560165994147; \n\tMon, 10 Jun 2019 04:26:34 -0700 (PDT)","Date":"Mon, 10 Jun 2019 13:26:32 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= <niklas.soderlund@ragnatech.se>","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"LibCamera Devel <libcamera-devel@lists.libcamera.org>","Message-ID":"<20190610112632.GA1362@bigcity.dyn.berto.se>","References":"<20190530133849.17366-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190530133849.17366-1-kieran.bingham@ideasonboard.com>","User-Agent":"Mutt/1.11.4 (2019-03-13)","Subject":"Re: [libcamera-devel] [PATCH] test: camera: Fix initialisation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Mon, 10 Jun 2019 11:26:35 -0000"}},{"id":1826,"web_url":"https://patchwork.libcamera.org/comment/1826/","msgid":"<19d914d5-62d5-4f45-c23a-2810da6a083f@ideasonboard.com>","date":"2019-06-10T11:30:31","subject":"Re: [libcamera-devel] [PATCH] test: camera: Fix initialisation","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 10/06/2019 12:26, Niklas Söderlund wrote:\n> Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n\nThanks, pushed with yours and Laurents tags.","headers":{"Return-Path":"<kieran.bingham@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1541D636A9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 10 Jun 2019 13:30:35 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 69D669CB;\n\tMon, 10 Jun 2019 13:30:34 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1560166234;\n\tbh=3tzru/Yb29Q8Ge2tPIb0b3zwTNBZ9VnWuEZQw0iAArs=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=FxB4qPLQjjt8GVNflubRSQTuXvDy1Y8A3kg92JArKy7I33xhJ8RMj5WTsAE7x6M7D\n\tpoD77AS8Xu7fMNkL3yZTinwTHRN0RavYvcNjQ/GFTb4TtxDLnUni99XD5vFU3Budam\n\tUEAKIzw0DcCBM4CtaxRFyJurBJ69o7Kve54bPwbg=","Reply-To":"kieran.bingham@ideasonboard.com","To":"=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>","Cc":"LibCamera Devel <libcamera-devel@lists.libcamera.org>","References":"<20190530133849.17366-1-kieran.bingham@ideasonboard.com>\n\t<20190610112632.GA1362@bigcity.dyn.berto.se>","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAkAEEwEKACoCGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEFAlnDk/gFCQeA/YsACgkQoR5GchCkYf3X5w/9EaZ7\n\tcnUcT6dxjxrcmmMnfFPoQA1iQXr/MXQJBjFWfxRUWYzjvUJb2D/FpA8FY7y+vksoJP7pWDL7\n\tQTbksdwzagUEk7CU45iLWL/CZ/knYhj1I/+5LSLFmvZ/5Gf5xn2ZCsmg7C0MdW/GbJ8IjWA8\n\t/LKJSEYH8tefoiG6+9xSNp1p0Gesu3vhje/GdGX4wDsfAxx1rIYDYVoX4bDM+uBUQh7sQox/\n\tR1bS0AaVJzPNcjeC14MS226mQRUaUPc9250aj44WmDfcg44/kMsoLFEmQo2II9aOlxUDJ+x1\n\txohGbh9mgBoVawMO3RMBihcEjo/8ytW6v7xSF+xP4Oc+HOn7qebAkxhSWcRxQVaQYw3S9iZz\n\t2iA09AXAkbvPKuMSXi4uau5daXStfBnmOfalG0j+9Y6hOFjz5j0XzaoF6Pln0jisDtWltYhP\n\tX9LjFVhhLkTzPZB/xOeWGmsG4gv2V2ExbU3uAmb7t1VSD9+IO3Km4FtnYOKBWlxwEd8qOFpS\n\tjEqMXURKOiJvnw3OXe9MqG19XdeENA1KyhK5rqjpwdvPGfSn2V+SlsdJA0DFsobUScD9qXQw\n\tOvhapHe3XboK2+Rd7L+g/9Ud7ZKLQHAsMBXOVJbufA1AT+IaOt0ugMcFkAR5UbBg5+dZUYJj\n\t1QbPQcGmM3wfvuaWV5+SlJ+WeKIb8ta5Ag0EVgT9ZgEQAM4o5G/kmruIQJ3K9SYzmPishRHV\n\tDcUcvoakyXSX2mIoccmo9BHtD9MxIt+QmxOpYFNFM7YofX4lG0ld8H7FqoNVLd/+a0yru5Cx\n\tadeZBe3qr1eLns10Q90LuMo7/6zJhCW2w+HE7xgmCHejAwuNe3+7yt4QmwlSGUqdxl8cgtS1\n\tPlEK93xXDsgsJj/bw1EfSVdAUqhx8UQ3aVFxNug5OpoX9FdWJLKROUrfNeBE16RLrNrq2ROc\n\tiSFETpVjyC/oZtzRFnwD9Or7EFMi76/xrWzk+/b15RJ9WrpXGMrttHUUcYZEOoiC2lEXMSAF\n\tSSSj4vHbKDJ0vKQdEFtdgB1roqzxdIOg4rlHz5qwOTynueiBpaZI3PHDudZSMR5Fk6QjFooE\n\tXTw3sSl/km/lvUFiv9CYyHOLdygWohvDuMkV/Jpdkfq8XwFSjOle+vT/4VqERnYFDIGBxaRx\n\tkoBLfNDiiuR3lD8tnJ4A1F88K6ojOUs+jndKsOaQpDZV6iNFv8IaNIklTPvPkZsmNDhJMRHH\n\tIu60S7BpzNeQeT4yyY4dX9lC2JL/LOEpw8DGf5BNOP1KgjCvyp1/KcFxDAo89IeqljaRsCdP\n\t7WCIECWYem6pLwaw6IAL7oX+tEqIMPph/G/jwZcdS6Hkyt/esHPuHNwX4guqTbVEuRqbDzDI\n\t2DJO5FbxABEBAAGJAiUEGAEKAA8CGwwFAlnDlGsFCQeA/gIACgkQoR5GchCkYf1yYRAAq+Yo\n\tnbf9DGdK1kTAm2RTFg+w9oOp2Xjqfhds2PAhFFvrHQg1XfQR/UF/SjeUmaOmLSczM0s6XMeO\n\tVcE77UFtJ/+hLo4PRFKm5X1Pcar6g5m4xGqa+Xfzi9tRkwC29KMCoQOag1BhHChgqYaUH3yo\n\tUzaPwT/fY75iVI+yD0ih/e6j8qYvP8pvGwMQfrmN9YB0zB39YzCSdaUaNrWGD3iCBxg6lwSO\n\tLKeRhxxfiXCIYEf3vwOsP3YMx2JkD5doseXmWBGW1U0T/oJF+DVfKB6mv5UfsTzpVhJRgee7\n\t4jkjqFq4qsUGxcvF2xtRkfHFpZDbRgRlVmiWkqDkT4qMA+4q1y/dWwshSKi/uwVZNycuLsz+\n\t+OD8xPNCsMTqeUkAKfbD8xW4LCay3r/dD2ckoxRxtMD9eOAyu5wYzo/ydIPTh1QEj9SYyvp8\n\tO0g6CpxEwyHUQtF5oh15O018z3ZLztFJKR3RD42VKVsrnNDKnoY0f4U0z7eJv2NeF8xHMuiU\n\tRCIzqxX1GVYaNkKTnb/Qja8hnYnkUzY1Lc+OtwiGmXTwYsPZjjAaDX35J/RSKAoy5wGo/YFA\n\tJxB1gWThL4kOTbsqqXj9GLcyOImkW0lJGGR3o/fV91Zh63S5TKnf2YGGGzxki+ADdxVQAm+Q\n\tsbsRB8KNNvVXBOVNwko86rQqF9drZuw=","Organization":"Ideas on Board","Message-ID":"<19d914d5-62d5-4f45-c23a-2810da6a083f@ideasonboard.com>","Date":"Mon, 10 Jun 2019 12:30:31 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.7.0","MIME-Version":"1.0","In-Reply-To":"<20190610112632.GA1362@bigcity.dyn.berto.se>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH] test: camera: Fix initialisation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Mon, 10 Jun 2019 11:30:35 -0000"}}]