[{"id":18639,"web_url":"https://patchwork.libcamera.org/comment/18639/","msgid":"","date":"2021-08-09T17:05:34","subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: Fix bcm2835-isp\n\tinclusion type.","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Mon, Aug 09, 2021 at 05:57:25PM +0100, Kieran Bingham wrote:\n> The bcm2835-isp.h is included with quotes rather than\n> angle brackets.\n> \n> Quoted includes is reserved for internal includes, while the\n> linux/bcm2835-isp.h header is exported from the Linux kernel.\n> \n> Fix the inclusion type.\n> \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/ipa/raspberrypi/controller/rpi/agc.cpp | 2 +-\n> src/ipa/raspberrypi/controller/rpi/lux.cpp | 2 +-\n> 2 files changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/ipa/raspberrypi/controller/rpi/agc.cpp b/src/ipa/raspberrypi/controller/rpi/agc.cpp\n> index 1cfdd3bb0f62..289c1fcee289 100644\n> --- a/src/ipa/raspberrypi/controller/rpi/agc.cpp\n> +++ b/src/ipa/raspberrypi/controller/rpi/agc.cpp\n> @@ -7,7 +7,7 @@\n> \n> #include \n> \n> -#include \"linux/bcm2835-isp.h\"\n> +#include \n> \n> #include \n> \n> diff --git a/src/ipa/raspberrypi/controller/rpi/lux.cpp b/src/ipa/raspberrypi/controller/rpi/lux.cpp\n> index 6367b17dc7f4..f77e9140ac10 100644\n> --- a/src/ipa/raspberrypi/controller/rpi/lux.cpp\n> +++ b/src/ipa/raspberrypi/controller/rpi/lux.cpp\n> @@ -6,7 +6,7 @@\n> */\n> #include \n> \n> -#include \"linux/bcm2835-isp.h\"\n> +#include \n> \n> #include \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 30021C3240\n\tfor ;\n\tMon, 9 Aug 2021 17:05:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9E6E168826;\n\tMon, 9 Aug 2021 19:05:37 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 66A0260269\n\tfor ;\n\tMon, 9 Aug 2021 19:05:36 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CD142466;\n\tMon, 9 Aug 2021 19:05:35 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"JldkQcL9\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1628528736;\n\tbh=a9IDsJwobt1LlX+A/weREkaeiKyNKZqTNXApSsrIZrc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=JldkQcL9a0U7aTJXW/RRMP8zZxW85rq5AGN6C0RajWLrrTV21ob7tZQCpwMvxfIoU\n\tOUNhY2miiIajDVUpO9TVZECDR8ltTqU9naa4r1osBVwG5Yb8R07UsodtNikNN2zIDZ\n\t1hDuHvmpLydwsKJfl00qT9QacMPzWm34JQccSmTE=","Date":"Mon, 9 Aug 2021 20:05:34 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20210809165725.1916137-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210809165725.1916137-1-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: Fix bcm2835-isp\n\tinclusion type.","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]