[{"id":18647,"web_url":"https://patchwork.libcamera.org/comment/18647/","msgid":"","date":"2021-08-10T01:25:36","subject":"Re: [libcamera-devel] [PATCH] libcamera: frame_buffer: Print errno\n\ton mmap() failure","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Umang,\n\nThank you for the patch.\n\nOn Mon, Aug 09, 2021 at 09:34:45PM +0530, Umang Jain wrote:\n> In mmap() error handling path, errno is stored but never printed\n> in the error log. Print it.\n\nIt's not a bug as such, but it can indeed be useful for debugging.\n\n> Signed-off-by: Umang Jain \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/framebuffer.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/framebuffer.cpp b/src/libcamera/framebuffer.cpp\n> index 41e6e68f..280f64c6 100644\n> --- a/src/libcamera/framebuffer.cpp\n> +++ b/src/libcamera/framebuffer.cpp\n> @@ -388,7 +388,8 @@ MappedFrameBuffer::MappedFrameBuffer(const FrameBuffer *buffer, int flags)\n> \t\t\t\t MAP_SHARED, plane.fd.fd(), 0);\n> \t\tif (address == MAP_FAILED) {\n> \t\t\terror_ = -errno;\n> -\t\t\tLOG(Buffer, Error) << \"Failed to mmap plane\";\n> +\t\t\tLOG(Buffer, Error) << \"Failed to mmap plane: \"\n> +\t\t\t\t\t << strerror(-error_);\n> \t\t\tbreak;\n> \t\t}\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B417BC3240\n\tfor ;\n\tTue, 10 Aug 2021 01:25:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1286068826;\n\tTue, 10 Aug 2021 03:25:40 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 41042687EB\n\tfor ;\n\tTue, 10 Aug 2021 03:25:38 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B46B33F0;\n\tTue, 10 Aug 2021 03:25:37 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Hnr4PkPp\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1628558737;\n\tbh=ngUDDiTPpOGMGlJM4HuQURIRO8Gq8H7pPTAIIHaM19Y=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Hnr4PkPpoJ9rs2S3IjWhFO6rlJp4VagcZGdbAlmSD1auq7rsy+ag5m2gy/XvWlRA3\n\twRri3trJZXP8Ie3TriRlHZ1VYG9UpC6jXOKbOkyzusjwrusLdnaNj7iQdUvr3Dowls\n\tp7xjdpNT1qBARC/DwN2nTrEyTF1PEcDsFaSHwU9Y=","Date":"Tue, 10 Aug 2021 04:25:36 +0300","From":"Laurent Pinchart ","To":"Umang Jain ","Message-ID":"","References":"<20210809160445.179306-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210809160445.179306-1-umang.jain@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: frame_buffer: Print errno\n\ton mmap() failure","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":18655,"web_url":"https://patchwork.libcamera.org/comment/18655/","msgid":"<20210810045509.GR2167@pyrite.rasen.tech>","date":"2021-08-10T04:55:09","subject":"Re: [libcamera-devel] [PATCH] libcamera: frame_buffer: Print errno\n\ton mmap() failure","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Umang,\n\nOn Mon, Aug 09, 2021 at 09:34:45PM +0530, Umang Jain wrote:\n> In mmap() error handling path, errno is stored but never printed\n> in the error log. Print it.\n> \n> Signed-off-by: Umang Jain \n\nReviewed-by: Paul Elder \n\n> ---\n> src/libcamera/framebuffer.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/framebuffer.cpp b/src/libcamera/framebuffer.cpp\n> index 41e6e68f..280f64c6 100644\n> --- a/src/libcamera/framebuffer.cpp\n> +++ b/src/libcamera/framebuffer.cpp\n> @@ -388,7 +388,8 @@ MappedFrameBuffer::MappedFrameBuffer(const FrameBuffer *buffer, int flags)\n> \t\t\t\t MAP_SHARED, plane.fd.fd(), 0);\n> \t\tif (address == MAP_FAILED) {\n> \t\t\terror_ = -errno;\n> -\t\t\tLOG(Buffer, Error) << \"Failed to mmap plane\";\n> +\t\t\tLOG(Buffer, Error) << \"Failed to mmap plane: \"\n> +\t\t\t\t\t << strerror(-error_);\n> \t\t\tbreak;\n> \t\t}\n> \n> -- \n> 2.31.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 58D07C3240\n\tfor ;\n\tTue, 10 Aug 2021 04:55:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A7591687FA;\n\tTue, 10 Aug 2021 06:55:19 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3D1F660262\n\tfor ;\n\tTue, 10 Aug 2021 06:55:18 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B63E13F0;\n\tTue, 10 Aug 2021 06:55:16 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pJwr3Ktq\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1628571317;\n\tbh=S37fJQrqs8hXCfPqheC5XgMKZMI+JF1mwhZ3UyjNH5M=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=pJwr3KtqDqdgyK+f1hG/nps7ra4TrXUE7mIyhkefuh38DiGiBRTB7sWJBCcawhdMK\n\toYw71KxnY8b3ydXPQkIRawFq+/GoBlpCVW3jAgkc3q7eKlyZuhYUXiJOWVR8/yITmy\n\t4yMnJMDL5HGXHffuh+KnGB/KMoWvrEZ3OxiKwiks=","Date":"Tue, 10 Aug 2021 13:55:09 +0900","From":"paul.elder@ideasonboard.com","To":"Umang Jain ","Message-ID":"<20210810045509.GR2167@pyrite.rasen.tech>","References":"<20210809160445.179306-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20210809160445.179306-1-umang.jain@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: frame_buffer: Print errno\n\ton mmap() failure","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":18664,"web_url":"https://patchwork.libcamera.org/comment/18664/","msgid":"<38e468b5-c205-166d-82c3-0dbd0a22230c@ideasonboard.com>","date":"2021-08-10T08:29:14","subject":"Re: [libcamera-devel] [PATCH] libcamera: frame_buffer: Print errno\n\ton mmap() failure","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Umang,\n\nOn 09/08/2021 17:04, Umang Jain wrote:\n> In mmap() error handling path, errno is stored but never printed\n> in the error log. Print it.\n\nGood spot...\n\n> Signed-off-by: Umang Jain \n> ---\n> src/libcamera/framebuffer.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/framebuffer.cpp b/src/libcamera/framebuffer.cpp\n> index 41e6e68f..280f64c6 100644\n> --- a/src/libcamera/framebuffer.cpp\n> +++ b/src/libcamera/framebuffer.cpp\n> @@ -388,7 +388,8 @@ MappedFrameBuffer::MappedFrameBuffer(const FrameBuffer *buffer, int flags)\n> \t\t\t\t MAP_SHARED, plane.fd.fd(), 0);\n> \t\tif (address == MAP_FAILED) {\n> \t\t\terror_ = -errno;\n> -\t\t\tLOG(Buffer, Error) << \"Failed to mmap plane\";\n> +\t\t\tLOG(Buffer, Error) << \"Failed to mmap plane: \"\n> +\t\t\t\t\t << strerror(-error_);\n\nShould we say which plane?\n\nIt may not matter - as it's just a fairly bad failure if we hit this.\n\nReviewed-by: Kieran Bingham \n\n> \t\t\tbreak;\n> \t\t}\n> \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 428FDC3240\n\tfor ;\n\tTue, 10 Aug 2021 08:29:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9F7AD6884F;\n\tTue, 10 Aug 2021 10:29:19 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1093A687DE\n\tfor ;\n\tTue, 10 Aug 2021 10:29:18 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4E536EE;\n\tTue, 10 Aug 2021 10:29:17 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"J3GgJOto\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1628584157;\n\tbh=gT8HjVEWq5JW6U4/EiYhlQ2aECGhIbKDDOkz/pzUKio=;\n\th=To:References:From:Subject:Date:In-Reply-To:From;\n\tb=J3GgJOtoEtGyfLSBlaNMhkhQ3rrMiAjkJxi3rR/f/OY8mu8Rh5ziOb+C62rH7/LCA\n\tDoX6XZEZKTWW2V5uL80oXp3HnQGownAQv7wIfQsG+AJcaJxVyANTNRvtV+TSV0aB9G\n\tjcQlCaV/W/GLt5uetZRnFp2sEtG+mGQ+Jrj0BhYQ=","To":"Umang Jain ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210809160445.179306-1-umang.jain@ideasonboard.com>","From":"Kieran Bingham ","Message-ID":"<38e468b5-c205-166d-82c3-0dbd0a22230c@ideasonboard.com>","Date":"Tue, 10 Aug 2021 09:29:14 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.11.0","MIME-Version":"1.0","In-Reply-To":"<20210809160445.179306-1-umang.jain@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH] libcamera: frame_buffer: Print errno\n\ton mmap() failure","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]