[{"id":18624,"web_url":"https://patchwork.libcamera.org/comment/18624/","msgid":"","date":"2021-08-09T14:15:31","subject":"Re: [libcamera-devel] [PATCH v3 1/3] src: Remove all unused\n\tsys/mman.h inclusions","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Mon, Aug 09, 2021 at 02:29:27PM +0100, Kieran Bingham wrote:\n> Remove leftover inclusions of the sys/mman header file.\n> \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/android/camera_device.cpp | 1 -\n> src/libcamera/ipa_module.cpp | 1 -\n> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 1 -\n> src/libcamera/v4l2_videodevice.cpp | 1 -\n> src/v4l2/v4l2_camera_proxy.h | 1 -\n> src/v4l2/v4l2_compat_manager.h | 1 -\n> 6 files changed, 6 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 3266c495d0ca..59b37bc864b5 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -12,7 +12,6 @@\n> \n> #include \n> #include \n> -#include \n> #include \n> #include \n> \n> diff --git a/src/libcamera/ipa_module.cpp b/src/libcamera/ipa_module.cpp\n> index 7c52ad8d5796..908f2e07bd3f 100644\n> --- a/src/libcamera/ipa_module.cpp\n> +++ b/src/libcamera/ipa_module.cpp\n> @@ -16,7 +16,6 @@\n> #include \n> #include \n> #include \n> -#include \n> #include \n> #include \n> #include \n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index 0bab3bedd402..2e8774ae360d 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -10,7 +10,6 @@\n> #include \n> #include \n> #include \n> -#include \n> #include \n> \n> #include \n> diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\n> index da2af6a13dfb..cddabad753e1 100644\n> --- a/src/libcamera/v4l2_videodevice.cpp\n> +++ b/src/libcamera/v4l2_videodevice.cpp\n> @@ -13,7 +13,6 @@\n> #include \n> #include \n> #include \n> -#include \n> #include \n> #include \n> #include \n> diff --git a/src/v4l2/v4l2_camera_proxy.h b/src/v4l2/v4l2_camera_proxy.h\n> index 92a79abb9e21..f1a8b61c5eac 100644\n> --- a/src/v4l2/v4l2_camera_proxy.h\n> +++ b/src/v4l2/v4l2_camera_proxy.h\n> @@ -12,7 +12,6 @@\n> #include \n> #include \n> #include \n> -#include \n> #include \n> #include \n> \n> diff --git a/src/v4l2/v4l2_compat_manager.h b/src/v4l2/v4l2_compat_manager.h\n> index bc548ab2a8bd..1ec46162211d 100644\n> --- a/src/v4l2/v4l2_compat_manager.h\n> +++ b/src/v4l2/v4l2_compat_manager.h\n> @@ -11,7 +11,6 @@\n> #include \n> #include \n> #include \n> -#include \n> #include \n> #include \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4CA7CBD87D\n\tfor ;\n\tMon, 9 Aug 2021 14:15:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AFC8A68826;\n\tMon, 9 Aug 2021 16:15:34 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4AF5E60269\n\tfor ;\n\tMon, 9 Aug 2021 16:15:33 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BB178DD;\n\tMon, 9 Aug 2021 16:15:32 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"UuvvDBiQ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1628518532;\n\tbh=/i4M51czSRrPhzNrMziEOvZh+4SijX8xS7PKpg2DyT0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=UuvvDBiQy0fpHjWDEkp/RVp1Fwtlh5CX4dRX8Iul5lpzULeGke7sQuX/DVeNAGO24\n\t77Xu6IIWjfPB06lX2aWK/la4++fLqvzeS2z+8Z/oIr2sZpHBkIokTZjtLbjBDdB4yq\n\tpfPrfpXQSsONxAnXQl89Ot+rHTiS4TDGluyMoboM=","Date":"Mon, 9 Aug 2021 17:15:31 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20210809132929.1824114-1-kieran.bingham@ideasonboard.com>\n\t<20210809132929.1824114-2-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210809132929.1824114-2-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3 1/3] src: Remove all unused\n\tsys/mman.h inclusions","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":18650,"web_url":"https://patchwork.libcamera.org/comment/18650/","msgid":"","date":"2021-08-10T02:40:51","subject":"Re: [libcamera-devel] [PATCH v3 1/3] src: Remove all unused\n\tsys/mman.h inclusions","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Hi Kieran, thank you for the patch.\n\nOn Mon, Aug 9, 2021 at 11:15 PM Laurent Pinchart\n wrote:\n>\n> Hi Kieran,\n>\n> Thank you for the patch.\n>\n> On Mon, Aug 09, 2021 at 02:29:27PM +0100, Kieran Bingham wrote:\n> > Remove leftover inclusions of the sys/mman header file.\n> >\n> > Signed-off-by: Kieran Bingham \n>\n> Reviewed-by: Laurent Pinchart \n>\n\nReviewed-by: Hirokazu Honda \n\n> > ---\n> > src/android/camera_device.cpp | 1 -\n> > src/libcamera/ipa_module.cpp | 1 -\n> > src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 1 -\n> > src/libcamera/v4l2_videodevice.cpp | 1 -\n> > src/v4l2/v4l2_camera_proxy.h | 1 -\n> > src/v4l2/v4l2_compat_manager.h | 1 -\n> > 6 files changed, 6 deletions(-)\n> >\n> > diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> > index 3266c495d0ca..59b37bc864b5 100644\n> > --- a/src/android/camera_device.cpp\n> > +++ b/src/android/camera_device.cpp\n> > @@ -12,7 +12,6 @@\n> >\n> > #include \n> > #include \n> > -#include \n> > #include \n> > #include \n> >\n> > diff --git a/src/libcamera/ipa_module.cpp b/src/libcamera/ipa_module.cpp\n> > index 7c52ad8d5796..908f2e07bd3f 100644\n> > --- a/src/libcamera/ipa_module.cpp\n> > +++ b/src/libcamera/ipa_module.cpp\n> > @@ -16,7 +16,6 @@\n> > #include \n> > #include \n> > #include \n> > -#include \n> > #include \n> > #include \n> > #include \n> > diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> > index 0bab3bedd402..2e8774ae360d 100644\n> > --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> > +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> > @@ -10,7 +10,6 @@\n> > #include \n> > #include \n> > #include \n> > -#include \n> > #include \n> >\n> > #include \n> > diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\n> > index da2af6a13dfb..cddabad753e1 100644\n> > --- a/src/libcamera/v4l2_videodevice.cpp\n> > +++ b/src/libcamera/v4l2_videodevice.cpp\n> > @@ -13,7 +13,6 @@\n> > #include \n> > #include \n> > #include \n> > -#include \n> > #include \n> > #include \n> > #include \n> > diff --git a/src/v4l2/v4l2_camera_proxy.h b/src/v4l2/v4l2_camera_proxy.h\n> > index 92a79abb9e21..f1a8b61c5eac 100644\n> > --- a/src/v4l2/v4l2_camera_proxy.h\n> > +++ b/src/v4l2/v4l2_camera_proxy.h\n> > @@ -12,7 +12,6 @@\n> > #include \n> > #include \n> > #include \n> > -#include \n> > #include \n> > #include \n> >\n> > diff --git a/src/v4l2/v4l2_compat_manager.h b/src/v4l2/v4l2_compat_manager.h\n> > index bc548ab2a8bd..1ec46162211d 100644\n> > --- a/src/v4l2/v4l2_compat_manager.h\n> > +++ b/src/v4l2/v4l2_compat_manager.h\n> > @@ -11,7 +11,6 @@\n> > #include \n> > #include \n> > #include \n> > -#include \n> > #include \n> > #include \n> >\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 09033C3240\n\tfor ;\n\tTue, 10 Aug 2021 02:41:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5812B68826;\n\tTue, 10 Aug 2021 04:41:03 +0200 (CEST)","from mail-ed1-x533.google.com (mail-ed1-x533.google.com\n\t[IPv6:2a00:1450:4864:20::533])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 75565687EB\n\tfor ;\n\tTue, 10 Aug 2021 04:41:02 +0200 (CEST)","by mail-ed1-x533.google.com with SMTP id x14so5328074edr.12\n\tfor ;\n\tMon, 09 Aug 2021 19:41:02 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"HcaQIpFX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=c3lDNiA5S8Ot2jOPCqHgKQNYZ1FGLz95swptHTMS3/Y=;\n\tb=HcaQIpFXWZlyIUUMV24tK544N9ZAP4dJA3qWw59zTzjtE8E79RIzcdG/aXaSbC5Aas\n\thuIis5GIzBiXUTfkVEMbdD48GzZ6A/MgXgXJ2jov4MYH4HTv9A1mNHKvGZ5niB76fVwa\n\tI/vg1+oe33EdSngF9dxSJrmjmkfl9do2GgZFI=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=c3lDNiA5S8Ot2jOPCqHgKQNYZ1FGLz95swptHTMS3/Y=;\n\tb=VYMvEbMX3WCi6q/8d3vggAfs7n45lXN3zJoqVu7HywS1MylJWAv4WUO6fQ0BaNTz0B\n\to4AAPkc0RS7gAeOVAJYV9DP5qhbWI2E1cxH4+uSdDQBboysjg2KzYeTneyZproYSE7kJ\n\tfTuQBTfXaSLUMndQ5eZXuphuJiw/+PDW8rZgc2ncmP0hKuSrVJ8AUe+lYY0SUGamTsBV\n\tiOcGmpHJc/bNCLTC4Ejans6LZhvWGcCCjHa2E5GVTnPXztLTKqnFv1uQ4tHpF8z0Vtiw\n\tE/GpYMnPkuW3sKrn0AHqEeP3nxeDGZimqGhNigJJgrp/pvLV+TRBhXu/l7ow10sFAHhp\n\tb8BA==","X-Gm-Message-State":"AOAM533m1iZGNO2H+Nn/LHO4GPmGYAXd+oArzvjGrH63mF2bywPWWJzk\n\tB1+tMww6Ph/nmyBxJ2OoFDTMDYFPrB40DwZVYLXCLutOLiQ=","X-Google-Smtp-Source":"ABdhPJxYoVYughNHXBQ7SEl+i26hBT8jQsGzsN9owqdMD0MzTEwOU8fWIwSaEt2fHSaOylomb+uYf6R0CaYFf87f660=","X-Received":"by 2002:aa7:c794:: with SMTP id\n\tn20mr1984820eds.244.1628563262046; \n\tMon, 09 Aug 2021 19:41:02 -0700 (PDT)","MIME-Version":"1.0","References":"<20210809132929.1824114-1-kieran.bingham@ideasonboard.com>\n\t<20210809132929.1824114-2-kieran.bingham@ideasonboard.com>\n\t","In-Reply-To":"","From":"Hirokazu Honda ","Date":"Tue, 10 Aug 2021 11:40:51 +0900","Message-ID":"","To":"Laurent Pinchart ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH v3 1/3] src: Remove all unused\n\tsys/mman.h inclusions","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]