[{"id":1720,"web_url":"https://patchwork.libcamera.org/comment/1720/","msgid":"<20190528162526.GJ14336@pendragon.ideasonboard.com>","date":"2019-05-28T16:25:26","subject":"Re: [libcamera-devel] [PATCH 7/8] libcamera: test: remove test IPA\n\tand use dummy IPA instead","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Mon, May 27, 2019 at 06:35:39PM -0400, Paul Elder wrote:\n> Use the dummy IPA for testing/sample IPA instead of the earlier test\n> IPA. Remove the test IPA, and update tests and meson accordingly.\n\nNice, I like this. Please disregard my comment about using more\nrealistic names for the test module info in an earlier patch.\n\n> Signed-off-by: Paul Elder \n> ---\n> test/ipa/ipa_test.cpp | 8 ++++----\n> test/ipa/meson.build | 10 ----------\n> 2 files changed, 4 insertions(+), 14 deletions(-)\n> \n> diff --git a/test/ipa/ipa_test.cpp b/test/ipa/ipa_test.cpp\n> index f50880e..53e3a6e 100644\n> --- a/test/ipa/ipa_test.cpp\n> +++ b/test/ipa/ipa_test.cpp\n> @@ -82,12 +82,12 @@ protected:\n> \n> \t\tconst struct IPAModuleInfo testInfo = {\n> \t\t\t1,\n> -\t\t\t0, 9001,\n> -\t\t\t\"bleep\",\n> -\t\t\t\"It's over nine thousand!\",\n> +\t\t\t0, 1,\n> +\t\t\t\"PipelineHandlerVimc\",\n> +\t\t\t\"Dummy IPA for Vimc\",\n> \t\t};\n> \n> -\t\tcount += runTest(\"test/ipa/ipa-dummy-cpp.so\", testInfo);\n> +\t\tcount += runTest(\"src/ipa/ipa_dummy.so\", testInfo);\n> \n> \t\tif (count < 0)\n> \t\t\treturn TestFail;\n> diff --git a/test/ipa/meson.build b/test/ipa/meson.build\n> index 08ee95c..bca39fa 100644\n> --- a/test/ipa/meson.build\n> +++ b/test/ipa/meson.build\n> @@ -1,13 +1,3 @@\n> -ipa_modules_sources = [\n> - ['ipa-dummy-cpp', 'shared_test.cpp'],\n> -]\n> -\n> -foreach m : ipa_modules_sources\n> - shared_library(m, name_prefix : '',\n> - dependencies : libcamera_dep,\n> - include_directories : test_includes_public)\n> -endforeach\n> -\n> ipa_test = [\n> ['ipa_test', 'ipa_test.cpp'],\n> ]","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4ED6E600EA\n\tfor ;\n\tTue, 28 May 2019 18:25:46 +0200 (CEST)","from pendragon.ideasonboard.com (85-76-139-52-nat.elisa-mobile.fi\n\t[85.76.139.52])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 63BB8D85;\n\tTue, 28 May 2019 18:25:45 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1559060746;\n\tbh=VQg670eTIS2fPHY2Nz/8R+n3rt5PVJxOoT+kUCJBpv8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=d6onSeoe6Cf/raYCRwndya3xJbw0Kkm1Dyfss0mnyhJl64wu2LX93Kdah6ZS95gFV\n\tqjWq5I4kDPL062xkWWJ55wrmX0zh+rUTIH1wbmdUCV8KtUgIPsTAIxPGsjnckDJsX7\n\tHMY0kMEK0RxUg3pir5N+8ezoEXdidZ+2BNr0G7F4=","Date":"Tue, 28 May 2019 19:25:26 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190528162526.GJ14336@pendragon.ideasonboard.com>","References":"<20190527223540.21855-1-paul.elder@ideasonboard.com>\n\t<20190527223540.21855-8-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190527223540.21855-8-paul.elder@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 7/8] libcamera: test: remove test IPA\n\tand use dummy IPA instead","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 28 May 2019 16:25:46 -0000"}},{"id":1721,"web_url":"https://patchwork.libcamera.org/comment/1721/","msgid":"<20190528162607.GK14336@pendragon.ideasonboard.com>","date":"2019-05-28T16:26:07","subject":"Re: [libcamera-devel] [PATCH 7/8] libcamera: test: remove test IPA\n\tand use dummy IPA instead","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Tue, May 28, 2019 at 07:25:26PM +0300, Laurent Pinchart wrote:\n> Hi Paul,\n> \n> Thank you for the patch.\n> \n> On Mon, May 27, 2019 at 06:35:39PM -0400, Paul Elder wrote:\n> > Use the dummy IPA for testing/sample IPA instead of the earlier test\n> > IPA. Remove the test IPA, and update tests and meson accordingly.\n> \n> Nice, I like this. Please disregard my comment about using more\n> realistic names for the test module info in an earlier patch.\n\nAnd\n\nReviewed-by: Laurent Pinchart \n\n> > Signed-off-by: Paul Elder \n> > ---\n> > test/ipa/ipa_test.cpp | 8 ++++----\n> > test/ipa/meson.build | 10 ----------\n> > 2 files changed, 4 insertions(+), 14 deletions(-)\n> > \n> > diff --git a/test/ipa/ipa_test.cpp b/test/ipa/ipa_test.cpp\n> > index f50880e..53e3a6e 100644\n> > --- a/test/ipa/ipa_test.cpp\n> > +++ b/test/ipa/ipa_test.cpp\n> > @@ -82,12 +82,12 @@ protected:\n> > \n> > \t\tconst struct IPAModuleInfo testInfo = {\n> > \t\t\t1,\n> > -\t\t\t0, 9001,\n> > -\t\t\t\"bleep\",\n> > -\t\t\t\"It's over nine thousand!\",\n> > +\t\t\t0, 1,\n> > +\t\t\t\"PipelineHandlerVimc\",\n> > +\t\t\t\"Dummy IPA for Vimc\",\n> > \t\t};\n> > \n> > -\t\tcount += runTest(\"test/ipa/ipa-dummy-cpp.so\", testInfo);\n> > +\t\tcount += runTest(\"src/ipa/ipa_dummy.so\", testInfo);\n> > \n> > \t\tif (count < 0)\n> > \t\t\treturn TestFail;\n> > diff --git a/test/ipa/meson.build b/test/ipa/meson.build\n> > index 08ee95c..bca39fa 100644\n> > --- a/test/ipa/meson.build\n> > +++ b/test/ipa/meson.build\n> > @@ -1,13 +1,3 @@\n> > -ipa_modules_sources = [\n> > - ['ipa-dummy-cpp', 'shared_test.cpp'],\n> > -]\n> > -\n> > -foreach m : ipa_modules_sources\n> > - shared_library(m, name_prefix : '',\n> > - dependencies : libcamera_dep,\n> > - include_directories : test_includes_public)\n> > -endforeach\n> > -\n> > ipa_test = [\n> > ['ipa_test', 'ipa_test.cpp'],\n> > ]","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DD046600EA\n\tfor ;\n\tTue, 28 May 2019 18:26:39 +0200 (CEST)","from pendragon.ideasonboard.com (85-76-139-52-nat.elisa-mobile.fi\n\t[85.76.139.52])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4551ED85;\n\tTue, 28 May 2019 18:26:37 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1559060799;\n\tbh=/dFwuJDqFewlusD2dbzhyLf3AyRH5uV8mVQ48dxnUUI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=c1bvUGWh6RYPGtwRSq3zNo0wq6Juw/2aIfPWYe2gEenM5UC5lX0nuNrhJ9iX03oD5\n\t9+ZPNDx7WaNKkvbZa+9sLbz7JAOgRcsK7paaCbth2xqY/gyvlOEC3aLjBdxTnTU6x0\n\tbupX3MXnvDQW/3SkVHA/xN9CAhz4fVDIYPAlqmXY=","Date":"Tue, 28 May 2019 19:26:07 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190528162607.GK14336@pendragon.ideasonboard.com>","References":"<20190527223540.21855-1-paul.elder@ideasonboard.com>\n\t<20190527223540.21855-8-paul.elder@ideasonboard.com>\n\t<20190528162526.GJ14336@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190528162526.GJ14336@pendragon.ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 7/8] libcamera: test: remove test IPA\n\tand use dummy IPA instead","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 28 May 2019 16:26:40 -0000"}}]