[{"id":1719,"web_url":"https://patchwork.libcamera.org/comment/1719/","msgid":"<20190528162328.GI14336@pendragon.ideasonboard.com>","date":"2019-05-28T16:23:28","subject":"Re: [libcamera-devel] [PATCH 6/8] libcamera: ipa: add dummy IPA\n\timplementation","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Mon, May 27, 2019 at 06:35:38PM -0400, Paul Elder wrote:\n> Add a dummy IPA module.\n> \n> Signed-off-by: Paul Elder \n> ---\n> src/ipa/ipa_dummy.cpp | 38 ++++++++++++++++++++++++++++++++++++++\n> src/ipa/meson.build | 10 ++++++++++\n> src/meson.build | 1 +\n> 3 files changed, 49 insertions(+)\n> create mode 100644 src/ipa/ipa_dummy.cpp\n> create mode 100644 src/ipa/meson.build\n> \n> diff --git a/src/ipa/ipa_dummy.cpp b/src/ipa/ipa_dummy.cpp\n> new file mode 100644\n> index 0000000..e246b58\n> --- /dev/null\n> +++ b/src/ipa/ipa_dummy.cpp\n> @@ -0,0 +1,38 @@\n\nPlease add a copyright header.\n\n> +#include \n> +#include \n> +\n> +#include \n\nSame comment as before.\n\n> +\n> +namespace libcamera {\n> +\n> +class IPADummy : public IPAInterface\n> +{\n> +public:\n> +\tint init();\n> +};\n> +\n> +int IPADummy::init()\n> +{\n> +\tstd::cout << \"initializing dummy IPA!\" << std::endl;\n> +\treturn 0;\n\nWe'll need to provide a logging service to the IPA modules, but for now\nthis is OK.\n\n> +}\n> +\n> +/*\n> + * External IPA module interface\n> + */\n> +\n> +extern \"C\" {\n> +const struct libcamera::IPAModuleInfo ipaModuleInfo = {\n> +\t1,\n> +\t0, 1,\n> +\t\"PipelineHandlerVimc\",\n> +\t\"Dummy IPA for Vimc\",\n> +};\n> +\n> +IPAInterface *ipaCreate()\n> +{\n> +\treturn new IPADummy();\n> +}\n> +};\n> +\n> +}; /* namespace libcamera */\n> diff --git a/src/ipa/meson.build b/src/ipa/meson.build\n> new file mode 100644\n> index 0000000..1ed29eb\n> --- /dev/null\n> +++ b/src/ipa/meson.build\n> @@ -0,0 +1,10 @@\n> +ipa_dummy_sources = files([\n> + 'ipa_dummy.cpp',\n> +])\n> +\n> +ipa_dummy = shared_library('ipa_dummy',\n> + ipa_dummy_sources,\n> + name_prefix : '',\n> + include_directories : libcamera_includes,\n> + install : true,\n> + install_dir : join_paths(get_option('libdir'), 'libcamera'))\n> diff --git a/src/meson.build b/src/meson.build\n> index 4e41fd3..628e7a7 100644\n> --- a/src/meson.build\n> +++ b/src/meson.build\n> @@ -1,3 +1,4 @@\n> subdir('libcamera')\n> +subdir('ipa')\n> subdir('cam')\n> subdir('qcam')","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 85674600EA\n\tfor ;\n\tTue, 28 May 2019 18:23:49 +0200 (CEST)","from pendragon.ideasonboard.com (85-76-139-52-nat.elisa-mobile.fi\n\t[85.76.139.52])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A34D2D85;\n\tTue, 28 May 2019 18:23:48 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1559060629;\n\tbh=QIoTX/w3/JegVjS6YUeBXTqd6eQ0LuhRoFQ3e0bDf6I=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=RlTnV5zabSordql9t7GNG9z6GeIrXIqJT05HgtyK/709JwaFFrudcf/JeMYEFfsxB\n\tsKFBcGF3ODkTJygM9AB5HUnaYnAhQ5p8Didx4c2zhSUhH9ech/dMFe129RtGY1YZ/T\n\t/jS02yIZHDJ/toeE82cAD+OmgccqtFjQ/QCGBaNg=","Date":"Tue, 28 May 2019 19:23:28 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190528162328.GI14336@pendragon.ideasonboard.com>","References":"<20190527223540.21855-1-paul.elder@ideasonboard.com>\n\t<20190527223540.21855-7-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190527223540.21855-7-paul.elder@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 6/8] libcamera: ipa: add dummy IPA\n\timplementation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 28 May 2019 16:23:49 -0000"}}]