[{"id":18910,"web_url":"https://patchwork.libcamera.org/comment/18910/","msgid":"<20210818110041.fq4ctk753q2r6tv7@uno.localdomain>","date":"2021-08-18T11:00:41","subject":"Re: [libcamera-devel] [PATCH 2/3] android: camera_stream: Support\n\tPostProcessorYuv in CameraStream","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Hiro,\n\nOn Thu, Aug 05, 2021 at 10:45:29PM +0900, Hirokazu Honda wrote:\n> CameraStream creates PostProcessorYuv if the destination format\n> is NV12.\n>\n> Signed-off-by: Hirokazu Honda \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/android/camera_stream.cpp | 7 +++++++\n> 1 file changed, 7 insertions(+)\n>\n> diff --git a/src/android/camera_stream.cpp b/src/android/camera_stream.cpp\n> index 86263403..8c02cb43 100644\n> --- a/src/android/camera_stream.cpp\n> +++ b/src/android/camera_stream.cpp\n> @@ -11,6 +11,7 @@\n> #include \"camera_device.h\"\n> #include \"camera_metadata.h\"\n> #include \"jpeg/post_processor_jpeg.h\"\n> +#include \"yuv/post_processor_yuv.h\"\n>\n> #include \n>\n> @@ -65,6 +66,12 @@ int CameraStream::configure()\n> \t\tStreamConfiguration output = configuration();\n> \t\toutput.pixelFormat = outFormat;\n> \t\tswitch (outFormat) {\n> +\t\tcase formats::NV12:\n> +\t\t\tpostProcessor_ = std::make_unique();\n> +\t\t\toutput.size.width = camera3Stream_->width;\n> +\t\t\toutput.size.height = camera3Stream_->height;\n> +\t\t\tbreak;\n> +\n> \t\tcase formats::MJPEG:\n> \t\t\tpostProcessor_ = std::make_unique(cameraDevice_);\n> \t\t\tbreak;\n> --\n> 2.32.0.554.ge1b32706d8-goog\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E63F3BD87D\n\tfor ;\n\tWed, 18 Aug 2021 10:59:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4F67A688A3;\n\tWed, 18 Aug 2021 12:59:56 +0200 (CEST)","from relay11.mail.gandi.net (relay11.mail.gandi.net\n\t[217.70.178.231])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7F4576888A\n\tfor ;\n\tWed, 18 Aug 2021 12:59:54 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay11.mail.gandi.net (Postfix) with ESMTPSA id A7E67100008;\n\tWed, 18 Aug 2021 10:59:53 +0000 (UTC)"],"Date":"Wed, 18 Aug 2021 13:00:41 +0200","From":"Jacopo Mondi ","To":"Hirokazu Honda ","Message-ID":"<20210818110041.fq4ctk753q2r6tv7@uno.localdomain>","References":"<20210805134530.825065-1-hiroh@chromium.org>\n\t<20210805134530.825065-3-hiroh@chromium.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210805134530.825065-3-hiroh@chromium.org>","Subject":"Re: [libcamera-devel] [PATCH 2/3] android: camera_stream: Support\n\tPostProcessorYuv in CameraStream","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]