[{"id":18566,"web_url":"https://patchwork.libcamera.org/comment/18566/","msgid":"","date":"2021-08-05T11:03:28","subject":"Re: [libcamera-devel] [PATCH 2/2] android: mm: cros_camera_buffer:\n\tFix unused parameter","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Umang and Hiro,\n\nThank you for the patch.\n\nOn Thu, Aug 05, 2021 at 02:05:51PM +0530, Umang Jain wrote:\n> From: Hirokazu Honda \n> \n> cameraBuffer function in private constructor is unused.\n\ns/function/parameter/\n\n> Mark it as such.\n> \n> Fixes: 33dd4fab9d39(\"libcamera: base: class: Don't pass Extensible\n> \t\t pointer to Private constructor\")\n\nNo line wrap for tags.\n\n> Signed-off-by: Hirokazu Honda \n> Reviewed-by: Umang Jain \n> Signed-off-by: Umang Jain \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/android/mm/cros_camera_buffer.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/android/mm/cros_camera_buffer.cpp b/src/android/mm/cros_camera_buffer.cpp\n> index 437502fb..e8783ff8 100644\n> --- a/src/android/mm/cros_camera_buffer.cpp\n> +++ b/src/android/mm/cros_camera_buffer.cpp\n> @@ -44,7 +44,7 @@ private:\n> \t} mem;\n> };\n> \n> -CameraBuffer::Private::Private(CameraBuffer *cameraBuffer,\n> +CameraBuffer::Private::Private([[maybe_unused]] CameraBuffer *cameraBuffer,\n> \t\t\t buffer_handle_t camera3Buffer,\n> \t\t\t [[maybe_unused]] int flags)\n> \t: handle_(camera3Buffer), numPlanes_(0), valid_(false),","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 686B1C3237\n\tfor ;\n\tThu, 5 Aug 2021 11:03:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 21259687CF;\n\tThu, 5 Aug 2021 13:03:43 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 04E4E6026D\n\tfor ;\n\tThu, 5 Aug 2021 13:03:41 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9C52151D;\n\tThu, 5 Aug 2021 13:03:40 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"W1ccov/O\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1628161420;\n\tbh=OneqNhWpKsNEC4QLu1tAhQ9yi8pxiPkzS+ASb+pOnlo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=W1ccov/Oy1wk2VTZvN7ryPUKcU8MHC93uIC+Tc1vkkM6ki7wMf25cvqtR4VBb5YcM\n\ttYE/nlHW19AsWFKD3c3iXYYV03VhUH8/dL9S4UQfkg1D6DzwKa+QTdtME7XJ6ZuuiM\n\tc3bk4qxGlCf+Faqb0tkcILqzxZxNVq2/6H89nzVg=","Date":"Thu, 5 Aug 2021 14:03:28 +0300","From":"Laurent Pinchart ","To":"Umang Jain ","Message-ID":"","References":"<20210805083551.234027-1-umang.jain@ideasonboard.com>\n\t<20210805083551.234027-2-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210805083551.234027-2-umang.jain@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 2/2] android: mm: cros_camera_buffer:\n\tFix unused parameter","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":18593,"web_url":"https://patchwork.libcamera.org/comment/18593/","msgid":"","date":"2021-08-06T10:39:36","subject":"Re: [libcamera-devel] [PATCH 2/2] android: mm: cros_camera_buffer:\n\tFix unused parameter","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi All,\n\nOn 05/08/2021 12:03, Laurent Pinchart wrote:\n> Hi Umang and Hiro,\n> \n> Thank you for the patch.\n> \n> On Thu, Aug 05, 2021 at 02:05:51PM +0530, Umang Jain wrote:\n>> From: Hirokazu Honda \n>>\n>> cameraBuffer function in private constructor is unused.\n> \n> s/function/parameter/\n\nI just hit this too.\n\nSomehow we need to find a way to incorporate the chromeos build in some\ndaily/automated builds. :-S\n\nIt's just inconvenient because Cros is so big and a somewhat otherwise\nmoving target ... eek.\n\n\n>> Mark it as such.\n>>\n>> Fixes: 33dd4fab9d39(\"libcamera: base: class: Don't pass Extensible\n>> \t\t pointer to Private constructor\")\n> \n> No line wrap for tags.\n\nWith that\n\nReviewed-by: Kieran Bingham \n\n> \n>> Signed-off-by: Hirokazu Honda \n>> Reviewed-by: Umang Jain \n>> Signed-off-by: Umang Jain \n> \n> Reviewed-by: Laurent Pinchart \n> \n>> ---\n>> src/android/mm/cros_camera_buffer.cpp | 2 +-\n>> 1 file changed, 1 insertion(+), 1 deletion(-)\n>>\n>> diff --git a/src/android/mm/cros_camera_buffer.cpp b/src/android/mm/cros_camera_buffer.cpp\n>> index 437502fb..e8783ff8 100644\n>> --- a/src/android/mm/cros_camera_buffer.cpp\n>> +++ b/src/android/mm/cros_camera_buffer.cpp\n>> @@ -44,7 +44,7 @@ private:\n>> \t} mem;\n>> };\n>> \n>> -CameraBuffer::Private::Private(CameraBuffer *cameraBuffer,\n>> +CameraBuffer::Private::Private([[maybe_unused]] CameraBuffer *cameraBuffer,\n>> \t\t\t buffer_handle_t camera3Buffer,\n>> \t\t\t [[maybe_unused]] int flags)\n>> \t: handle_(camera3Buffer), numPlanes_(0), valid_(false),\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D52CABD87D\n\tfor ;\n\tFri, 6 Aug 2021 10:39:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4C66C68815;\n\tFri, 6 Aug 2021 12:39:41 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 34AA460266\n\tfor ;\n\tFri, 6 Aug 2021 12:39:40 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1D0FE4FB;\n\tFri, 6 Aug 2021 12:39:39 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"RP3W6twg\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1628246379;\n\tbh=kHt9YoVBBrlIWzC+zt1Pt8KxQS7Szf6OKxFYO3S7u/o=;\n\th=Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=RP3W6twgsaRaNgqvtLyWTaw31TJN04DNrxj4stgIWljuPqqUJNdBiHhU+PbgbFKzd\n\tkIfPlume15T1wnCQnCUWBcWgn4pelNNxoRxyUMaiXsOfK0OQyeX482goxkBBB9Xyj0\n\t8kFHu5nmMHeUfCbfxJ4d0RVvzVMyVQLhV4/6pXLY=","To":"Laurent Pinchart ,\n\tUmang Jain ","References":"<20210805083551.234027-1-umang.jain@ideasonboard.com>\n\t<20210805083551.234027-2-umang.jain@ideasonboard.com>\n\t","From":"Kieran Bingham ","Message-ID":"","Date":"Fri, 6 Aug 2021 11:39:36 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.11.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 2/2] android: mm: cros_camera_buffer:\n\tFix unused parameter","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]