[{"id":181,"web_url":"https://patchwork.libcamera.org/comment/181/","msgid":"<20190102113910.qzreuskkb5r2uz3d@uno.localdomain>","date":"2019-01-02T11:39:10","subject":"Re: [libcamera-devel] [PATCH] libcamera: media_device: Zero media\n\tgraph arrays when querying topology","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Wed, Jan 02, 2019 at 01:31:22PM +0200, Laurent Pinchart wrote:\n> This silences valgrind that otherwise warns about usage of uninitialized\n> values. While not strictly required as the kernel should fill the whole\n> arrays in MEDIA_IOC_G_TOPOLOGY, the extra cost, in a non-critical path,\n> is negligible compared to the ability to run without valgrind warnings.\n>\n> Signed-off-by: Laurent Pinchart \n> ---\n> src/libcamera/media_device.cpp | 8 ++++----\n> 1 file changed, 4 insertions(+), 4 deletions(-)\n>\n> diff --git a/src/libcamera/media_device.cpp b/src/libcamera/media_device.cpp\n> index 4ff9ffe1041d..cc307dac1c33 100644\n> --- a/src/libcamera/media_device.cpp\n> +++ b/src/libcamera/media_device.cpp\n> @@ -240,10 +240,10 @@ int MediaDevice::populate()\n> \t\tdelete[] pads;\n> \t\tdelete[] interfaces;\n>\n> -\t\tents = new media_v2_entity[topology.num_entities];\n> -\t\tlinks = new media_v2_link[topology.num_links];\n> -\t\tpads = new media_v2_pad[topology.num_pads];\n> -\t\tinterfaces = new media_v2_interface[topology.num_interfaces];\n> +\t\tents = new media_v2_entity[topology.num_entities]();\n> +\t\tlinks = new media_v2_link[topology.num_links]();\n> +\t\tpads = new media_v2_pad[topology.num_pads]();\n> +\t\tinterfaces = new media_v2_interface[topology.num_interfaces]();\n\nAh ups, I dropped this from Niklas' code... It is worth if it silences\nvalgring warnings...\n\nPlease push\nThanks\n j\n\n>\n> \t\tversion = topology.topology_version;\n> \t}\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 79EDC60B2F\n\tfor ;\n\tWed, 2 Jan 2019 12:39:06 +0100 (CET)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 0CDC64000C;\n\tWed, 2 Jan 2019 11:39:05 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Wed, 2 Jan 2019 12:39:10 +0100","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190102113910.qzreuskkb5r2uz3d@uno.localdomain>","References":"<20190102113122.12751-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"gb76cvzjonwwjhjc\"","Content-Disposition":"inline","In-Reply-To":"<20190102113122.12751-1-laurent.pinchart@ideasonboard.com>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH] libcamera: media_device: Zero media\n\tgraph arrays when querying topology","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 02 Jan 2019 11:39:06 -0000"}}]