[{"id":18559,"web_url":"https://patchwork.libcamera.org/comment/18559/","msgid":"","date":"2021-08-04T12:40:18","subject":"Re: [libcamera-devel] [PATCH] ipu3: Disallow raw only camera\n\tconfiguration","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Umang,\n\nThank you for the patch.\n\nOn Wed, Aug 04, 2021 at 04:56:03PM +0530, Umang Jain wrote:\n> Ideally to capture the raw frames, ImgU should not be required.\n> However, we do need to configure the IPA since, it shall setup\n\ns/since,/since/\n\n> the sensor controls (exposure, vblank and so on) for the capture.\n> One cannot simply configure the IPA, without the ImgU as the\n> parameters and statistics buffer passed to the IPA are actually\n> managed by the ImgU.\n> \n> Until we prepare and setup the ImgU to run an internal queue for\n> raw-only camera configuration, disallow this configuration and\n> report it as invalid.\n> \n> Signed-off-by: Umang Jain \n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 4 ++++\n> 1 file changed, 4 insertions(+)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 76c3bb3d..3e159279 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -248,6 +248,10 @@ CameraConfiguration::Status IPU3CameraConfiguration::validate()\n> \tif (rawCount > 1 || yuvCount > 2) {\n> \t\tLOG(IPU3, Debug) << \"Camera configuration not supported\";\n> \t\treturn Invalid;\n> +\t} else if (rawCount && !yuvCount) {\n\nThis needs a \\todo comment. Apart from that, I think it's fine.\n\n> +\t\tLOG(IPU3, Debug)\n> +\t\t\t<< \"Camera configuration cannot support raw-only streams\";\n> +\t\treturn Invalid;\n> \t}\n> \n> \t/*","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7885DC3232\n\tfor ;\n\tWed, 4 Aug 2021 12:40:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0390D68811;\n\tWed, 4 Aug 2021 14:40:32 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F0BDB6026E\n\tfor ;\n\tWed, 4 Aug 2021 14:40:30 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6015924F;\n\tWed, 4 Aug 2021 14:40:30 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"STXE9KL6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1628080830;\n\tbh=kmCFTnIjqrc7kNyDVYN5DlIKt2QggIgKVqDLW9MzeuM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=STXE9KL6M6s6e6qm1Z4sFKqP2hdoS5qB6VT975shibXCCOKhCHN6zMhcd4xRoa+lF\n\to66Ul+pEYdvCQGumpv6jw1heq7pZfZCnpppw50y2if+AGWhWjwy2VUV0Ocy+BofgfX\n\tlx/PNejnnAaEq6gyaNDAkyAafeYaDMQV11Xc4Gdo=","Date":"Wed, 4 Aug 2021 15:40:18 +0300","From":"Laurent Pinchart ","To":"Umang Jain ","Message-ID":"","References":"<20210804112603.152493-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210804112603.152493-1-umang.jain@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] ipu3: Disallow raw only camera\n\tconfiguration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]