[{"id":18552,"web_url":"https://patchwork.libcamera.org/comment/18552/","msgid":"<20210804112646.GK2167@pyrite.rasen.tech>","date":"2021-08-04T11:26:46","subject":"Re: [libcamera-devel] [PATCH] utils: ipc: Initialise ThreadProxy","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Wed, Aug 04, 2021 at 11:21:56AM +0100, Kieran Bingham wrote:\n> The ThreadProxy IPA template does not implement a constructor and the\n> default compiler generated constructor does not initialise the private\n> ipa_ pointer.\n> \n> Whilst this should not be expected to be used while uninitialised, it\n> does get caught by static analysis for every IPA module constructed, so\n> lets be clean and fix it.\n> \n> Reported-by: Coverity CID=350116\n> Reported-by: Coverity CID=350123\n> Reported-by: Coverity CID=350140\n> Reported-by: Coverity CID=350147\n\nOoh that's a lot of coverity fixes \\o/\n\n> Fixes: 7832e19a599e (\"utils: ipc: add templates for code generation for IPC mechanism\")\n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Paul Elder \n\n> ---\n> .../generators/libcamera_templates/module_ipa_proxy.h.tmpl | 5 +++++\n> 1 file changed, 5 insertions(+)\n> \n> diff --git a/utils/ipc/generators/libcamera_templates/module_ipa_proxy.h.tmpl b/utils/ipc/generators/libcamera_templates/module_ipa_proxy.h.tmpl\n> index ae168548492c..c222f5f204df 100644\n> --- a/utils/ipc/generators/libcamera_templates/module_ipa_proxy.h.tmpl\n> +++ b/utils/ipc/generators/libcamera_templates/module_ipa_proxy.h.tmpl\n> @@ -72,6 +72,11 @@ private:\n> \tclass ThreadProxy : public Object\n> \t{\n> \tpublic:\n> +\t\tThreadProxy()\n> +\t\t\t: ipa_(nullptr)\n> +\t\t{\n> +\t\t}\n> +\n> \t\tvoid setIPA({{interface_name}} *ipa)\n> \t\t{\n> \t\t\tipa_ = ipa;\n> -- \n> 2.30.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 80851C3235\n\tfor ;\n\tWed, 4 Aug 2021 11:26:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3F60668811;\n\tWed, 4 Aug 2021 13:26:54 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 788FB6026E\n\tfor ;\n\tWed, 4 Aug 2021 13:26:53 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3A37C24F;\n\tWed, 4 Aug 2021 13:26:51 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"NdNQsiEc\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1628076413;\n\tbh=XnNzsiS0jWOE8wbA4Y+wwCLVPZ8VvjCJ6hNzy7wxnUU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=NdNQsiEcWV6UK/G0dsNZo3aSnfT8TrQaflAPatekkFxNUjKq7+19VKsFrZ67BG1XA\n\tfraI2uy1n95xxmYZjsLYOPx+Dq22INOTmdHyesj8ALx/1RoUi1jfPNKNb4KHSkvNCA\n\tz4DM8o+BRnxuCkOiAfcLwun4GaJsCG8vY8c5cH2M=","Date":"Wed, 4 Aug 2021 20:26:46 +0900","From":"paul.elder@ideasonboard.com","To":"Kieran Bingham ","Message-ID":"<20210804112646.GK2167@pyrite.rasen.tech>","References":"<20210804102156.4636-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20210804102156.4636-1-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] utils: ipc: Initialise ThreadProxy","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":18553,"web_url":"https://patchwork.libcamera.org/comment/18553/","msgid":"","date":"2021-08-04T11:30:11","subject":"Re: [libcamera-devel] [PATCH] utils: ipc: Initialise ThreadProxy","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 04/08/2021 12:26, paul.elder@ideasonboard.com wrote:\n> Hi Kieran,\n> \n> On Wed, Aug 04, 2021 at 11:21:56AM +0100, Kieran Bingham wrote:\n>> The ThreadProxy IPA template does not implement a constructor and the\n>> default compiler generated constructor does not initialise the private\n>> ipa_ pointer.\n>>\n>> Whilst this should not be expected to be used while uninitialised, it\n>> does get caught by static analysis for every IPA module constructed, so\n>> lets be clean and fix it.\n>>\n>> Reported-by: Coverity CID=350116\n>> Reported-by: Coverity CID=350123\n>> Reported-by: Coverity CID=350140\n>> Reported-by: Coverity CID=350147\n> \n> Ooh that's a lot of coverity fixes \\o/\n\nOne for each proxy that gets constructed ;-)\n\nI made this patch some time ago and saw it in my branch and must have\nforgotten to send it out - so here it is ;-)\n\n> \n>> Fixes: 7832e19a599e (\"utils: ipc: add templates for code generation for IPC mechanism\")\n>> Signed-off-by: Kieran Bingham \n> \n> Reviewed-by: Paul Elder \n\nThanks.\n\n> \n>> ---\n>> .../generators/libcamera_templates/module_ipa_proxy.h.tmpl | 5 +++++\n>> 1 file changed, 5 insertions(+)\n>>\n>> diff --git a/utils/ipc/generators/libcamera_templates/module_ipa_proxy.h.tmpl b/utils/ipc/generators/libcamera_templates/module_ipa_proxy.h.tmpl\n>> index ae168548492c..c222f5f204df 100644\n>> --- a/utils/ipc/generators/libcamera_templates/module_ipa_proxy.h.tmpl\n>> +++ b/utils/ipc/generators/libcamera_templates/module_ipa_proxy.h.tmpl\n>> @@ -72,6 +72,11 @@ private:\n>> \tclass ThreadProxy : public Object\n>> \t{\n>> \tpublic:\n>> +\t\tThreadProxy()\n>> +\t\t\t: ipa_(nullptr)\n>> +\t\t{\n>> +\t\t}\n>> +\n>> \t\tvoid setIPA({{interface_name}} *ipa)\n>> \t\t{\n>> \t\t\tipa_ = ipa;\n>> -- \n>> 2.30.2\n>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 71C86C3232\n\tfor ;\n\tWed, 4 Aug 2021 11:30:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C946868811;\n\tWed, 4 Aug 2021 13:30:15 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C91366026E\n\tfor ;\n\tWed, 4 Aug 2021 13:30:14 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4930124F;\n\tWed, 4 Aug 2021 13:30:14 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"YkzeNDN2\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1628076614;\n\tbh=ANEXnP5eLMlWcrr9EPpS5D1tAgHHVBoM7XIf0yZoKQk=;\n\th=From:Subject:To:Cc:References:Date:In-Reply-To:From;\n\tb=YkzeNDN25blkgUMl05fBjGf/pfgXnexKBAhoOyjFioH+InSpo+OqWD9D9Ku6z0N2y\n\tTOeY7uJmy9BOVLPGDajEIm6UJKHn5xCVJUXXL0EdQJ7Sv3H2DE2uSxA2eZc11M0D+e\n\tmRdfuhtQJtMAnbXI9qhCwncXp4tGN4DKJ2EG1pUg=","From":"Kieran Bingham ","To":"paul.elder@ideasonboard.com","References":"<20210804102156.4636-1-kieran.bingham@ideasonboard.com>\n\t<20210804112646.GK2167@pyrite.rasen.tech>","Message-ID":"","Date":"Wed, 4 Aug 2021 12:30:11 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.11.0","MIME-Version":"1.0","In-Reply-To":"<20210804112646.GK2167@pyrite.rasen.tech>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] utils: ipc: Initialise ThreadProxy","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":18554,"web_url":"https://patchwork.libcamera.org/comment/18554/","msgid":"<7cc241de-8316-7a35-a596-c0475edadb3c@ideasonboard.com>","date":"2021-08-04T11:31:50","subject":"Re: [libcamera-devel] [PATCH] utils: ipc: Initialise ThreadProxy","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Kieran,\n\nThanks for the patch\n\nOn 8/4/21 3:51 PM, Kieran Bingham wrote:\n> The ThreadProxy IPA template does not implement a constructor and the\n> default compiler generated constructor does not initialise the private\n> ipa_ pointer.\n>\n> Whilst this should not be expected to be used while uninitialised, it\n> does get caught by static analysis for every IPA module constructed, so\n> lets be clean and fix it.\n>\n> Reported-by: Coverity CID=350116\n> Reported-by: Coverity CID=350123\n> Reported-by: Coverity CID=350140\n> Reported-by: Coverity CID=350147\n> Fixes: 7832e19a599e (\"utils: ipc: add templates for code generation for IPC mechanism\")\n> Signed-off-by: Kieran Bingham \nReviewed-by: Umang Jain \n> ---\n> .../generators/libcamera_templates/module_ipa_proxy.h.tmpl | 5 +++++\n> 1 file changed, 5 insertions(+)\n>\n> diff --git a/utils/ipc/generators/libcamera_templates/module_ipa_proxy.h.tmpl b/utils/ipc/generators/libcamera_templates/module_ipa_proxy.h.tmpl\n> index ae168548492c..c222f5f204df 100644\n> --- a/utils/ipc/generators/libcamera_templates/module_ipa_proxy.h.tmpl\n> +++ b/utils/ipc/generators/libcamera_templates/module_ipa_proxy.h.tmpl\n> @@ -72,6 +72,11 @@ private:\n> \tclass ThreadProxy : public Object\n> \t{\n> \tpublic:\n> +\t\tThreadProxy()\n> +\t\t\t: ipa_(nullptr)\n> +\t\t{\n> +\t\t}\n> +\n> \t\tvoid setIPA({{interface_name}} *ipa)\n> \t\t{\n> \t\t\tipa_ = ipa;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C46DAC3232\n\tfor ;\n\tWed, 4 Aug 2021 11:31:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4D40D68811;\n\tWed, 4 Aug 2021 13:31:57 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 620866026E\n\tfor ;\n\tWed, 4 Aug 2021 13:31:55 +0200 (CEST)","from [192.168.1.104] (unknown [103.251.226.40])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 90B7624F;\n\tWed, 4 Aug 2021 13:31:54 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"LEcMbpfm\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1628076715;\n\tbh=apg5XAw6ax8AbQhXOw9DJxF+aPRT+xkj6dWkEylu1jc=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=LEcMbpfmsNna/fGNE/jRWzcH8AsqWJfzLZuDNq9x7uSgocZD8Hr8B/DO1WtWgOb8B\n\tzr9DGn/QSOsUsv91yx27tozoWobbBPyrZHCJEx3TqfPHEJStNrU+VtcMhURes1ITqg\n\tBz4pDe4cgDvwmgSpE3H4XMMBQEJGSFZPmEBX7z9M=","To":"Kieran Bingham ,\n\tlibcamera devel ","References":"<20210804102156.4636-1-kieran.bingham@ideasonboard.com>","From":"Umang Jain ","Message-ID":"<7cc241de-8316-7a35-a596-c0475edadb3c@ideasonboard.com>","Date":"Wed, 4 Aug 2021 17:01:50 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.10.2","MIME-Version":"1.0","In-Reply-To":"<20210804102156.4636-1-kieran.bingham@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH] utils: ipc: Initialise ThreadProxy","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":18556,"web_url":"https://patchwork.libcamera.org/comment/18556/","msgid":"","date":"2021-08-04T12:04:04","subject":"Re: [libcamera-devel] [PATCH] utils: ipc: Initialise ThreadProxy","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Wed, Aug 04, 2021 at 11:21:56AM +0100, Kieran Bingham wrote:\n> The ThreadProxy IPA template does not implement a constructor and the\n> default compiler generated constructor does not initialise the private\n> ipa_ pointer.\n> \n> Whilst this should not be expected to be used while uninitialised, it\n> does get caught by static analysis for every IPA module constructed, so\n> lets be clean and fix it.\n> \n> Reported-by: Coverity CID=350116\n> Reported-by: Coverity CID=350123\n> Reported-by: Coverity CID=350140\n> Reported-by: Coverity CID=350147\n> Fixes: 7832e19a599e (\"utils: ipc: add templates for code generation for IPC mechanism\")\n> Signed-off-by: Kieran Bingham \n> ---\n> .../generators/libcamera_templates/module_ipa_proxy.h.tmpl | 5 +++++\n> 1 file changed, 5 insertions(+)\n> \n> diff --git a/utils/ipc/generators/libcamera_templates/module_ipa_proxy.h.tmpl b/utils/ipc/generators/libcamera_templates/module_ipa_proxy.h.tmpl\n> index ae168548492c..c222f5f204df 100644\n> --- a/utils/ipc/generators/libcamera_templates/module_ipa_proxy.h.tmpl\n> +++ b/utils/ipc/generators/libcamera_templates/module_ipa_proxy.h.tmpl\n> @@ -72,6 +72,11 @@ private:\n> \tclass ThreadProxy : public Object\n> \t{\n> \tpublic:\n> +\t\tThreadProxy()\n> +\t\t\t: ipa_(nullptr)\n> +\t\t{\n> +\t\t}\n> +\n> \t\tvoid setIPA({{interface_name}} *ipa)\n> \t\t{\n> \t\t\tipa_ = ipa;\n\nNote that this doesn't fix a bug, as we always call setIPA() before\nusing ipa_. As it's easy to please coverity and there's no drawback\n(this is clearly not a hot path), it's good to keep the warnings count\nlow.\n\nAnother option would be\n\ndiff --git a/utils/ipc/generators/libcamera_templates/module_ipa_proxy.h.tmpl b/utils/ipc/generators/libcamera_templates/module_ipa_proxy.h.tmpl\nindex ae168548492c..d535e0417433 100644\n--- a/utils/ipc/generators/libcamera_templates/module_ipa_proxy.h.tmpl\n+++ b/utils/ipc/generators/libcamera_templates/module_ipa_proxy.h.tmpl\n@@ -102,7 +102,7 @@ private:\n {%- endfor %}\n\n \tprivate:\n-\t\t{{interface_name}} *ipa_;\n+\t\t{{interface_name}} *ipa_ = nullptr;\n \t};\n\n \tThread thread_;\n\nI wonder if the constructor would still be inline in that case. It\nlikely doesn't matter much as it's very simple anyway. Either way,\n\nReviewed-by: Laurent Pinchart ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 945CDC3232\n\tfor ;\n\tWed, 4 Aug 2021 12:04:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0F1C5687B6;\n\tWed, 4 Aug 2021 14:04:19 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F004E6026E\n\tfor ;\n\tWed, 4 Aug 2021 14:04:16 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6E9E424F;\n\tWed, 4 Aug 2021 14:04:16 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"jgP7YnAk\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1628078656;\n\tbh=FgTtDqLXJM6kAQl1W1q15jFWZ1WLH9QnV1q50M5iEpE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=jgP7YnAkzW5l2BL5ypWYWIZG4T/hgvEGFw3GuLcJAKJmhRgV1CV3AfhW1NNLzL41A\n\tbnbzOhaQZ5LptO/h7urmVx6tAj/ealdiZhw+caEtG9aJy+ykKEH0dZZO5MvaE4Zf13\n\tdrjrN4SDnA0zUc3uFuz/Iz13DLmmm++8RcTt0GTA=","Date":"Wed, 4 Aug 2021 15:04:04 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20210804102156.4636-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210804102156.4636-1-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] utils: ipc: Initialise ThreadProxy","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]