[{"id":18547,"web_url":"https://patchwork.libcamera.org/comment/18547/","msgid":"<1e126dd0-bcf5-e309-a8d5-37444a65c8a7@ideasonboard.com>","date":"2021-08-04T09:12:56","subject":"Re: [libcamera-devel] [IPU3-IPA]PATCH] binary_data: Use type-safe\n\tfile flags","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Umang,\n\nOn 04/08/2021 05:15, Umang Jain wrote:\n> In commit 91d06ae2fc61(\"libcamera: file: Use Flags<> class for open\n> flags\"), type-safe file mode flags are introduced. Adapt our usage\n> accordingly in BinaryData, which uses the File class from libcamera.\n> \n> Signed-off-by: Umang Jain \n\nAh yes!\n\nReviewed-by: Kieran Bingham \n\n> ---\n> binary_data.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/binary_data.cpp b/binary_data.cpp\n> index aa65778..27fc9fe 100644\n> --- a/binary_data.cpp\n> +++ b/binary_data.cpp\n> @@ -37,7 +37,7 @@ int BinaryData::load(const char *filename)\n> \t\treturn -ENOENT;\n> \t}\n> \n> -\tif (!binary.open(File::ReadOnly)) {\n> +\tif (!binary.open(File::OpenModeFlag::ReadOnly)) {\n> \t\tLOG(AIBD, Error) << \"Failed to open: \" << filename;\n> \t\treturn -EINVAL;\n> \t}\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D9804C3235\n\tfor ;\n\tWed, 4 Aug 2021 09:13:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 25CD868811;\n\tWed, 4 Aug 2021 11:13:01 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4B1F86026C\n\tfor ;\n\tWed, 4 Aug 2021 11:12:59 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 87F3724F;\n\tWed, 4 Aug 2021 11:12:58 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"nGc6Csp/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1628068379;\n\tbh=PQNc2GQWZO+U+4h8jvJNcAZMi0HfXldU9DycORxqvto=;\n\th=From:To:References:Subject:Date:In-Reply-To:From;\n\tb=nGc6Csp/LZR68FiHvbJhn+JEMkTyAGHwCHErnJm6p+CoEP+MNLVQ0Wr+3ZMQ5MITd\n\t887Q44x9Z8lnUDtvK6FCqLbGKWUpw/il6DZZgNG7RNVYHr4+4/wozK7jfUV5r++0cT\n\tHZxWvgtznvqtA9vQlRtybJJth/FJV/Ea40TiuOoQ=","From":"kieran.bingham@ideasonboard.com","To":"Umang Jain ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210804041519.77076-1-umang.jain@ideasonboard.com>","Message-ID":"<1e126dd0-bcf5-e309-a8d5-37444a65c8a7@ideasonboard.com>","Date":"Wed, 4 Aug 2021 10:12:56 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.11.0","MIME-Version":"1.0","In-Reply-To":"<20210804041519.77076-1-umang.jain@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [IPU3-IPA]PATCH] binary_data: Use type-safe\n\tfile flags","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":18548,"web_url":"https://patchwork.libcamera.org/comment/18548/","msgid":"","date":"2021-08-04T09:17:19","subject":"Re: [libcamera-devel] [IPU3-IPA]PATCH] binary_data: Use type-safe\n\tfile flags","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Umang,\n\nThank you for the patch.\n\nOn Wed, Aug 04, 2021 at 09:45:19AM +0530, Umang Jain wrote:\n> In commit 91d06ae2fc61(\"libcamera: file: Use Flags<> class for open\n> flags\"), type-safe file mode flags are introduced. Adapt our usage\n> accordingly in BinaryData, which uses the File class from libcamera.\n> \n> Signed-off-by: Umang Jain \n\nReviewed-by: Laurent Pinchart \n\nSorry for not noticing.\n\n> ---\n> binary_data.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/binary_data.cpp b/binary_data.cpp\n> index aa65778..27fc9fe 100644\n> --- a/binary_data.cpp\n> +++ b/binary_data.cpp\n> @@ -37,7 +37,7 @@ int BinaryData::load(const char *filename)\n> \t\treturn -ENOENT;\n> \t}\n> \n> -\tif (!binary.open(File::ReadOnly)) {\n> +\tif (!binary.open(File::OpenModeFlag::ReadOnly)) {\n> \t\tLOG(AIBD, Error) << \"Failed to open: \" << filename;\n> \t\treturn -EINVAL;\n> \t}","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7AA9BC3235\n\tfor ;\n\tWed, 4 Aug 2021 09:17:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E1E7968811;\n\tWed, 4 Aug 2021 11:17:32 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A82236026C\n\tfor ;\n\tWed, 4 Aug 2021 11:17:31 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2935524F;\n\tWed, 4 Aug 2021 11:17:31 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tK4srXtV\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1628068651;\n\tbh=dTJ4snSCWsGxRVj0/TSuyFL92lBVhgqqrwXW52FxD4M=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=tK4srXtV4k7gxaBzCRAzjB8iGSiK/Hte1VkknMNNyKQ7w4XVTgq/vV8NPJ50i031M\n\tVy7ik1pwpa0QDzp+qZhGsEW0/kHJCIctVzLrI6f0Jvv9Ukmuuknn8BR9nZot9JOkdF\n\tk6vhZfQ3oYHKNQHbVQnqgqzr2Utxy/z6NxzzMCb4=","Date":"Wed, 4 Aug 2021 12:17:19 +0300","From":"Laurent Pinchart ","To":"Umang Jain ","Message-ID":"","References":"<20210804041519.77076-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210804041519.77076-1-umang.jain@ideasonboard.com>","Subject":"Re: [libcamera-devel] [IPU3-IPA]PATCH] binary_data: Use type-safe\n\tfile flags","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":18550,"web_url":"https://patchwork.libcamera.org/comment/18550/","msgid":"","date":"2021-08-04T09:55:06","subject":"Re: [libcamera-devel] [IPU3-IPA]PATCH] binary_data: Use type-safe\n\tfile flags","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Hi Umang,\n\nOn Wed, Aug 4, 2021 at 6:17 PM Laurent Pinchart\n wrote:\n>\n> Hi Umang,\n>\n> Thank you for the patch.\n>\n> On Wed, Aug 04, 2021 at 09:45:19AM +0530, Umang Jain wrote:\n> > In commit 91d06ae2fc61(\"libcamera: file: Use Flags<> class for open\n> > flags\"), type-safe file mode flags are introduced. Adapt our usage\n> > accordingly in BinaryData, which uses the File class from libcamera.\n> >\n> > Signed-off-by: Umang Jain \n>\n> Reviewed-by: Laurent Pinchart \n>\n\nThanks for fixing.\nReviewed-by: Hirokazu Honda \n\n> Sorry for not noticing.\n>\n> > ---\n> > binary_data.cpp | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> >\n> > diff --git a/binary_data.cpp b/binary_data.cpp\n> > index aa65778..27fc9fe 100644\n> > --- a/binary_data.cpp\n> > +++ b/binary_data.cpp\n> > @@ -37,7 +37,7 @@ int BinaryData::load(const char *filename)\n> > return -ENOENT;\n> > }\n> >\n> > - if (!binary.open(File::ReadOnly)) {\n> > + if (!binary.open(File::OpenModeFlag::ReadOnly)) {\n> > LOG(AIBD, Error) << \"Failed to open: \" << filename;\n> > return -EINVAL;\n> > }\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4C242C3235\n\tfor ;\n\tWed, 4 Aug 2021 09:55:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B4E606026C;\n\tWed, 4 Aug 2021 11:55:19 +0200 (CEST)","from mail-ej1-x632.google.com (mail-ej1-x632.google.com\n\t[IPv6:2a00:1450:4864:20::632])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 54DCB6026C\n\tfor ;\n\tWed, 4 Aug 2021 11:55:18 +0200 (CEST)","by mail-ej1-x632.google.com with SMTP id gs8so2796956ejc.13\n\tfor ;\n\tWed, 04 Aug 2021 02:55:18 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"DtHO6kNW\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=YpNzpNpiy6/9p7eWaXOVh88GwFSzmiOMgJ7BCCz1cRA=;\n\tb=DtHO6kNWXPvdfaybi3AI8PYnOu0hLrbK+/TNWcUpbeWGndoHnriNA0wrKwqmKumS3o\n\tPFgAvJy60fIKatTodbQmKkVyJHWoDbk3xCx2wlOXh3pPYotO6Nt+wpLdJoGdUMUjPTVb\n\tBr4c08ZpdACGUAW0wOeAXZyYdc/VRKx5+A+CE=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=YpNzpNpiy6/9p7eWaXOVh88GwFSzmiOMgJ7BCCz1cRA=;\n\tb=plBpNaue0h50yZK58WumIk92yphnT2SA/1scheG+bA0UGDOxTIQkejnJlrRS5PxLOM\n\tYX0Dfj/ji68l9h3h2TTP0ZVpBIvxdhWiW9WBShoJtvTYeqgV7t27Rg6s50S7qVAmodlS\n\toE9jhkxLMo3hq3zW5AoCdnejeB/0ovkOuGkdmlYfirN54rZVVHpagZ+HHzu3D49c9cP4\n\tt/4xyWhg7PCKd50QfrMqNO6szF3g5oZrauWEiRqp0ABJJapNGikpj/i3PHqs5rhIa3Nc\n\ttvhkYOwfEaOMNGMotb2/DLzr+vNLT3KhflFreA80ps1TDtFMyyKcoxMVwywh6PST6+Zr\n\tHR2Q==","X-Gm-Message-State":"AOAM533u6VK+LM38FMG+EqR14VNwAUDLydPV8c8ajA0fRbZOaFZweLXq\n\taobfM4u4JtQNlJn7kQg3LVar4zM+AJxd8J9dIowFgWRv21A=","X-Google-Smtp-Source":"ABdhPJwwzVuiH0rGOG5oqMWnhaqcET9CCh47nO0/XPXZ2v/dBeEkO1BKT3kr6yI89p/jpdpuJb0rOGFI3u2DKgXy7wQ=","X-Received":"by 2002:a17:906:4b18:: with SMTP id\n\ty24mr24354088eju.42.1628070917940; \n\tWed, 04 Aug 2021 02:55:17 -0700 (PDT)","MIME-Version":"1.0","References":"<20210804041519.77076-1-umang.jain@ideasonboard.com>\n\t","In-Reply-To":"","From":"Hirokazu Honda ","Date":"Wed, 4 Aug 2021 18:55:06 +0900","Message-ID":"","To":"Laurent Pinchart ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [IPU3-IPA]PATCH] binary_data: Use type-safe\n\tfile flags","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]