{"id":13170,"url":"https://patchwork.libcamera.org/api/patches/13170/?format=json","web_url":"https://patchwork.libcamera.org/patch/13170/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210730110154.181370-3-umang.jain@ideasonboard.com>","date":"2021-07-30T11:01:52","name":"[libcamera-devel,v3,2/4] android: Disallow external location in HAL config","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"a8a299a596ef41ae5c63d6a73a2da9e96b128863","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/?format=json","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"delegate":{"id":12,"url":"https://patchwork.libcamera.org/api/users/12/?format=json","username":"uajain","first_name":"Umang","last_name":"Jain","email":"umang.jain@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/13170/mbox/","series":[{"id":2292,"url":"https://patchwork.libcamera.org/api/series/2292/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2292","date":"2021-07-30T11:01:50","name":"android: Handle internal UVC cameras","version":3,"mbox":"https://patchwork.libcamera.org/series/2292/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/13170/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/13170/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C8EF8C3230\n\tfor ;\n\tFri, 30 Jul 2021 11:02:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 828EC687C5;\n\tFri, 30 Jul 2021 13:02:14 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 05D9C687BF\n\tfor ;\n\tFri, 30 Jul 2021 13:02:13 +0200 (CEST)","from perceval.ideasonboard.com (unknown [103.251.226.16])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F3D2C89B;\n\tFri, 30 Jul 2021 13:02:11 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"I8mQ0X9q\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1627642932;\n\tbh=zHHmGKmppvYvtnQwAHMpoVH/is8FPSbYqQfLb7uHY1Q=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=I8mQ0X9qGOUT1g5v1jV1JIUAf1KeST7hVjFjrrIeEgGllvFnTrBy/IN8bAhzddUD2\n\tLADCK/fCCAu1ImDyxOARgp+VCZIuMoE7AMD4CxfuKKLG+oLWyBxXoyQ32fsodT5y5u\n\tscIyAh7i00CcLaeuGWBcmUMNzyQow/gwBJzAg+sY=","From":"Umang Jain ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 30 Jul 2021 16:31:52 +0530","Message-Id":"<20210730110154.181370-3-umang.jain@ideasonboard.com>","X-Mailer":"git-send-email 2.31.1","In-Reply-To":"<20210730110154.181370-1-umang.jain@ideasonboard.com>","References":"<20210730110154.181370-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 2/4] android: Disallow external\n\tlocation in HAL config","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Error out on any camera's location if set to \"external\",\nin the HAL configuration file. The HAL configuration file\nis only meant for the integrated cameras present on the system.\n\nSigned-off-by: Umang Jain \n---\n src/android/camera_hal_config.cpp | 2 --\n 1 file changed, 2 deletions(-)","diff":"diff --git a/src/android/camera_hal_config.cpp b/src/android/camera_hal_config.cpp\nindex 833cf4ba..7126aba4 100644\n--- a/src/android/camera_hal_config.cpp\n+++ b/src/android/camera_hal_config.cpp\n@@ -127,8 +127,6 @@ int CameraHalConfig::Private::parseCameraLocation(CameraConfigData *cameraConfig\n \t\tcameraConfigData->facing = CAMERA_FACING_FRONT;\n \telse if (location == \"back\")\n \t\tcameraConfigData->facing = CAMERA_FACING_BACK;\n-\telse if (location == \"external\")\n-\t\tcameraConfigData->facing = CAMERA_FACING_EXTERNAL;\n \telse\n \t\treturn -EINVAL;\n \n","prefixes":["libcamera-devel","v3","2/4"]}