[{"id":18481,"web_url":"https://patchwork.libcamera.org/comment/18481/","msgid":"<20210802070247.GS2167@pyrite.rasen.tech>","date":"2021-08-02T07:02:47","subject":"Re: [libcamera-devel] [PATCH v3 1/4] android: Instantiate\n\tCameraDevice after checking HAL config validity","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Umang,\n\nOn Fri, Jul 30, 2021 at 04:31:51PM +0530, Umang Jain wrote:\n> Currently CameraDevice wrapper is created first and then HAL config\n> validity is checked. If the validity checks fail, the code path will\n> simply return, in which case, creating CameraDevice seems a futile\n> exercise.\n> \n> This patch defers the creation of CameraDevice wrapper until the HAL\n> config validity is checked for internal cameras. This will also enable\n> us to infer a few things beforehand, by reading the config file before\n> creating the CameraDevice wrapper.\n> \n> Signed-off-by: Umang Jain \n> Reviewed-by: Jacopo Mondi \n> Reviewed-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> src/android/camera_hal_manager.cpp | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/android/camera_hal_manager.cpp b/src/android/camera_hal_manager.cpp\n> index 4cd67544..b364f62a 100644\n> --- a/src/android/camera_hal_manager.cpp\n> +++ b/src/android/camera_hal_manager.cpp\n> @@ -133,9 +133,6 @@ void CameraHalManager::cameraAdded(std::shared_ptr cam)\n> \t\t}\n> \t}\n> \n> -\t/* Create a CameraDevice instance to wrap the libcamera Camera. */\n> -\tstd::unique_ptr camera = CameraDevice::create(id, cam);\n> -\n> \t/*\n> \t * The configuration file must be valid, and contain a corresponding\n> \t * entry for internal cameras. External cameras can be initialized\n> @@ -155,6 +152,9 @@ void CameraHalManager::cameraAdded(std::shared_ptr cam)\n> \t\treturn;\n> \t}\n> \n> +\t/* Create a CameraDevice instance to wrap the libcamera Camera. */\n> +\tstd::unique_ptr camera = CameraDevice::create(id, cam);\n> +\n> \tint ret = camera->initialize(cameraConfigData);\n> \tif (ret) {\n> \t\tLOG(HAL, Error) << \"Failed to initialize camera: \" << cam->id();\n> -- \n> 2.31.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5B808BD878\n\tfor ;\n\tMon, 2 Aug 2021 07:02:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B40E8687B6;\n\tMon, 2 Aug 2021 09:02:57 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9249D6026E\n\tfor ;\n\tMon, 2 Aug 2021 09:02:55 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2D9C74A3;\n\tMon, 2 Aug 2021 09:02:53 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"nwMKJmlU\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1627887775;\n\tbh=b8QA1sC966WigwhtuoxlxmB/OsqxgNq6hHK6vCPJx4Y=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=nwMKJmlUppClpCZV9lenHtAtyy2uKjff8+zwTZwDlBYAH9j581KUKq0xuVwFyUpLL\n\twA6fiebniL9RwvQqKpGtG+DFO+BRgjKfCtXQaO6qyE99HxXpGAovUrIlPpFMlMSPg0\n\tHgzSyULnhbIR4tAWgX7EMcBuFFhiFaWHapZNlpmU=","Date":"Mon, 2 Aug 2021 16:02:47 +0900","From":"paul.elder@ideasonboard.com","To":"Umang Jain ","Message-ID":"<20210802070247.GS2167@pyrite.rasen.tech>","References":"<20210730110154.181370-1-umang.jain@ideasonboard.com>\n\t<20210730110154.181370-2-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20210730110154.181370-2-umang.jain@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3 1/4] android: Instantiate\n\tCameraDevice after checking HAL config validity","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]