[{"id":18475,"web_url":"https://patchwork.libcamera.org/comment/18475/","msgid":"","date":"2021-08-02T01:28:54","subject":"Re: [libcamera-devel] [PATCH v6 9/9] android,\n\tcontrols: Add and plumb MaxLatency control","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Fri, Jul 30, 2021 at 07:35:36PM +0900, Paul Elder wrote:\n> Add a MaxLatency control, and plumb it into the HAL accordingly.\n> \n> Bug: https://bugs.libcamera.org/show_bug.cgi?id=50\n> Signed-off-by: Paul Elder \n> Reviewed-by: Laurent Pinchart \n> Reviewed-by: Jacopo Mondi \n> \n> ---\n> Changes in v3:\n> - use v3 setMetadata\n> - add comment to explain 4\n> - remove todo\n> \n> Changes in v2:\n> - use new setMetadata\n> - rebase on camera capabilities refactor\n> ---\n> src/android/camera_capabilities.cpp | 7 +++++--\n> src/libcamera/control_ids.yaml | 10 ++++++++++\n> 2 files changed, 15 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\n> index 1bf3ffa5..77ad8c03 100644\n> --- a/src/android/camera_capabilities.cpp\n> +++ b/src/android/camera_capabilities.cpp\n> @@ -1119,8 +1119,11 @@ int CameraCapabilities::initializeStaticMetadata()\n> \t}\n> \n> \t/* Sync static metadata. */\n> -\tint32_t maxLatency = ANDROID_SYNC_MAX_LATENCY_UNKNOWN;\n> -\tstaticMetadata_->addEntry(ANDROID_SYNC_MAX_LATENCY, maxLatency);\n> +\tsetMetadata(\n> +\t\tstaticMetadata_.get(), ANDROID_SYNC_MAX_LATENCY,\n> +\t\tcontrolsInfo, &controls::draft::MaxLatency,\n> +\t\tControlRange::Def,\n> +\t\tANDROID_SYNC_MAX_LATENCY_UNKNOWN);\n\nThat's a strange indentation.\n\n> \n> \t/* Flash static metadata. */\n> \tchar flashAvailable = ANDROID_FLASH_INFO_AVAILABLE_FALSE;\n> diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\n> index d92f29f5..9d4638ae 100644\n> --- a/src/libcamera/control_ids.yaml\n> +++ b/src/libcamera/control_ids.yaml\n> @@ -622,6 +622,16 @@ controls:\n> detection, additional format conversions etc) count as an additional\n> pipeline stage.\n> \n> + - MaxLatency:\n> + type: int32_t\n> + draft: true\n> + description: |\n> + The maximum number of frames that can occur after a request (different\n> + than the previous) has been submitted, and before the result's state\n> + becomes synchronized. A value of -1 indicates unknown latency, and 0\n> + indicates per-frame control. Currently identical to\n> + ANDROID_SYNC_MAX_LATENCY.\n> +\n> - TestPatternMode:\n> type: int32_t\n> draft: true","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 480A0BD878\n\tfor ;\n\tMon, 2 Aug 2021 01:29:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BDB62687BD;\n\tMon, 2 Aug 2021 03:29:06 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ED0E9687B6\n\tfor ;\n\tMon, 2 Aug 2021 03:29:04 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7B1EE4A3;\n\tMon, 2 Aug 2021 03:29:04 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"N+oTYP/k\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1627867744;\n\tbh=c8V7WbDOa0nBPDTHEPC5CQd7j6wQcYjApU8X9Kjvj74=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=N+oTYP/kNKAO8NLQtnrZywY94aUXvVM6BHJ9TeJSfi28hc2ed2KpA359VJV4xP/JU\n\tStCGcZUSVE19MKpgHKzujJazrp8lzdRfW3bmVi0S6ixNHa2H8ob62Cl1vaY00y2Y8H\n\tnARRduamamDLepkriVeLA6HgymJPT6KDcV+OKflY=","Date":"Mon, 2 Aug 2021 04:28:54 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Message-ID":"","References":"<20210730103536.81117-1-paul.elder@ideasonboard.com>\n\t<20210730103536.81117-10-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210730103536.81117-10-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v6 9/9] android,\n\tcontrols: Add and plumb MaxLatency control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":18478,"web_url":"https://patchwork.libcamera.org/comment/18478/","msgid":"<20210802054047.GQ2167@pyrite.rasen.tech>","date":"2021-08-02T05:40:47","subject":"Re: [libcamera-devel] [PATCH v6 9/9] android,\n\tcontrols: Add and plumb MaxLatency control","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Laurent,\n\nOn Mon, Aug 02, 2021 at 04:28:54AM +0300, Laurent Pinchart wrote:\n> Hi Paul,\n> \n> Thank you for the patch.\n> \n> On Fri, Jul 30, 2021 at 07:35:36PM +0900, Paul Elder wrote:\n> > Add a MaxLatency control, and plumb it into the HAL accordingly.\n> > \n> > Bug: https://bugs.libcamera.org/show_bug.cgi?id=50\n> > Signed-off-by: Paul Elder \n> > Reviewed-by: Laurent Pinchart \n> > Reviewed-by: Jacopo Mondi \n> > \n> > ---\n> > Changes in v3:\n> > - use v3 setMetadata\n> > - add comment to explain 4\n> > - remove todo\n> > \n> > Changes in v2:\n> > - use new setMetadata\n> > - rebase on camera capabilities refactor\n> > ---\n> > src/android/camera_capabilities.cpp | 7 +++++--\n> > src/libcamera/control_ids.yaml | 10 ++++++++++\n> > 2 files changed, 15 insertions(+), 2 deletions(-)\n> > \n> > diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\n> > index 1bf3ffa5..77ad8c03 100644\n> > --- a/src/android/camera_capabilities.cpp\n> > +++ b/src/android/camera_capabilities.cpp\n> > @@ -1119,8 +1119,11 @@ int CameraCapabilities::initializeStaticMetadata()\n> > \t}\n> > \n> > \t/* Sync static metadata. */\n> > -\tint32_t maxLatency = ANDROID_SYNC_MAX_LATENCY_UNKNOWN;\n> > -\tstaticMetadata_->addEntry(ANDROID_SYNC_MAX_LATENCY, maxLatency);\n> > +\tsetMetadata(\n> > +\t\tstaticMetadata_.get(), ANDROID_SYNC_MAX_LATENCY,\n> > +\t\tcontrolsInfo, &controls::draft::MaxLatency,\n> > +\t\tControlRange::Def,\n> > +\t\tANDROID_SYNC_MAX_LATENCY_UNKNOWN);\n> \n> That's a strange indentation.\n\nI was thinking the first line is android metadata + tag, and the second\nline mirrors that with libcamera controls info + tag.\n\nOr is it that the name \"setMetadata\" is short enough that I can put the\nfirst line on the same line as that, and indent everything further a bit\nmore?\n\n\nPaul\n\n> \n> > \n> > \t/* Flash static metadata. */\n> > \tchar flashAvailable = ANDROID_FLASH_INFO_AVAILABLE_FALSE;\n> > diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\n> > index d92f29f5..9d4638ae 100644\n> > --- a/src/libcamera/control_ids.yaml\n> > +++ b/src/libcamera/control_ids.yaml\n> > @@ -622,6 +622,16 @@ controls:\n> > detection, additional format conversions etc) count as an additional\n> > pipeline stage.\n> > \n> > + - MaxLatency:\n> > + type: int32_t\n> > + draft: true\n> > + description: |\n> > + The maximum number of frames that can occur after a request (different\n> > + than the previous) has been submitted, and before the result's state\n> > + becomes synchronized. A value of -1 indicates unknown latency, and 0\n> > + indicates per-frame control. Currently identical to\n> > + ANDROID_SYNC_MAX_LATENCY.\n> > +\n> > - TestPatternMode:\n> > type: int32_t\n> > draft: true","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C22AAC3232\n\tfor ;\n\tMon, 2 Aug 2021 05:40:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4BF06687C3;\n\tMon, 2 Aug 2021 07:40:57 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8F0D86026A\n\tfor ;\n\tMon, 2 Aug 2021 07:40:56 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AAF2A4A3;\n\tMon, 2 Aug 2021 07:40:54 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"frK+B90o\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1627882856;\n\tbh=a8O38PjFFxE8rxb7/3B3dTB6In+F05UQ7qlRC1MeJRo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=frK+B90oONbwD1+fs7i4rGFzBG8jbWgIlb2o2jvo8ONlbhTjJKCZvFLh+rGvroIYB\n\t52Yzabi5cawpRYK/sfagaWOP8KTIJ9VSGsQxNvBLf5BeGfBPdCYY7tk6DqfUUOsaPY\n\tsVXjTDn1h6JNqHWGwKZ4RunSUb7xVjmFyv09NjmI=","Date":"Mon, 2 Aug 2021 14:40:47 +0900","From":"paul.elder@ideasonboard.com","To":"Laurent Pinchart ","Message-ID":"<20210802054047.GQ2167@pyrite.rasen.tech>","References":"<20210730103536.81117-1-paul.elder@ideasonboard.com>\n\t<20210730103536.81117-10-paul.elder@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH v6 9/9] android,\n\tcontrols: Add and plumb MaxLatency control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":18487,"web_url":"https://patchwork.libcamera.org/comment/18487/","msgid":"","date":"2021-08-02T08:57:01","subject":"Re: [libcamera-devel] [PATCH v6 9/9] android,\n\tcontrols: Add and plumb MaxLatency control","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nOn Mon, Aug 02, 2021 at 02:40:47PM +0900, paul.elder@ideasonboard.com wrote:\n> On Mon, Aug 02, 2021 at 04:28:54AM +0300, Laurent Pinchart wrote:\n> > On Fri, Jul 30, 2021 at 07:35:36PM +0900, Paul Elder wrote:\n> > > Add a MaxLatency control, and plumb it into the HAL accordingly.\n> > > \n> > > Bug: https://bugs.libcamera.org/show_bug.cgi?id=50\n> > > Signed-off-by: Paul Elder \n> > > Reviewed-by: Laurent Pinchart \n> > > Reviewed-by: Jacopo Mondi \n> > > \n> > > ---\n> > > Changes in v3:\n> > > - use v3 setMetadata\n> > > - add comment to explain 4\n> > > - remove todo\n> > > \n> > > Changes in v2:\n> > > - use new setMetadata\n> > > - rebase on camera capabilities refactor\n> > > ---\n> > > src/android/camera_capabilities.cpp | 7 +++++--\n> > > src/libcamera/control_ids.yaml | 10 ++++++++++\n> > > 2 files changed, 15 insertions(+), 2 deletions(-)\n> > > \n> > > diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\n> > > index 1bf3ffa5..77ad8c03 100644\n> > > --- a/src/android/camera_capabilities.cpp\n> > > +++ b/src/android/camera_capabilities.cpp\n> > > @@ -1119,8 +1119,11 @@ int CameraCapabilities::initializeStaticMetadata()\n> > > \t}\n> > > \n> > > \t/* Sync static metadata. */\n> > > -\tint32_t maxLatency = ANDROID_SYNC_MAX_LATENCY_UNKNOWN;\n> > > -\tstaticMetadata_->addEntry(ANDROID_SYNC_MAX_LATENCY, maxLatency);\n> > > +\tsetMetadata(\n> > > +\t\tstaticMetadata_.get(), ANDROID_SYNC_MAX_LATENCY,\n> > > +\t\tcontrolsInfo, &controls::draft::MaxLatency,\n> > > +\t\tControlRange::Def,\n> > > +\t\tANDROID_SYNC_MAX_LATENCY_UNKNOWN);\n> > \n> > That's a strange indentation.\n> \n> I was thinking the first line is android metadata + tag, and the second\n> line mirrors that with libcamera controls info + tag.\n> \n> Or is it that the name \"setMetadata\" is short enough that I can put the\n> first line on the same line as that, and indent everything further a bit\n> more?\n\nYes, I meant\n\n\tsetMetadata(staticMetadata_.get(), ANDROID_SYNC_MAX_LATENCY,\n\t\t controlsInfo, &controls::draft::MaxLatency,\n\t\t ControlRange::Def,\n\t\t ANDROID_SYNC_MAX_LATENCY_UNKNOWN);\n\n> > > \n> > > \t/* Flash static metadata. */\n> > > \tchar flashAvailable = ANDROID_FLASH_INFO_AVAILABLE_FALSE;\n> > > diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\n> > > index d92f29f5..9d4638ae 100644\n> > > --- a/src/libcamera/control_ids.yaml\n> > > +++ b/src/libcamera/control_ids.yaml\n> > > @@ -622,6 +622,16 @@ controls:\n> > > detection, additional format conversions etc) count as an additional\n> > > pipeline stage.\n> > > \n> > > + - MaxLatency:\n> > > + type: int32_t\n> > > + draft: true\n> > > + description: |\n> > > + The maximum number of frames that can occur after a request (different\n> > > + than the previous) has been submitted, and before the result's state\n> > > + becomes synchronized. A value of -1 indicates unknown latency, and 0\n> > > + indicates per-frame control. Currently identical to\n> > > + ANDROID_SYNC_MAX_LATENCY.\n> > > +\n> > > - TestPatternMode:\n> > > type: int32_t\n> > > draft: true","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9EC5ABD878\n\tfor ;\n\tMon, 2 Aug 2021 08:57:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 226C9687C3;\n\tMon, 2 Aug 2021 10:57:15 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9BC796026E\n\tfor ;\n\tMon, 2 Aug 2021 10:57:13 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 021654A3;\n\tMon, 2 Aug 2021 10:57:12 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"uQKEE6ws\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1627894633;\n\tbh=twfEFSGgt9yG19WRrCWzm4z1HJTG0MXAgoIEq6v7mKs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=uQKEE6wsXMkBVl2lwwB3vuSq5W6i55Q5xVKZ2BzaUnZSoUQwIoMFYRWLBSRNP58up\n\tTDEA+aXVYBqotvSlBMsPi+PwkhcbJur3HbSG8q4FNZG9hZBOTUUYQd1R8LU84/yo74\n\tcyIjsMasfgvt0cQbNzC9cim9wQOCLRA34yVsne5Q=","Date":"Mon, 2 Aug 2021 11:57:01 +0300","From":"Laurent Pinchart ","To":"paul.elder@ideasonboard.com","Message-ID":"","References":"<20210730103536.81117-1-paul.elder@ideasonboard.com>\n\t<20210730103536.81117-10-paul.elder@ideasonboard.com>\n\t\n\t<20210802054047.GQ2167@pyrite.rasen.tech>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210802054047.GQ2167@pyrite.rasen.tech>","Subject":"Re: [libcamera-devel] [PATCH v6 9/9] android,\n\tcontrols: Add and plumb MaxLatency control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]