{"id":13147,"url":"https://patchwork.libcamera.org/api/patches/13147/?format=json","web_url":"https://patchwork.libcamera.org/patch/13147/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210730010306.19956-3-laurent.pinchart@ideasonboard.com>","date":"2021-07-30T01:03:00","name":"[libcamera-devel,v2,2/8] cam: Add FrameSink base class","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"4a4e712411efe9349fce04dba95fa42655b1a1ec","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/13147/mbox/","series":[{"id":2289,"url":"https://patchwork.libcamera.org/api/series/2289/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2289","date":"2021-07-30T01:02:59","name":"libcamera: Add DRM/KMS viewfinder display to cam","version":2,"mbox":"https://patchwork.libcamera.org/series/2289/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/13147/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/13147/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CA036C3230\n\tfor ;\n\tFri, 30 Jul 2021 01:03:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 051BA687C7;\n\tFri, 30 Jul 2021 03:03:23 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 44BFC687BE\n\tfor ;\n\tFri, 30 Jul 2021 03:03:19 +0200 (CEST)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E1C8B9FB\n\tfor ;\n\tFri, 30 Jul 2021 03:03:18 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Ool5aPj/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1627606999;\n\tbh=2Amx5m8JczLn2JMxvAEx9dCy/nMaGljXfZrAfhmhgYQ=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=Ool5aPj/hfBc2o7stB2FtJnm+sP5jcCZsl11PoyzYZaplewlc+9bCXwRPWyAPLlDH\n\tBu4zNtXtnV3ZXFSiGAH6hgnlrGpyU1rjxqvxVn+w7oQDQgPYX3E8tPVxqd+zgHHsNy\n\t82ylOndeDVf1zjmd0cVjWheJTOrqnnJ0GyejCBh8=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 30 Jul 2021 04:03:00 +0300","Message-Id":"<20210730010306.19956-3-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.31.1","In-Reply-To":"<20210730010306.19956-1-laurent.pinchart@ideasonboard.com>","References":"<20210730010306.19956-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 2/8] cam: Add FrameSink base class","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The FrameSink class serves as a base to implement components that\nconsume frames. This allows handling frame sinks in a generic way,\nindependent of their nature. The BufferWrite class will be ported to\nFrameSink in a second step.\n\nSigned-off-by: Laurent Pinchart \nReviewed-by: Niklas Söderlund \n---\n src/cam/frame_sink.cpp | 31 +++++++++++++++++++++++++++++++\n src/cam/frame_sink.h | 34 ++++++++++++++++++++++++++++++++++\n src/cam/meson.build | 1 +\n 3 files changed, 66 insertions(+)\n create mode 100644 src/cam/frame_sink.cpp\n create mode 100644 src/cam/frame_sink.h","diff":"diff --git a/src/cam/frame_sink.cpp b/src/cam/frame_sink.cpp\nnew file mode 100644\nindex 000000000000..6e15c1007f12\n--- /dev/null\n+++ b/src/cam/frame_sink.cpp\n@@ -0,0 +1,31 @@\n+/* SPDX-License-Identifier: GPL-2.0-or-later */\n+/*\n+ * Copyright (C) 2020, Ideas on Board Oy\n+ *\n+ * frame_sink.cpp - Base Frame Sink Class\n+ */\n+\n+#include \"frame_sink.h\"\n+\n+FrameSink::~FrameSink()\n+{\n+}\n+\n+int FrameSink::configure([[maybe_unused]] const libcamera::CameraConfiguration &config)\n+{\n+\treturn 0;\n+}\n+\n+void FrameSink::mapBuffer([[maybe_unused]] libcamera::FrameBuffer *buffer)\n+{\n+}\n+\n+int FrameSink::start()\n+{\n+\treturn 0;\n+}\n+\n+int FrameSink::stop()\n+{\n+\treturn 0;\n+}\ndiff --git a/src/cam/frame_sink.h b/src/cam/frame_sink.h\nnew file mode 100644\nindex 000000000000..116e5267bebe\n--- /dev/null\n+++ b/src/cam/frame_sink.h\n@@ -0,0 +1,34 @@\n+/* SPDX-License-Identifier: GPL-2.0-or-later */\n+/*\n+ * Copyright (C) 2020, Ideas on Board Oy\n+ *\n+ * frame_sink.h - Base Frame Sink Class\n+ */\n+#ifndef __CAM_FRAME_SINK_H__\n+#define __CAM_FRAME_SINK_H__\n+\n+#include \n+\n+namespace libcamera {\n+class CameraConfiguration;\n+class FrameBuffer;\n+class Request;\n+} /* namespace libcamera */\n+\n+class FrameSink\n+{\n+public:\n+\tvirtual ~FrameSink();\n+\n+\tvirtual int configure(const libcamera::CameraConfiguration &config);\n+\n+\tvirtual void mapBuffer(libcamera::FrameBuffer *buffer);\n+\n+\tvirtual int start();\n+\tvirtual int stop();\n+\n+\tvirtual bool consumeRequest(libcamera::Request *request) = 0;\n+\tlibcamera::Signal requestReleased;\n+};\n+\n+#endif /* __CAM_FRAME_SINK_H__ */\ndiff --git a/src/cam/meson.build b/src/cam/meson.build\nindex 1e90ee521f74..649cc990d867 100644\n--- a/src/cam/meson.build\n+++ b/src/cam/meson.build\n@@ -13,6 +13,7 @@ cam_sources = files([\n 'buffer_writer.cpp',\n 'camera_session.cpp',\n 'event_loop.cpp',\n+ 'frame_sink.cpp',\n 'main.cpp',\n 'options.cpp',\n 'stream_options.cpp',\n","prefixes":["libcamera-devel","v2","2/8"]}