[{"id":18416,"web_url":"https://patchwork.libcamera.org/comment/18416/","msgid":"<20210729083424.GJ2167@pyrite.rasen.tech>","date":"2021-07-29T08:34:24","subject":"Re: [libcamera-devel] [PATCH v2 5/5] ipa: ipu3: Tidy-up includes","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn Wed, Jul 28, 2021 at 06:11:16PM +0200, Jacopo Mondi wrote:\n> Tidy-up a bit the inclusions directive in the IPU3 IPA module.\n> \n> In detail:\n> - ipu3.cpp is missing inclusions for:\n> std::abs from \n> std::map from \n> std::min/max from \n> std::numeric_limits from \n> std::unique_ptr from \n> std::vector from \n> \n> and does not require \n> \n> - ipu3_agc has two not used inclusions in the header file and one the cpp file\n> and is missing for std::literals::chrono_literals\n> \n> - ipu3_awb is missing for std::sort and does not use\n> or \n> \n> Signed-off-by: Jacopo Mondi \n> Reviewed-by: Laurent Pinchart \n> Reviewed-by: Umang Jain \n\nReviewed-by: Paul Elder \n\n> ---\n> src/ipa/ipu3/ipu3.cpp | 7 ++++++-\n> src/ipa/ipu3/ipu3_agc.cpp | 2 +-\n> src/ipa/ipu3/ipu3_agc.h | 3 ---\n> src/ipa/ipu3/ipu3_awb.cpp | 3 +--\n> 4 files changed, 8 insertions(+), 7 deletions(-)\n> \n> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> index 7a0c89ecb5fa..06dc1eb02755 100644\n> --- a/src/ipa/ipu3/ipu3.cpp\n> +++ b/src/ipa/ipu3/ipu3.cpp\n> @@ -5,10 +5,15 @@\n> * ipu3.cpp - IPU3 Image Processing Algorithms\n> */\n> \n> +#include \n> #include \n> +#include \n> +#include \n> +#include \n> +#include \n> #include \n> -#include \n> #include \n> +#include \n> \n> #include \n> #include \n> diff --git a/src/ipa/ipu3/ipu3_agc.cpp b/src/ipa/ipu3/ipu3_agc.cpp\n> index 6253ab94cff1..408eb849b428 100644\n> --- a/src/ipa/ipu3/ipu3_agc.cpp\n> +++ b/src/ipa/ipu3/ipu3_agc.cpp\n> @@ -8,8 +8,8 @@\n> #include \"ipu3_agc.h\"\n> \n> #include \n> +#include \n> #include \n> -#include \n> \n> #include \n> \n> diff --git a/src/ipa/ipu3/ipu3_agc.h b/src/ipa/ipu3/ipu3_agc.h\n> index 3deca3ae6933..9f3d4257d945 100644\n> --- a/src/ipa/ipu3/ipu3_agc.h\n> +++ b/src/ipa/ipu3/ipu3_agc.h\n> @@ -7,9 +7,6 @@\n> #ifndef __LIBCAMERA_IPU3_AGC_H__\n> #define __LIBCAMERA_IPU3_AGC_H__\n> \n> -#include \n> -#include \n> -\n> #include \n> \n> #include \n> diff --git a/src/ipa/ipu3/ipu3_awb.cpp b/src/ipa/ipu3/ipu3_awb.cpp\n> index 9b409c8ffad9..4bb321b377a2 100644\n> --- a/src/ipa/ipu3/ipu3_awb.cpp\n> +++ b/src/ipa/ipu3/ipu3_awb.cpp\n> @@ -6,9 +6,8 @@\n> */\n> #include \"ipu3_awb.h\"\n> \n> +#include \n> #include \n> -#include \n> -#include \n> \n> #include \n> \n> -- \n> 2.32.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7D126C3230\n\tfor ;\n\tThu, 29 Jul 2021 08:34:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F089D687C2;\n\tThu, 29 Jul 2021 10:34:32 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E721D68536\n\tfor ;\n\tThu, 29 Jul 2021 10:34:31 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 64753DD;\n\tThu, 29 Jul 2021 10:34:30 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"gcI1BhEQ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1627547671;\n\tbh=hUQonNVYA9X2A/e+8FfMouHm3US5oxC0kMbZYb4iRqc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=gcI1BhEQ0g2EeP4cOAC2hAmBhqCq9nNU0poTgZ3hfF+OwWya1YwoMO1cBkI4160J2\n\teaY38re2BnXHMgnwdkB2XlLYXxWYvl/Gyi264D4fJeygydNVi/p2V6JZc29jdAaq0G\n\tjYbU0edVifq4/V9ig6kSa2GiCSKfyng85WlYLeQA=","Date":"Thu, 29 Jul 2021 17:34:24 +0900","From":"paul.elder@ideasonboard.com","To":"Jacopo Mondi ","Message-ID":"<20210729083424.GJ2167@pyrite.rasen.tech>","References":"<20210728161116.64489-1-jacopo@jmondi.org>\n\t<20210728161116.64489-6-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20210728161116.64489-6-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v2 5/5] ipa: ipu3: Tidy-up includes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]