[{"id":18412,"web_url":"https://patchwork.libcamera.org/comment/18412/","msgid":"<20210729032734.GG2167@pyrite.rasen.tech>","date":"2021-07-29T03:27:34","subject":"Re: [libcamera-devel] [PATCH v2] gstreamer: Update format specifier\n\tin Request Pad template","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Vedant,\n\nOn Wed, Jul 28, 2021 at 08:07:37PM +0530, Vedant Paranjape wrote:\n> Change format specifier %s to %u in name template field of request pad\n> template.\n> \n> Pad names are as follows, src_0, src_1, etc. So, instead of using string\n> format specifier, unsigned integer format specifier is used.\n\n\", use unsigned integer format specifier.\"\n\n> \n> Signed-off-by: Vedant Paranjape \n\nMakes sense.\n\nReviewed-by: Paul Elder \n\n> ---\n> src/gstreamer/gstlibcamerasrc.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\n> index bb8ea07a..553fad02 100644\n> --- a/src/gstreamer/gstlibcamerasrc.cpp\n> +++ b/src/gstreamer/gstlibcamerasrc.cpp\n> @@ -149,7 +149,7 @@ GstStaticPadTemplate src_template = {\n> \n> /* More pads can be requested in state < PAUSED */\n> GstStaticPadTemplate request_src_template = {\n> -\t\"src_%s\", GST_PAD_SRC, GST_PAD_REQUEST, TEMPLATE_CAPS\n> +\t\"src_%u\", GST_PAD_SRC, GST_PAD_REQUEST, TEMPLATE_CAPS\n> };\n> \n> void\n> -- \n> 2.25.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 506F3C3230\n\tfor ;\n\tThu, 29 Jul 2021 03:27:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6CB82687BE;\n\tThu, 29 Jul 2021 05:27:43 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E9F026026E\n\tfor ;\n\tThu, 29 Jul 2021 05:27:41 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 67527DD;\n\tThu, 29 Jul 2021 05:27:40 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"PsCNctmD\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1627529261;\n\tbh=gv0X+3/n5OaDCdxwo0b40DfzAoZdPxDDURPv+MzjGoE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=PsCNctmDYpsVwxH6ID4wV31kjiMJ7OFyJOs87PFmcBAHPLffCn40O18yDrm+jaa3y\n\tozN+HiVaJcUdQieSKbt55VrLvwNsoBrmBdmdCfn352uaSQMvIqmKoDoi0haIySIrGY\n\toVlhjSXtSDmPkYjFL4fQHeIip694syLqhK4pA/RA=","Date":"Thu, 29 Jul 2021 12:27:34 +0900","From":"paul.elder@ideasonboard.com","To":"Vedant Paranjape ","Message-ID":"<20210729032734.GG2167@pyrite.rasen.tech>","References":"<20210728143737.510546-1-vedantparanjape160201@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20210728143737.510546-1-vedantparanjape160201@gmail.com>","Subject":"Re: [libcamera-devel] [PATCH v2] gstreamer: Update format specifier\n\tin Request Pad template","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]