[{"id":18409,"web_url":"https://patchwork.libcamera.org/comment/18409/","msgid":"<20210728163346.3ffasz22mwfbq2c7@uno.localdomain>","date":"2021-07-28T16:33:46","subject":"Re: [libcamera-devel] [PATCH v2 1/3] android: Instantiate\n\tCameraDevice after checking HAL config validity","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"On Wed, Jul 28, 2021 at 01:07:58PM +0530, Umang Jain wrote:\n> Currently CameraDevice wrapper is created first and then HAL config\n> validity is checked. If the validity checks fail, the code path will\n> simply return, in which case, creating CameraDevice seems a futile\n> exercise.\n\nIt seems to be :)\n\n>\n> This patch defers the creation of CameraDevice wrapper until the HAL\n> config validity is checked for internal cameras. This will also enable\n> us to infer a few things beforehand, by reading the config file before\n> creating the CameraDevice wrapper.\n>\n> Signed-off-by: Umang Jain \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/android/camera_hal_manager.cpp | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n>\n> diff --git a/src/android/camera_hal_manager.cpp b/src/android/camera_hal_manager.cpp\n> index 4cd67544..b364f62a 100644\n> --- a/src/android/camera_hal_manager.cpp\n> +++ b/src/android/camera_hal_manager.cpp\n> @@ -133,9 +133,6 @@ void CameraHalManager::cameraAdded(std::shared_ptr cam)\n> \t\t}\n> \t}\n>\n> -\t/* Create a CameraDevice instance to wrap the libcamera Camera. */\n> -\tstd::unique_ptr camera = CameraDevice::create(id, cam);\n> -\n> \t/*\n> \t * The configuration file must be valid, and contain a corresponding\n> \t * entry for internal cameras. External cameras can be initialized\n> @@ -155,6 +152,9 @@ void CameraHalManager::cameraAdded(std::shared_ptr cam)\n> \t\treturn;\n> \t}\n>\n> +\t/* Create a CameraDevice instance to wrap the libcamera Camera. */\n> +\tstd::unique_ptr camera = CameraDevice::create(id, cam);\n> +\n> \tint ret = camera->initialize(cameraConfigData);\n> \tif (ret) {\n> \t\tLOG(HAL, Error) << \"Failed to initialize camera: \" << cam->id();\n> --\n> 2.31.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AAC6FC3230\n\tfor ;\n\tWed, 28 Jul 2021 16:33:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1C4BE687C6;\n\tWed, 28 Jul 2021 18:33:00 +0200 (CEST)","from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9857660506\n\tfor ;\n\tWed, 28 Jul 2021 18:32:58 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 1F7DE60007;\n\tWed, 28 Jul 2021 16:32:57 +0000 (UTC)"],"Date":"Wed, 28 Jul 2021 18:33:46 +0200","From":"Jacopo Mondi ","To":"Umang Jain ","Message-ID":"<20210728163346.3ffasz22mwfbq2c7@uno.localdomain>","References":"<20210728073800.93745-1-umang.jain@ideasonboard.com>\n\t<20210728073800.93745-2-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210728073800.93745-2-umang.jain@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 1/3] android: Instantiate\n\tCameraDevice after checking HAL config validity","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":18410,"web_url":"https://patchwork.libcamera.org/comment/18410/","msgid":"","date":"2021-07-28T16:37:13","subject":"Re: [libcamera-devel] [PATCH v2 1/3] android: Instantiate\n\tCameraDevice after checking HAL config validity","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Umang,\n\nThank you for the patch.\n\nOn Wed, Jul 28, 2021 at 01:07:58PM +0530, Umang Jain wrote:\n> Currently CameraDevice wrapper is created first and then HAL config\n> validity is checked. If the validity checks fail, the code path will\n> simply return, in which case, creating CameraDevice seems a futile\n> exercise.\n> \n> This patch defers the creation of CameraDevice wrapper until the HAL\n> config validity is checked for internal cameras. This will also enable\n> us to infer a few things beforehand, by reading the config file before\n> creating the CameraDevice wrapper.\n> \n> Signed-off-by: Umang Jain \n\nThis could have been folded in 2/3, but it's fine as a separate patch.\n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/android/camera_hal_manager.cpp | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/android/camera_hal_manager.cpp b/src/android/camera_hal_manager.cpp\n> index 4cd67544..b364f62a 100644\n> --- a/src/android/camera_hal_manager.cpp\n> +++ b/src/android/camera_hal_manager.cpp\n> @@ -133,9 +133,6 @@ void CameraHalManager::cameraAdded(std::shared_ptr cam)\n> \t\t}\n> \t}\n> \n> -\t/* Create a CameraDevice instance to wrap the libcamera Camera. */\n> -\tstd::unique_ptr camera = CameraDevice::create(id, cam);\n> -\n> \t/*\n> \t * The configuration file must be valid, and contain a corresponding\n> \t * entry for internal cameras. External cameras can be initialized\n> @@ -155,6 +152,9 @@ void CameraHalManager::cameraAdded(std::shared_ptr cam)\n> \t\treturn;\n> \t}\n> \n> +\t/* Create a CameraDevice instance to wrap the libcamera Camera. */\n> +\tstd::unique_ptr camera = CameraDevice::create(id, cam);\n> +\n> \tint ret = camera->initialize(cameraConfigData);\n> \tif (ret) {\n> \t\tLOG(HAL, Error) << \"Failed to initialize camera: \" << cam->id();","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9320FC322E\n\tfor ;\n\tWed, 28 Jul 2021 16:37:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0B83A687BE;\n\tWed, 28 Jul 2021 18:37:21 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3A73160506\n\tfor ;\n\tWed, 28 Jul 2021 18:37:20 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B1DEF3F;\n\tWed, 28 Jul 2021 18:37:19 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"fZsJL8cT\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1627490239;\n\tbh=lyzt0xZNYCRh+cHYeEeE4dxdjRy4C9HE82IMWoN4VmA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=fZsJL8cTff6RO3a9c6blng+0EQdbV7RXLQTTz3ojODuY+NN0Q40pK908zO7gkOumd\n\tykQY+NzTNNmjwGkMACEgqng2sBr8W8mAnhHfyKhgmg3v1mgJKdq3culJnG7vznL5JP\n\tvWY4dGwiQfcqXf4upNaoQYvym+N3ZDP+jMYdIhpw=","Date":"Wed, 28 Jul 2021 19:37:13 +0300","From":"Laurent Pinchart ","To":"Umang Jain ","Message-ID":"","References":"<20210728073800.93745-1-umang.jain@ideasonboard.com>\n\t<20210728073800.93745-2-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210728073800.93745-2-umang.jain@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 1/3] android: Instantiate\n\tCameraDevice after checking HAL config validity","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]