{"id":13135,"url":"https://patchwork.libcamera.org/api/patches/13135/?format=json","web_url":"https://patchwork.libcamera.org/patch/13135/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210728073800.93745-2-umang.jain@ideasonboard.com>","date":"2021-07-28T07:37:58","name":"[libcamera-devel,v2,1/3] android: Instantiate CameraDevice after checking HAL config validity","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"78ccd24f9ef67b63d838427f2a45e5e6fbfeb5fd","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/?format=json","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"delegate":{"id":12,"url":"https://patchwork.libcamera.org/api/users/12/?format=json","username":"uajain","first_name":"Umang","last_name":"Jain","email":"umang.jain@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/13135/mbox/","series":[{"id":2286,"url":"https://patchwork.libcamera.org/api/series/2286/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2286","date":"2021-07-28T07:37:57","name":"android: Handle internal UVC cameras","version":2,"mbox":"https://patchwork.libcamera.org/series/2286/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/13135/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/13135/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E8D90C322E\n\tfor ;\n\tWed, 28 Jul 2021 07:38:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A2554687C9;\n\tWed, 28 Jul 2021 09:38:12 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C5072687C3\n\tfor ;\n\tWed, 28 Jul 2021 09:38:10 +0200 (CEST)","from perceval.ideasonboard.com (unknown [103.251.226.16])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D9976EE;\n\tWed, 28 Jul 2021 09:38:09 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"GuUbzq9m\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1627457890;\n\tbh=+hpWhM0B6l16KiRLpAJrn3RoLa6bI/tUegRkklt6eCc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=GuUbzq9mDSNVGaANihUHClCgGgM/8N2a33ccCTMqcwQs1ea7JFrE46hPuFwIYh4kw\n\tq4P4n1cryFLgOi0wAcsedwyAx/kbyweeX10j241bTV04T8I3RsghigkU6gKw4JGvDL\n\tifp0k0aB9U0PCcfL3qH8gg8JiSFlsBL4nTFM8YKs=","From":"Umang Jain ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 28 Jul 2021 13:07:58 +0530","Message-Id":"<20210728073800.93745-2-umang.jain@ideasonboard.com>","X-Mailer":"git-send-email 2.31.1","In-Reply-To":"<20210728073800.93745-1-umang.jain@ideasonboard.com>","References":"<20210728073800.93745-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 1/3] android: Instantiate CameraDevice\n\tafter checking HAL config validity","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Currently CameraDevice wrapper is created first and then HAL config\nvalidity is checked. If the validity checks fail, the code path will\nsimply return, in which case, creating CameraDevice seems a futile\nexercise.\n\nThis patch defers the creation of CameraDevice wrapper until the HAL\nconfig validity is checked for internal cameras. This will also enable\nus to infer a few things beforehand, by reading the config file before\ncreating the CameraDevice wrapper.\n\nSigned-off-by: Umang Jain \n---\n src/android/camera_hal_manager.cpp | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/src/android/camera_hal_manager.cpp b/src/android/camera_hal_manager.cpp\nindex 4cd67544..b364f62a 100644\n--- a/src/android/camera_hal_manager.cpp\n+++ b/src/android/camera_hal_manager.cpp\n@@ -133,9 +133,6 @@ void CameraHalManager::cameraAdded(std::shared_ptr cam)\n \t\t}\n \t}\n \n-\t/* Create a CameraDevice instance to wrap the libcamera Camera. */\n-\tstd::unique_ptr camera = CameraDevice::create(id, cam);\n-\n \t/*\n \t * The configuration file must be valid, and contain a corresponding\n \t * entry for internal cameras. External cameras can be initialized\n@@ -155,6 +152,9 @@ void CameraHalManager::cameraAdded(std::shared_ptr cam)\n \t\treturn;\n \t}\n \n+\t/* Create a CameraDevice instance to wrap the libcamera Camera. */\n+\tstd::unique_ptr camera = CameraDevice::create(id, cam);\n+\n \tint ret = camera->initialize(cameraConfigData);\n \tif (ret) {\n \t\tLOG(HAL, Error) << \"Failed to initialize camera: \" << cam->id();\n","prefixes":["libcamera-devel","v2","1/3"]}