[{"id":18399,"web_url":"https://patchwork.libcamera.org/comment/18399/","msgid":"","date":"2021-07-28T07:03:13","subject":"Re: [libcamera-devel] [PATCH v1] gstreamer: Update format specifier\n\tin Request Pad template","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Vedant,\n\nThank you for the patch.\n\nOn Wed, Jul 28, 2021 at 01:17:24AM +0530, Vedant Paranjape wrote:\n> Change format specifier %s to %u in request pad template\n\nThis is pretty obvious from the patch itself. What isn't obvious,\nhowever, is why, and that's what a commit message body should focus on.\nEvery commit message needs to answer the \"why\" question, may explain\n\"how\" when not immediately visible, and could also explain \"what\" if\nit's not obvious.\n\n> Signed-off-by: Vedant Paranjape \n> ---\n> src/gstreamer/gstlibcamerasrc.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\n> index bb8ea07a..553fad02 100644\n> --- a/src/gstreamer/gstlibcamerasrc.cpp\n> +++ b/src/gstreamer/gstlibcamerasrc.cpp\n> @@ -149,7 +149,7 @@ GstStaticPadTemplate src_template = {\n> \n> /* More pads can be requested in state < PAUSED */\n> GstStaticPadTemplate request_src_template = {\n> -\t\"src_%s\", GST_PAD_SRC, GST_PAD_REQUEST, TEMPLATE_CAPS\n> +\t\"src_%u\", GST_PAD_SRC, GST_PAD_REQUEST, TEMPLATE_CAPS\n> };\n> \n> void","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 31F55C322E\n\tfor ;\n\tWed, 28 Jul 2021 07:03:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A505A687C4;\n\tWed, 28 Jul 2021 09:03:22 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DDE81687B6\n\tfor ;\n\tWed, 28 Jul 2021 09:03:21 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EF434EE;\n\tWed, 28 Jul 2021 09:03:20 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"acgphdUn\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1627455801;\n\tbh=E4KornbLroBmpo8pUSwPvhW9CMuca1snvqwQ/v5NMog=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=acgphdUnSZgYuNOb8GZ3jIbsMf5Oqug8S6KxSNuGKOk/PKpL8RBWnDgFDuEwG9KqN\n\tOzP/Bcxjz+5LoU9TRXxdeuxVMOMAmFDmGezpG0tC2QybkrQ0EeVwUfPz5a5d31ExuZ\n\til5JCkJmEnE/dzsaKcI2+etLHTAQLL4LXifLKBRM=","Date":"Wed, 28 Jul 2021 10:03:13 +0300","From":"Laurent Pinchart ","To":"Vedant Paranjape ","Message-ID":"","References":"<20210727194724.414595-1-vedantparanjape160201@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210727194724.414595-1-vedantparanjape160201@gmail.com>","Subject":"Re: [libcamera-devel] [PATCH v1] gstreamer: Update format specifier\n\tin Request Pad template","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":18400,"web_url":"https://patchwork.libcamera.org/comment/18400/","msgid":"","date":"2021-07-28T07:06:35","subject":"Re: [libcamera-devel] [PATCH v1] gstreamer: Update format specifier\n\tin Request Pad template","submitter":{"id":85,"url":"https://patchwork.libcamera.org/api/people/85/","name":"Vedant Paranjape","email":"vedantparanjape160201@gmail.com"},"content":"Thanks for your reply. I'll update the commit message\n\nRegards,\nVedant\n\nOn Wed, 28 Jul, 2021, 12:33 Laurent Pinchart, <\nlaurent.pinchart@ideasonboard.com> wrote:\n\n> Hi Vedant,\n>\n> Thank you for the patch.\n>\n> On Wed, Jul 28, 2021 at 01:17:24AM +0530, Vedant Paranjape wrote:\n> > Change format specifier %s to %u in request pad template\n>\n> This is pretty obvious from the patch itself. What isn't obvious,\n> however, is why, and that's what a commit message body should focus on.\n> Every commit message needs to answer the \"why\" question, may explain\n> \"how\" when not immediately visible, and could also explain \"what\" if\n> it's not obvious.\n>\n> > Signed-off-by: Vedant Paranjape \n> > ---\n> > src/gstreamer/gstlibcamerasrc.cpp | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> >\n> > diff --git a/src/gstreamer/gstlibcamerasrc.cpp\n> b/src/gstreamer/gstlibcamerasrc.cpp\n> > index bb8ea07a..553fad02 100644\n> > --- a/src/gstreamer/gstlibcamerasrc.cpp\n> > +++ b/src/gstreamer/gstlibcamerasrc.cpp\n> > @@ -149,7 +149,7 @@ GstStaticPadTemplate src_template = {\n> >\n> > /* More pads can be requested in state < PAUSED */\n> > GstStaticPadTemplate request_src_template = {\n> > - \"src_%s\", GST_PAD_SRC, GST_PAD_REQUEST, TEMPLATE_CAPS\n> > + \"src_%u\", GST_PAD_SRC, GST_PAD_REQUEST, TEMPLATE_CAPS\n> > };\n> >\n> > void\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CEF6CC3230\n\tfor ;\n\tWed, 28 Jul 2021 07:06:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 469CC687C4;\n\tWed, 28 Jul 2021 09:06:50 +0200 (CEST)","from mail-yb1-xb33.google.com (mail-yb1-xb33.google.com\n\t[IPv6:2607:f8b0:4864:20::b33])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 60694687B6\n\tfor ;\n\tWed, 28 Jul 2021 09:06:48 +0200 (CEST)","by mail-yb1-xb33.google.com with SMTP id d73so2246388ybc.10\n\tfor ;\n\tWed, 28 Jul 2021 00:06:48 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"pPhE6Gy1\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=VVqpWqQ2t+COPi1O7qu+QIjtN1QJgaMzSvcF6UCnCws=;\n\tb=pPhE6Gy1U5ATJuB42UX+xwPV5Az0UuL5c755kJpfz4FSHyWA681sb2LZLqk9ggb2Pm\n\t97V9D2rJkx2+vHRF0w7E+FsYvysAwVz9PDBF6Eu2501kR5Pr5rytgnM0IrDc1XoO8PTA\n\tFaNrhKtj/wKPjp+5LAeXr+B3rMbd59yUIVcd82pbE3kRJuNiQCeHNG9cWXA4Tc7nsVda\n\t3cVpYF1fPjUnCq20v6COo59EBwbotU5T39TBXo74vhuk/hppSC2yBjsOj1rMF6OvZQhF\n\t9Fd3uYH0HuUf19MRtWuzMtw3EPm2O0WMkHudebNj2Xe9NO3We3mJgS5GkaUvVH1c6Nun\n\tyV0A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=VVqpWqQ2t+COPi1O7qu+QIjtN1QJgaMzSvcF6UCnCws=;\n\tb=EzVINLW8jufKWDTVT1cIp01G9F9cfMsBacjfLn5bSHcgtkP+05DrKytXdwGrpIhmQp\n\tcBGWodCLPlJDka4vGEHwLK9YmRhTpMjkQkd40iGr8muGA/3WktlHerYEX9w+mTqj3YXv\n\tmRCUPsrvZdmIW1VmLqWCCeDj6mdfti75gGP7bCd8yIAWOukIiH28p2x5+0mnwRQyB5+v\n\teAM0OAg+w7FbEKbuPK3tZqqkZgULW6C2eHG+7wpQcwRwHE93TXLLWigGvB2x1fpzqad2\n\tEBfew/H6ppdO30EalO8PHwkLPTSJYZjpfbPuelJ2Klv+q/guLomEF2uTbubVFu1hAkjS\n\toosQ==","X-Gm-Message-State":"AOAM533YWV6c9UdCWiy0Pi2+TadSUgknQkOhX9I3UwmNfUm5g7KPcc1p\n\tNIcB+q+45hdiqB4p3WWtsj1ICNbevG9FbBxNoeE=","X-Google-Smtp-Source":"ABdhPJx6jfx+CUjI+ZhWiVzAEk/u0VywFFEiFcmESvrDRpKgHXYCFM6Z2zxOIlTAZ2KM5OiuYE9W0EjhQ0xycP+PhWU=","X-Received":"by 2002:a25:accf:: with SMTP id\n\tx15mr24469350ybd.63.1627456006946; \n\tWed, 28 Jul 2021 00:06:46 -0700 (PDT)","MIME-Version":"1.0","References":"<20210727194724.414595-1-vedantparanjape160201@gmail.com>\n\t","In-Reply-To":"","From":"Vedant Paranjape ","Date":"Wed, 28 Jul 2021 12:36:35 +0530","Message-ID":"","To":"Laurent Pinchart ","Content-Type":"multipart/alternative; boundary=\"0000000000002e827705c829a1d2\"","Subject":"Re: [libcamera-devel] [PATCH v1] gstreamer: Update format specifier\n\tin Request Pad template","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":18445,"web_url":"https://patchwork.libcamera.org/comment/18445/","msgid":"<377d5015e957b0a98c3c05170a17e174ff878cf1.camel@ndufresne.ca>","date":"2021-07-30T20:20:20","subject":"Re: [libcamera-devel] [PATCH v1] gstreamer: Update format specifier\n\tin Request Pad template","submitter":{"id":30,"url":"https://patchwork.libcamera.org/api/people/30/","name":"Nicolas Dufresne","email":"nicolas@ndufresne.ca"},"content":"Le mercredi 28 juillet 2021 à 10:03 +0300, Laurent Pinchart a écrit :\n> Hi Vedant,\n> \n> Thank you for the patch.\n> \n> On Wed, Jul 28, 2021 at 01:17:24AM +0530, Vedant Paranjape wrote:\n> > Change format specifier %s to %u in request pad template\n> \n> This is pretty obvious from the patch itself. What isn't obvious,\n> however, is why, and that's what a commit message body should focus on.\n> Every commit message needs to answer the \"why\" question, may explain\n> \"how\" when not immediately visible, and could also explain \"what\" if\n> it's not obvious.\n> \n> > Signed-off-by: Vedant Paranjape \n> > ---\n> > src/gstreamer/gstlibcamerasrc.cpp | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > \n> > diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\n> > index bb8ea07a..553fad02 100644\n> > --- a/src/gstreamer/gstlibcamerasrc.cpp\n> > +++ b/src/gstreamer/gstlibcamerasrc.cpp\n> > @@ -149,7 +149,7 @@ GstStaticPadTemplate src_template = {\n> > \n> > /* More pads can be requested in state < PAUSED */\n> > GstStaticPadTemplate request_src_template = {\n> > -\t\"src_%s\", GST_PAD_SRC, GST_PAD_REQUEST, TEMPLATE_CAPS\n> > +\t\"src_%u\", GST_PAD_SRC, GST_PAD_REQUEST, TEMPLATE_CAPS\n\nFor the code change your got my:\n\nReviewed-by: Nicolas Dufresne \n\nSo whenever the commit is fine with Laurent, this is ready to go in. See you all\nin two weeks !\n\n> > };\n> > \n> > void\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5FD75C3232\n\tfor ;\n\tFri, 30 Jul 2021 20:20:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B5477687BF;\n\tFri, 30 Jul 2021 22:20:24 +0200 (CEST)","from mail-qk1-x72d.google.com (mail-qk1-x72d.google.com\n\t[IPv6:2607:f8b0:4864:20::72d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 44097687BE\n\tfor ;\n\tFri, 30 Jul 2021 22:20:23 +0200 (CEST)","by mail-qk1-x72d.google.com with SMTP id k7so10606417qki.11\n\tfor ;\n\tFri, 30 Jul 2021 13:20:23 -0700 (PDT)","from nicolas-tpx395.localdomain (173-246-12-168.qc.cable.ebox.net.\n\t[173.246.12.168]) by smtp.gmail.com with ESMTPSA id\n\tk7sm1441281qkj.79.2021.07.30.13.20.21\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 30 Jul 2021 13:20:21 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=ndufresne-ca.20150623.gappssmtp.com\n\theader.i=@ndufresne-ca.20150623.gappssmtp.com\n\theader.b=\"wjj6mzw7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ndufresne-ca.20150623.gappssmtp.com; s=20150623;\n\th=message-id:subject:from:to:cc:date:in-reply-to:references\n\t:user-agent:mime-version:content-transfer-encoding;\n\tbh=/j1JNqg/TF/fVmxwPOtkEDCYtiMRQJQCGO9p+Z0CcBM=;\n\tb=wjj6mzw7kkuLpT8G4e9pFI+xnKBh7GkaOZgJc1Ugg1/Xh2txbukT55Zz4j2ALLdk0v\n\tD8d9AsUWiAZ5CLrBVF+Rbr9DNjUxttBic/vmA+7VZw27vN7c39s6eWCTFe3eApfNvMMD\n\thhazugFsMSVynk0tycCBQkm60kIMfVyeAunWVndIrfCIbRaMKNw1G/aIlv6d9x0H/C96\n\tUSy4HUFB9QWE3fftCZ7XqZe7Tg7aFlGmNJW7sLP+Bjgp0N2E3XvwboOBx2XY/VNo49lI\n\t1+rfiQ8ue91PormvIylTh1q+74DkK7qRbksDyv4sdPa+t+CZ1XT61pIMZM4jXvswkpuR\n\txs4w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to\n\t:references:user-agent:mime-version:content-transfer-encoding;\n\tbh=/j1JNqg/TF/fVmxwPOtkEDCYtiMRQJQCGO9p+Z0CcBM=;\n\tb=H2dZhczuQUOQ5yGRgz0dU4F+lOskSILULE+XJSz73ZUdhBdG2i4uQo4lh4/fyJ2vBj\n\tTaPGYU9mgma1j3PAWtCmHPctg+Qy4nWV9M3eUV/MdQiY+rcY5Ei9XTY84Aku9C0F/9H1\n\tTEB2wjRhFGrVtpbw0UUOHk/+3Vhx55SuAINpDzzSB6/RaNrElodmL1xr+8u+q55/HUmk\n\tHdIGpXNt5sVwJjUJWXP43RO4eMzIWyLFs0Wa8Uer13IQSI/8CvDDhhgUPlhox3i1XvfG\n\tbv4G0Hi3w3mBIOImrBY8iQEq3T25QTtTFf2F29UBbhP4fcOxJEVEc7fjfwFnxgACwpF3\n\tRspQ==","X-Gm-Message-State":"AOAM530uR3+81oaP2Pq+yjhe76IKVfKsdrHm5n6w1O97+eFt2d57AAcv\n\tFiOkXlA6PaqanqZzvsjOuTizJg==","X-Google-Smtp-Source":"ABdhPJw7c9hyTL05bnAh8l1H5wlwxytM/5bo50fQskmjp32PUxRlyzpGRbGnnZYR0r5qTOlVcPPSjQ==","X-Received":"by 2002:ae9:c00e:: with SMTP id\n\tu14mr4141030qkk.217.1627676422120; \n\tFri, 30 Jul 2021 13:20:22 -0700 (PDT)","Message-ID":"<377d5015e957b0a98c3c05170a17e174ff878cf1.camel@ndufresne.ca>","From":"Nicolas Dufresne ","To":"Laurent Pinchart , Vedant Paranjape\n\t","Date":"Fri, 30 Jul 2021 16:20:20 -0400","In-Reply-To":"","References":"<20210727194724.414595-1-vedantparanjape160201@gmail.com>\n\t","Content-Type":"text/plain; charset=\"UTF-8\"","User-Agent":"Evolution 3.40.3 (3.40.3-1.fc34) ","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH v1] gstreamer: Update format specifier\n\tin Request Pad template","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]