[{"id":18383,"web_url":"https://patchwork.libcamera.org/comment/18383/","msgid":"","date":"2021-07-27T15:27:44","subject":"Re: [libcamera-devel] [PATCH 2/2] android: nautilus: Add camera HAL\n\tconfiguration","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Umang,\n\nThank you for the patch.\n\nOn Tue, Jul 27, 2021 at 07:24:40PM +0530, Umang Jain wrote:\n> Nautilus has two in-built cameras, one UVC and one attached to IPU3.\n> \n> Signed-off-by: Umang Jain \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/android/data/nautilus/camera_hal.yaml | 8 ++++++++\n> 1 file changed, 8 insertions(+)\n> create mode 100644 src/android/data/nautilus/camera_hal.yaml\n> \n> diff --git a/src/android/data/nautilus/camera_hal.yaml b/src/android/data/nautilus/camera_hal.yaml\n> new file mode 100644\n> index 00000000..faddd29e\n> --- /dev/null\n> +++ b/src/android/data/nautilus/camera_hal.yaml\n> @@ -0,0 +1,8 @@\n> +cameras:\n> + \"\\\\_SB_.PCI0.I2C2.CAM0\":\n> + location: back\n> + rotation: 0\n> +\n> + \"\\\\_SB_.PCI0.XHCI.RHUB.HS09-9:1.0-04f2:b647\":\n> + location: front\n> + rotation: 0","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D4046C322C\n\tfor ;\n\tTue, 27 Jul 2021 15:27:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8F550687C4;\n\tTue, 27 Jul 2021 17:27:52 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B3AAD60272\n\tfor ;\n\tTue, 27 Jul 2021 17:27:50 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4F956EE;\n\tTue, 27 Jul 2021 17:27:50 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ud9YOBWA\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1627399670;\n\tbh=R9K77pauZHJJivHfFm2JtHr8GZHnav8+srsB4ILN888=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ud9YOBWAIN43thJBZJXrHiqGsudfLdHAcY2MOCW1vy1j0716LfGqE4EdNBEnd5vd1\n\taXScseJWc0CX/BctMpbfVNLGSkKBGbqxF1RreGSETnaaYnR/BS2MMBuY4zqnR25rQ7\n\tJf5dbuvsn+e1r8Jj5spyiJF6LZea0L8w14uWiZSo=","Date":"Tue, 27 Jul 2021 18:27:44 +0300","From":"Laurent Pinchart ","To":"Umang Jain ","Message-ID":"","References":"<20210727135440.53640-1-umang.jain@ideasonboard.com>\n\t<20210727135440.53640-3-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210727135440.53640-3-umang.jain@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 2/2] android: nautilus: Add camera HAL\n\tconfiguration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":18386,"web_url":"https://patchwork.libcamera.org/comment/18386/","msgid":"<3ba5f5fb-75dd-f204-626c-04338257a3cc@ideasonboard.com>","date":"2021-07-27T15:41:18","subject":"Re: [libcamera-devel] [PATCH 2/2] android: nautilus: Add camera HAL\n\tconfiguration","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 27/07/2021 16:27, Laurent Pinchart wrote:\n> Hi Umang,\n> \n> Thank you for the patch.\n> \n> On Tue, Jul 27, 2021 at 07:24:40PM +0530, Umang Jain wrote:\n>> Nautilus has two in-built cameras, one UVC and one attached to IPU3.\n>>\n>> Signed-off-by: Umang Jain \n> \n> Reviewed-by: Laurent Pinchart \n\nAnd\n\nReviewed-by: Kieran Bingham \n\n> \n>> ---\n>> src/android/data/nautilus/camera_hal.yaml | 8 ++++++++\n>> 1 file changed, 8 insertions(+)\n>> create mode 100644 src/android/data/nautilus/camera_hal.yaml\n>>\n>> diff --git a/src/android/data/nautilus/camera_hal.yaml b/src/android/data/nautilus/camera_hal.yaml\n>> new file mode 100644\n>> index 00000000..faddd29e\n>> --- /dev/null\n>> +++ b/src/android/data/nautilus/camera_hal.yaml\n>> @@ -0,0 +1,8 @@\n>> +cameras:\n>> + \"\\\\_SB_.PCI0.I2C2.CAM0\":\n>> + location: back\n>> + rotation: 0\n>> +\n>> + \"\\\\_SB_.PCI0.XHCI.RHUB.HS09-9:1.0-04f2:b647\":\n>> + location: front\n>> + rotation: 0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 183A3C322C\n\tfor ;\n\tTue, 27 Jul 2021 15:41:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 757DC687C6;\n\tTue, 27 Jul 2021 17:41:22 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 92E6060272\n\tfor ;\n\tTue, 27 Jul 2021 17:41:21 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1375AEE;\n\tTue, 27 Jul 2021 17:41:21 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"RiJMTqlm\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1627400481;\n\tbh=o99f5f3ZbsFqXHgjmsH4zL/ar/5DN8ffhk356VI77jY=;\n\th=Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=RiJMTqlmnNiZFhv13Wsm0oRpXuIMOtWV+oVzrJP3tu99TL72G0VMWKdjj8CB+hu/Z\n\tKFVpXRwYY8TVJfnxXzWJ7QfpTPoLCs+FUJMQhtan/U9HeXmLbYl4T1bc62XDrKoQ45\n\twKeiEpDAmRauhOThOiyaOiMkAlem3RHcg7Ymx1ck=","To":"Laurent Pinchart ,\n\tUmang Jain ","References":"<20210727135440.53640-1-umang.jain@ideasonboard.com>\n\t<20210727135440.53640-3-umang.jain@ideasonboard.com>\n\t","From":"Kieran Bingham ","Message-ID":"<3ba5f5fb-75dd-f204-626c-04338257a3cc@ideasonboard.com>","Date":"Tue, 27 Jul 2021 16:41:18 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.11.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 2/2] android: nautilus: Add camera HAL\n\tconfiguration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]