[{"id":18350,"web_url":"https://patchwork.libcamera.org/comment/18350/","msgid":"<20210726095535.qrax5qsq3jycc3vz@uno.localdomain>","date":"2021-07-26T09:55:35","subject":"Re: [libcamera-devel] [PATCH v2 4/5] libcamera: file: Use Flags<>\n\tclass for open flags","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"On Sun, Jul 25, 2021 at 08:18:26PM +0300, Laurent Pinchart wrote:\n> Use the newly introduced Flags<> class to store a bitfield of\n> File::OpenMode in a type-safe way. The existing File::OpenMode enum is\n> renamed to File::OpenModeFlag to free the File::OpenMode for the Flags<>\n> type alias.\n>\n\nAfter reading 5/5 please add\nReviewed-by: Jacopo Mondi \n\nTo this and 3/5\n\nThanks\n j\n\n> Signed-off-by: Laurent Pinchart \n> ---\n> Changes since v1:\n>\n> - Don't enable bitwise operators on File::OpenMode\n> ---\n> include/libcamera/base/file.h | 4 +++-\n> src/libcamera/base/file.cpp | 9 +++++++--\n> 2 files changed, 10 insertions(+), 3 deletions(-)\n>\n> diff --git a/include/libcamera/base/file.h b/include/libcamera/base/file.h\n> index 452a658b409f..eebb24024025 100644\n> --- a/include/libcamera/base/file.h\n> +++ b/include/libcamera/base/file.h\n> @@ -30,13 +30,15 @@ public:\n>\n> \tusing MapFlags = Flags;\n>\n> -\tenum OpenMode {\n> +\tenum OpenModeFlag {\n> \t\tNotOpen = 0,\n> \t\tReadOnly = (1 << 0),\n> \t\tWriteOnly = (1 << 1),\n> \t\tReadWrite = ReadOnly | WriteOnly,\n> \t};\n>\n> +\tusing OpenMode = Flags;\n> +\n> \tFile(const std::string &name);\n> \tFile();\n> \t~File();\n> diff --git a/src/libcamera/base/file.cpp b/src/libcamera/base/file.cpp\n> index e180c5479098..0860457421a1 100644\n> --- a/src/libcamera/base/file.cpp\n> +++ b/src/libcamera/base/file.cpp\n> @@ -58,7 +58,7 @@ LOG_DEFINE_CATEGORY(File)\n> */\n>\n> /**\n> - * \\enum File::OpenMode\n> + * \\enum File::OpenModeFlag\n> * \\brief Mode in which a file is opened\n> * \\var File::NotOpen\n> * \\brief The file is not open\n> @@ -70,6 +70,11 @@ LOG_DEFINE_CATEGORY(File)\n> * \\brief The file is open for reading and writing\n> */\n>\n> +/**\n> + * \\typedef File::OpenMode\n> + * \\brief An OR combination of File::OpenModeFlag values\n> + */\n> +\n> /**\n> * \\brief Construct a File to represent the file \\a name\n> * \\param[in] name The file name\n> @@ -168,7 +173,7 @@ bool File::open(File::OpenMode mode)\n> \t\treturn false;\n> \t}\n>\n> -\tint flags = (mode & ReadWrite) - 1;\n> +\tint flags = static_cast(mode & ReadWrite) - 1;\n> \tif (mode & WriteOnly)\n> \t\tflags |= O_CREAT;\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 343A2C322C\n\tfor ;\n\tMon, 26 Jul 2021 09:54:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id ECEA6687BA;\n\tMon, 26 Jul 2021 11:54:49 +0200 (CEST)","from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net\n\t[217.70.183.201])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 24DB460272\n\tfor ;\n\tMon, 26 Jul 2021 11:54:49 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 9B4721BF206;\n\tMon, 26 Jul 2021 09:54:48 +0000 (UTC)"],"Date":"Mon, 26 Jul 2021 11:55:35 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Message-ID":"<20210726095535.qrax5qsq3jycc3vz@uno.localdomain>","References":"<20210725171827.23643-1-laurent.pinchart@ideasonboard.com>\n\t<20210725171827.23643-5-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210725171827.23643-5-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 4/5] libcamera: file: Use Flags<>\n\tclass for open flags","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]