[{"id":18336,"web_url":"https://patchwork.libcamera.org/comment/18336/","msgid":"<20210726042003.GF63622@pyrite.rasen.tech>","date":"2021-07-26T04:20:03","subject":"Re: [libcamera-devel] [PATCH] libcamera: CameraSensorProperties:\n\tSort entries","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Laurent,\n\nOn Sun, Jul 25, 2021 at 02:48:55AM +0300, Laurent Pinchart wrote:\n> Keep entries sorted by sensor name to ensure the file stays readable.\n\nThis was bugging me for a while :)\n\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> src/libcamera/camera_sensor_properties.cpp | 28 +++++++++++-----------\n> 1 file changed, 14 insertions(+), 14 deletions(-)\n> \n> diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\n> index c6f383e0ac03..4ee45e72e8a8 100644\n> --- a/src/libcamera/camera_sensor_properties.cpp\n> +++ b/src/libcamera/camera_sensor_properties.cpp\n> @@ -72,24 +72,17 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> \t\t\t\t{ 4, controls::draft::TestPatternModePn9 },\n> \t\t\t},\n> \t\t} },\n> -\t\t{ \"ov5670\", {\n> -\t\t\t.unitCellSize = { 1120, 1120 },\n> -\t\t\t.testPatternModes = {\n> -\t\t\t\t{ 0, controls::draft::TestPatternModeOff },\n> -\t\t\t\t{ 1, controls::draft::TestPatternModeColorBars },\n> -\t\t\t},\n> -\t\t} },\n> -\t\t{ \"ov13858\", {\n> -\t\t\t.unitCellSize = { 1120, 1120 },\n> -\t\t\t.testPatternModes = {\n> -\t\t\t\t{ 0, controls::draft::TestPatternModeOff },\n> -\t\t\t\t{ 1, controls::draft::TestPatternModeColorBars },\n> -\t\t\t},\n> -\t\t} },\n> \t\t{ \"ov5647\", {\n> \t\t\t.unitCellSize = { 1400, 1400 },\n> \t\t\t.testPatternModes = {},\n> \t\t} },\n> +\t\t{ \"ov5670\", {\n> +\t\t\t.unitCellSize = { 1120, 1120 },\n> +\t\t\t.testPatternModes = {\n> +\t\t\t\t{ 0, controls::draft::TestPatternModeOff },\n> +\t\t\t\t{ 1, controls::draft::TestPatternModeColorBars },\n> +\t\t\t},\n> +\t\t} },\n> \t\t{ \"ov5693\", {\n> \t\t\t.unitCellSize = { 1400, 1400 },\n> \t\t\t.testPatternModes = {\n> @@ -116,6 +109,13 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> \t\t\t\t */\n> \t\t\t},\n> \t\t} },\n> +\t\t{ \"ov13858\", {\n> +\t\t\t.unitCellSize = { 1120, 1120 },\n> +\t\t\t.testPatternModes = {\n> +\t\t\t\t{ 0, controls::draft::TestPatternModeOff },\n> +\t\t\t\t{ 1, controls::draft::TestPatternModeColorBars },\n> +\t\t\t},\n> +\t\t} },\n> \t};\n> \n> \tconst auto it = sensorProps.find(sensor);\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BFE51C322C\n\tfor ;\n\tMon, 26 Jul 2021 04:20:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 14D0E687B8;\n\tMon, 26 Jul 2021 06:20:14 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DCAAD60507\n\tfor ;\n\tMon, 26 Jul 2021 06:20:11 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 58529332;\n\tMon, 26 Jul 2021 06:20:10 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"o4KkQF47\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1627273211;\n\tbh=D3PZNrSRvK158O+P2Oyj0PbDeYT187GxaQOauAuu4Z8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=o4KkQF47ozPTRfsxS0JtA1I8yhZQ0236/FthJWcSR3Bz6R5ymvBwPIOG2r1A2S/fN\n\tA9JKEQMCRbUCZ1blalwFv9tsPA7WiN0wF/B9R+Z8t/3lUnrMAGNGkPhs20PrmeD0Cd\n\tIq2SZ25tWEUrc0FaR/IrS9XvM9LPuv54YG1x+Fss=","Date":"Mon, 26 Jul 2021 13:20:03 +0900","From":"paul.elder@ideasonboard.com","To":"Laurent Pinchart ","Message-ID":"<20210726042003.GF63622@pyrite.rasen.tech>","References":"<20210724234855.30910-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20210724234855.30910-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: CameraSensorProperties:\n\tSort entries","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":18337,"web_url":"https://patchwork.libcamera.org/comment/18337/","msgid":"<20210726081253.3wz5ugiifjfrbzoa@uno.localdomain>","date":"2021-07-26T08:12:53","subject":"Re: [libcamera-devel] [PATCH] libcamera: CameraSensorProperties:\n\tSort entries","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Mon, Jul 26, 2021 at 01:20:03PM +0900, paul.elder@ideasonboard.com wrote:\n> Hi Laurent,\n>\n> On Sun, Jul 25, 2021 at 02:48:55AM +0300, Laurent Pinchart wrote:\n> > Keep entries sorted by sensor name to ensure the file stays readable.\n>\n> This was bugging me for a while :)\n>\n> >\n> > Signed-off-by: Laurent Pinchart \n>\n> Reviewed-by: Paul Elder \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n>\n> > ---\n> > src/libcamera/camera_sensor_properties.cpp | 28 +++++++++++-----------\n> > 1 file changed, 14 insertions(+), 14 deletions(-)\n> >\n> > diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\n> > index c6f383e0ac03..4ee45e72e8a8 100644\n> > --- a/src/libcamera/camera_sensor_properties.cpp\n> > +++ b/src/libcamera/camera_sensor_properties.cpp\n> > @@ -72,24 +72,17 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> > \t\t\t\t{ 4, controls::draft::TestPatternModePn9 },\n> > \t\t\t},\n> > \t\t} },\n> > -\t\t{ \"ov5670\", {\n> > -\t\t\t.unitCellSize = { 1120, 1120 },\n> > -\t\t\t.testPatternModes = {\n> > -\t\t\t\t{ 0, controls::draft::TestPatternModeOff },\n> > -\t\t\t\t{ 1, controls::draft::TestPatternModeColorBars },\n> > -\t\t\t},\n> > -\t\t} },\n> > -\t\t{ \"ov13858\", {\n> > -\t\t\t.unitCellSize = { 1120, 1120 },\n> > -\t\t\t.testPatternModes = {\n> > -\t\t\t\t{ 0, controls::draft::TestPatternModeOff },\n> > -\t\t\t\t{ 1, controls::draft::TestPatternModeColorBars },\n> > -\t\t\t},\n> > -\t\t} },\n> > \t\t{ \"ov5647\", {\n> > \t\t\t.unitCellSize = { 1400, 1400 },\n> > \t\t\t.testPatternModes = {},\n> > \t\t} },\n> > +\t\t{ \"ov5670\", {\n> > +\t\t\t.unitCellSize = { 1120, 1120 },\n> > +\t\t\t.testPatternModes = {\n> > +\t\t\t\t{ 0, controls::draft::TestPatternModeOff },\n> > +\t\t\t\t{ 1, controls::draft::TestPatternModeColorBars },\n> > +\t\t\t},\n> > +\t\t} },\n> > \t\t{ \"ov5693\", {\n> > \t\t\t.unitCellSize = { 1400, 1400 },\n> > \t\t\t.testPatternModes = {\n> > @@ -116,6 +109,13 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> > \t\t\t\t */\n> > \t\t\t},\n> > \t\t} },\n> > +\t\t{ \"ov13858\", {\n> > +\t\t\t.unitCellSize = { 1120, 1120 },\n> > +\t\t\t.testPatternModes = {\n> > +\t\t\t\t{ 0, controls::draft::TestPatternModeOff },\n> > +\t\t\t\t{ 1, controls::draft::TestPatternModeColorBars },\n> > +\t\t\t},\n> > +\t\t} },\n> > \t};\n> >\n> > \tconst auto it = sensorProps.find(sensor);\n> > --\n> > Regards,\n> >\n> > Laurent Pinchart\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E6113C0109\n\tfor ;\n\tMon, 26 Jul 2021 08:12:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5E1AF687B5;\n\tMon, 26 Jul 2021 10:12:07 +0200 (CEST)","from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 96791687B3\n\tfor ;\n\tMon, 26 Jul 2021 10:12:06 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay2-d.mail.gandi.net (Postfix) with ESMTPSA id EBC974000C;\n\tMon, 26 Jul 2021 08:12:05 +0000 (UTC)"],"Date":"Mon, 26 Jul 2021 10:12:53 +0200","From":"Jacopo Mondi ","To":"paul.elder@ideasonboard.com","Message-ID":"<20210726081253.3wz5ugiifjfrbzoa@uno.localdomain>","References":"<20210724234855.30910-1-laurent.pinchart@ideasonboard.com>\n\t<20210726042003.GF63622@pyrite.rasen.tech>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210726042003.GF63622@pyrite.rasen.tech>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: CameraSensorProperties:\n\tSort entries","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":18342,"web_url":"https://patchwork.libcamera.org/comment/18342/","msgid":"","date":"2021-07-26T08:48:59","subject":"Re: [libcamera-devel] [PATCH] libcamera: CameraSensorProperties:\n\tSort entries","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nOn Mon, Jul 26, 2021 at 01:20:03PM +0900, paul.elder@ideasonboard.com wrote:\n> On Sun, Jul 25, 2021 at 02:48:55AM +0300, Laurent Pinchart wrote:\n> > Keep entries sorted by sensor name to ensure the file stays readable.\n> \n> This was bugging me for a while :)\n\nYou could have sent a patch ;-)\n\nThanks for the review.\n\n> > Signed-off-by: Laurent Pinchart \n> \n> Reviewed-by: Paul Elder \n> \n> > ---\n> > src/libcamera/camera_sensor_properties.cpp | 28 +++++++++++-----------\n> > 1 file changed, 14 insertions(+), 14 deletions(-)\n> > \n> > diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\n> > index c6f383e0ac03..4ee45e72e8a8 100644\n> > --- a/src/libcamera/camera_sensor_properties.cpp\n> > +++ b/src/libcamera/camera_sensor_properties.cpp\n> > @@ -72,24 +72,17 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> > \t\t\t\t{ 4, controls::draft::TestPatternModePn9 },\n> > \t\t\t},\n> > \t\t} },\n> > -\t\t{ \"ov5670\", {\n> > -\t\t\t.unitCellSize = { 1120, 1120 },\n> > -\t\t\t.testPatternModes = {\n> > -\t\t\t\t{ 0, controls::draft::TestPatternModeOff },\n> > -\t\t\t\t{ 1, controls::draft::TestPatternModeColorBars },\n> > -\t\t\t},\n> > -\t\t} },\n> > -\t\t{ \"ov13858\", {\n> > -\t\t\t.unitCellSize = { 1120, 1120 },\n> > -\t\t\t.testPatternModes = {\n> > -\t\t\t\t{ 0, controls::draft::TestPatternModeOff },\n> > -\t\t\t\t{ 1, controls::draft::TestPatternModeColorBars },\n> > -\t\t\t},\n> > -\t\t} },\n> > \t\t{ \"ov5647\", {\n> > \t\t\t.unitCellSize = { 1400, 1400 },\n> > \t\t\t.testPatternModes = {},\n> > \t\t} },\n> > +\t\t{ \"ov5670\", {\n> > +\t\t\t.unitCellSize = { 1120, 1120 },\n> > +\t\t\t.testPatternModes = {\n> > +\t\t\t\t{ 0, controls::draft::TestPatternModeOff },\n> > +\t\t\t\t{ 1, controls::draft::TestPatternModeColorBars },\n> > +\t\t\t},\n> > +\t\t} },\n> > \t\t{ \"ov5693\", {\n> > \t\t\t.unitCellSize = { 1400, 1400 },\n> > \t\t\t.testPatternModes = {\n> > @@ -116,6 +109,13 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> > \t\t\t\t */\n> > \t\t\t},\n> > \t\t} },\n> > +\t\t{ \"ov13858\", {\n> > +\t\t\t.unitCellSize = { 1120, 1120 },\n> > +\t\t\t.testPatternModes = {\n> > +\t\t\t\t{ 0, controls::draft::TestPatternModeOff },\n> > +\t\t\t\t{ 1, controls::draft::TestPatternModeColorBars },\n> > +\t\t\t},\n> > +\t\t} },\n> > \t};\n> > \n> > \tconst auto it = sensorProps.find(sensor);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2E4BBC0109\n\tfor ;\n\tMon, 26 Jul 2021 08:49:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 89EF5687B8;\n\tMon, 26 Jul 2021 10:49:05 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5D7A3687B3\n\tfor ;\n\tMon, 26 Jul 2021 10:49:04 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id ACD533F;\n\tMon, 26 Jul 2021 10:49:03 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"QzmB4gng\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1627289344;\n\tbh=7yROdibFg+fm3pFPDAcnzD0kOVZDiEbySU95BBUfPK0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=QzmB4gngQvXFhMUaVHzZMvIentDBdzcY94bJV47S5j+nYuXrrZk9rzGUVVpjOpXHF\n\tkdx/ATM+XXjTUTW2prdDuppO76xlcu8dWxzIbgLmbhEs+uj6mYXAZ7W5w6weAlsTG/\n\tuhJv97eWIqqTdVVoVs9vu/fcrijpZ87vtLRtjK6s=","Date":"Mon, 26 Jul 2021 11:48:59 +0300","From":"Laurent Pinchart ","To":"paul.elder@ideasonboard.com","Message-ID":"","References":"<20210724234855.30910-1-laurent.pinchart@ideasonboard.com>\n\t<20210726042003.GF63622@pyrite.rasen.tech>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210726042003.GF63622@pyrite.rasen.tech>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: CameraSensorProperties:\n\tSort entries","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]