[{"id":18322,"web_url":"https://patchwork.libcamera.org/comment/18322/","msgid":"","date":"2021-07-24T23:20:25","subject":"Re: [libcamera-devel] [PATCH] android: nautilus: Add camera HAL\n\tconfiguration","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Umang,\n\nThank you for the patch.\n\nOn Sat, Jul 24, 2021 at 02:51:47PM +0530, Umang Jain wrote:\n> Nautilus has two in-built cameras, one UVC and one attached to IPU3.\n> However, libcamera assumes all UVC cameras as 'external' [1] hence,\n> mark the location of UVC camera in HAL configuration as 'external' too.\n\nThat's not right thought, this particular camera isn't external. What\nwould it take to fix it ?\n\n> [1] 76809320bb1a (\"libcamera: pipeline: uvcvideo: Treat all UVC cameras as external\")\n> \n> Signed-off-by: Umang Jain \n> ---\n> src/android/data/nautilus/camera_hal.yaml | 8 ++++++++\n> 1 file changed, 8 insertions(+)\n> create mode 100644 src/android/data/nautilus/camera_hal.yaml\n> \n> diff --git a/src/android/data/nautilus/camera_hal.yaml b/src/android/data/nautilus/camera_hal.yaml\n> new file mode 100644\n> index 00000000..f2d31e1c\n> --- /dev/null\n> +++ b/src/android/data/nautilus/camera_hal.yaml\n> @@ -0,0 +1,8 @@\n> +cameras:\n> + \"\\\\_SB_.PCI0.I2C2.CAM0\":\n> + location: back\n> + rotation: 0\n> +\n> + \"\\\\_SB_.PCI0.XHCI.RHUB.HS09-9:1.0-04f2:b647\":\n> + location: external\n> + rotation: 0","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A8DF4C322C\n\tfor ;\n\tSat, 24 Jul 2021 23:20:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2B771687B2;\n\tSun, 25 Jul 2021 01:20:31 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D55B268537\n\tfor ;\n\tSun, 25 Jul 2021 01:20:29 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 59F07255;\n\tSun, 25 Jul 2021 01:20:29 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"wYvOyum0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1627168829;\n\tbh=SkL2HhXsrKctg049GGJDpDzJs0HEi7eS62E7xc2c7uo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=wYvOyum0lfbSsWnn3vk8Qstkn6/1i7FZKpC1mFxfVoEeZ4yeP+gJxLb/vNr6HJwJT\n\tIn3nCW+s/Dt9s1TZTr3A91ac3UlMwqXXVI7aqlb67EwnsqVt6AuH2mO9XTki4xDtOe\n\tvxpSvV9Tyv6gO0tEoUBGxvpbIRc1yibnpPQDi270=","Date":"Sun, 25 Jul 2021 02:20:25 +0300","From":"Laurent Pinchart ","To":"Umang Jain ","Message-ID":"","References":"<20210724092147.36896-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210724092147.36896-1-umang.jain@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] android: nautilus: Add camera HAL\n\tconfiguration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":18353,"web_url":"https://patchwork.libcamera.org/comment/18353/","msgid":"<98842682-ed35-fe50-1ead-fa6c81e83f79@ideasonboard.com>","date":"2021-07-26T10:20:36","subject":"Re: [libcamera-devel] [PATCH] android: nautilus: Add camera HAL\n\tconfiguration","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Umang,\n\nOn 24/07/2021 10:21, Umang Jain wrote:\n> Nautilus has two in-built cameras, one UVC and one attached to IPU3.\n> However, libcamera assumes all UVC cameras as 'external' [1] hence,\n> mark the location of UVC camera in HAL configuration as 'external' too.\n> \n> [1] 76809320bb1a (\"libcamera: pipeline: uvcvideo: Treat all UVC cameras as external\")\n> \n> Signed-off-by: Umang Jain \n> ---\n> src/android/data/nautilus/camera_hal.yaml | 8 ++++++++\n> 1 file changed, 8 insertions(+)\n> create mode 100644 src/android/data/nautilus/camera_hal.yaml\n> \n> diff --git a/src/android/data/nautilus/camera_hal.yaml b/src/android/data/nautilus/camera_hal.yaml\n> new file mode 100644\n> index 00000000..f2d31e1c\n> --- /dev/null\n> +++ b/src/android/data/nautilus/camera_hal.yaml\n> @@ -0,0 +1,8 @@\n> +cameras:\n> + \"\\\\_SB_.PCI0.I2C2.CAM0\":\n> + location: back\n> + rotation: 0\n> +\n> + \"\\\\_SB_.PCI0.XHCI.RHUB.HS09-9:1.0-04f2:b647\":\n> + location: external\n\nThe purpose of this file is to allow the distribution to correctly\nspecify the location, so we don't need to follow the 'default' location\n- instead in this file we should be telling the system the correct\nlocation (which could otherwise not be determined from a UVC camera).\n\nSo I assume this is the 'front' camera ...\n\n--\nKieran\n\n> + rotation: 0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7A18FC322C\n\tfor ;\n\tMon, 26 Jul 2021 10:20:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E5CB8687B3;\n\tMon, 26 Jul 2021 12:20:39 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D8E4068536\n\tfor ;\n\tMon, 26 Jul 2021 12:20:38 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5BED8332;\n\tMon, 26 Jul 2021 12:20:38 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"CkOBVvna\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1627294838;\n\tbh=vuWw5QPgO9fQSU6F2VkxoYJzABtUfSBgYLlM+LE28Tk=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=CkOBVvnaJyNhqFjk2yg/EnmpEWJNXEbjQeY0p+dew3n8qpH9xd9wmWj7iZSzUEFSJ\n\ttqoCe6ksQLl2daTdgEhBmkn/o5cZBFxdgOrZl0H4DjIy8GKC1MdO+PODv5FsjkSC67\n\t0fLFKabrO7jgH+McCdV81MqkOPisFkSqITVIXH1c=","To":"Umang Jain ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210724092147.36896-1-umang.jain@ideasonboard.com>","From":"Kieran Bingham ","Message-ID":"<98842682-ed35-fe50-1ead-fa6c81e83f79@ideasonboard.com>","Date":"Mon, 26 Jul 2021 11:20:36 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.11.0","MIME-Version":"1.0","In-Reply-To":"<20210724092147.36896-1-umang.jain@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] android: nautilus: Add camera HAL\n\tconfiguration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":18358,"web_url":"https://patchwork.libcamera.org/comment/18358/","msgid":"<225cebcf-9e4d-5528-5829-217ee89742f6@ideasonboard.com>","date":"2021-07-26T10:42:12","subject":"Re: [libcamera-devel] [PATCH] android: nautilus: Add camera HAL\n\tconfiguration","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Kieran and Laurent,\n\nOn 7/26/21 3:50 PM, Kieran Bingham wrote:\n> Hi Umang,\n>\n> On 24/07/2021 10:21, Umang Jain wrote:\n>> Nautilus has two in-built cameras, one UVC and one attached to IPU3.\n>> However, libcamera assumes all UVC cameras as 'external' [1] hence,\n>> mark the location of UVC camera in HAL configuration as 'external' too.\n>>\n>> [1] 76809320bb1a (\"libcamera: pipeline: uvcvideo: Treat all UVC cameras as external\")\n>>\n>> Signed-off-by: Umang Jain \n>> ---\n>> src/android/data/nautilus/camera_hal.yaml | 8 ++++++++\n>> 1 file changed, 8 insertions(+)\n>> create mode 100644 src/android/data/nautilus/camera_hal.yaml\n>>\n>> diff --git a/src/android/data/nautilus/camera_hal.yaml b/src/android/data/nautilus/camera_hal.yaml\n>> new file mode 100644\n>> index 00000000..f2d31e1c\n>> --- /dev/null\n>> +++ b/src/android/data/nautilus/camera_hal.yaml\n>> @@ -0,0 +1,8 @@\n>> +cameras:\n>> + \"\\\\_SB_.PCI0.I2C2.CAM0\":\n>> + location: back\n>> + rotation: 0\n>> +\n>> + \"\\\\_SB_.PCI0.XHCI.RHUB.HS09-9:1.0-04f2:b647\":\n>> + location: external\n> The purpose of this file is to allow the distribution to correctly\n> specify the location, so we don't need to follow the 'default' location\n> - instead in this file we should be telling the system the correct\n> location (which could otherwise not be determined from a UVC camera).\n\nYes, I am aware of that. I still need to investigate what changes are \nrequired to actually mark it one of 'front/back' internal cameras. You \nmight be aware that we assign ids to cameras, internal ones starting \nfrom '0' and external ones from '1000'.\n\nWe do have checks based on these ids, look at CameraHalManager. Hence, \nif we let HAL config file dictate that this is a internal(front or back) \ncamera, still we need to take care how we will address it's id (we can't \nhave a situation where HAL config file says the camera is internal, but \nit's id > 1000). One option is to probably remove these id-based checks \nand re-generate these checks whatever is in HAL config location. Hence, \nneed to investigate that, as what would be the paths forwards. I'll come \nup with a few solutions to discuss as soon as I get some time.\n\n>\n> So I assume this is the 'front' camera ...\n>\n> --\n> Kieran\n>\n>> + rotation: 0\n>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E9E86C322C\n\tfor ;\n\tMon, 26 Jul 2021 10:42:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 597A0687BF;\n\tMon, 26 Jul 2021 12:42:18 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E4F0A687AF\n\tfor ;\n\tMon, 26 Jul 2021 12:42:17 +0200 (CEST)","from [192.168.0.107] (unknown [103.251.226.156])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D5014332;\n\tMon, 26 Jul 2021 12:42:16 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rGQ1kqx+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1627296137;\n\tbh=ZqwZxR+7TVQktkbsCkCAb07FekMrq+Xq2vkhqS0zLy0=;\n\th=Subject:To:References:Cc:From:Date:In-Reply-To:From;\n\tb=rGQ1kqx+6E4TtuuFxAT+7zuOpLhSC5+ceRPvXkJ8Ith2CWmZB5IgIE+AuMFRKssRr\n\tG+2qoEzAaNol5Z0s5YCNT51q2sqCr18aUCKeTTmyLk0ElfAH4I95XhzNUCImpxFN1M\n\tvNU26oh5OvSaLAnHJIkQnM80ENWt9FKso61sZhZM=","To":"Kieran Bingham ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210724092147.36896-1-umang.jain@ideasonboard.com>\n\t<98842682-ed35-fe50-1ead-fa6c81e83f79@ideasonboard.com>","From":"Umang Jain ","Message-ID":"<225cebcf-9e4d-5528-5829-217ee89742f6@ideasonboard.com>","Date":"Mon, 26 Jul 2021 16:12:12 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.10.2","MIME-Version":"1.0","In-Reply-To":"<98842682-ed35-fe50-1ead-fa6c81e83f79@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH] android: nautilus: Add camera HAL\n\tconfiguration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":18359,"web_url":"https://patchwork.libcamera.org/comment/18359/","msgid":"","date":"2021-07-26T10:52:47","subject":"Re: [libcamera-devel] [PATCH] android: nautilus: Add camera HAL\n\tconfiguration","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Umang,\n\nOn 26/07/2021 11:42, Umang Jain wrote:\n> Hi Kieran and Laurent,\n> \n> On 7/26/21 3:50 PM, Kieran Bingham wrote:\n>> Hi Umang,\n>>\n>> On 24/07/2021 10:21, Umang Jain wrote:\n>>> Nautilus has two in-built cameras, one UVC and one attached to IPU3.\n>>> However, libcamera assumes all UVC cameras as 'external' [1] hence,\n>>> mark the location of UVC camera in HAL configuration as 'external' too.\n>>>\n>>> [1] 76809320bb1a (\"libcamera: pipeline: uvcvideo: Treat all UVC\n>>> cameras as external\")\n>>>\n>>> Signed-off-by: Umang Jain \n>>> ---\n>>>   src/android/data/nautilus/camera_hal.yaml | 8 ++++++++\n>>>   1 file changed, 8 insertions(+)\n>>>   create mode 100644 src/android/data/nautilus/camera_hal.yaml\n>>>\n>>> diff --git a/src/android/data/nautilus/camera_hal.yaml\n>>> b/src/android/data/nautilus/camera_hal.yaml\n>>> new file mode 100644\n>>> index 00000000..f2d31e1c\n>>> --- /dev/null\n>>> +++ b/src/android/data/nautilus/camera_hal.yaml\n>>> @@ -0,0 +1,8 @@\n>>> +cameras:\n>>> +  \"\\\\_SB_.PCI0.I2C2.CAM0\":\n>>> +    location: back\n>>> +    rotation: 0\n>>> +\n>>> +  \"\\\\_SB_.PCI0.XHCI.RHUB.HS09-9:1.0-04f2:b647\":\n>>> +    location: external\n>> The purpose of this file is to allow the distribution to correctly\n>> specify the location, so we don't need to follow the 'default' location\n>> - instead in this file we should be telling the system the correct\n>> location (which could otherwise not be determined from a UVC camera).\n> \n> Yes, I am aware of that. I still need to investigate what changes are\n> required to actually mark it one of 'front/back' internal cameras. You\n> might be aware that we assign ids to cameras, internal ones starting\n> from '0' and external ones from '1000'.\n> \n> We do have checks based on these ids, look at CameraHalManager. Hence,\n> if we let HAL config file dictate that this is a internal(front or back)\n> camera, still we need to take care how we will address it's id (we can't\n> have a situation where HAL config file says the camera is internal, but\n> it's id > 1000). One option is to probably remove these id-based checks\n> and re-generate these checks whatever is in HAL config location. Hence,\n> need to investigate that, as what would be the paths forwards. I'll come\n> up with a few solutions to discuss as soon as I get some time.\n\nAh, ok - so if you set this to front it causes some failures?\n\nThat's troublesome indeed ...\n\nDoes the location need to be parsed before we set those IDs?\n(I guess it doesn't currently?)\n\n--\nKieran\n\n\n>>\n>> So I assume this is the 'front' camera ...\n>>\n>> -- \n>> Kieran\n>>\n>>> +    rotation: 0\n>>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 54ADCC0109\n\tfor ;\n\tMon, 26 Jul 2021 10:52:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A5574687B9;\n\tMon, 26 Jul 2021 12:52:52 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 439F9687AF\n\tfor ;\n\tMon, 26 Jul 2021 12:52:51 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CA425332;\n\tMon, 26 Jul 2021 12:52:50 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"raUWUX+K\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1627296770;\n\tbh=nauXvnui+oq+BKyvJgcyj/0cu3lD7I2VsabTwfTggaA=;\n\th=From:Subject:To:Cc:References:Date:In-Reply-To:From;\n\tb=raUWUX+KwWDGCRVCcalog8H6BkD414thYPhpqcIKcg26VCpv/yWKG/2uGqe1IaGo8\n\tVKamh2+NKWHbV2rgcmecLfk/+E7XBE4KQHnmPpiXhlTAELnK9p9iYkZuduR3UPGsgh\n\tH1lDnxkqD8hpAdDdsLNqHuANiZVTYChI3F46q1MQ=","From":"Kieran Bingham ","To":"Umang Jain ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210724092147.36896-1-umang.jain@ideasonboard.com>\n\t<98842682-ed35-fe50-1ead-fa6c81e83f79@ideasonboard.com>\n\t<225cebcf-9e4d-5528-5829-217ee89742f6@ideasonboard.com>","Message-ID":"","Date":"Mon, 26 Jul 2021 11:52:47 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.11.0","MIME-Version":"1.0","In-Reply-To":"<225cebcf-9e4d-5528-5829-217ee89742f6@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH] android: nautilus: Add camera HAL\n\tconfiguration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]